Gossamer Forum: Products: Gossamer Links: Development, Plugins and Globals: MyLinks SQL: Page 7

Veteran (19537 posts)

Apr 6, 2003, 6:46 AM

Post #151 of 193

Shortcut

Re: [klauslovgreen] Bug or feature? In reply to

Oh the other issue I forgot to mention is that two new column have been added to the user table so you would have to drop and re-create the tables to make that table update. Or if you don't want to do that you can add them manually using the table editor.

Col Spec:

FolderSortField, VARCHAR, 255, ^[\w\s]+$

FolderSortOrd, VARCHAR, 255, ^(?:A|DE)SC$

Last edited by:

Paul: Apr 6, 2003, 6:46 AM

Apr 6, 2003, 6:48 AM

Enthusiast (671 posts)

Apr 6, 2003, 6:48 AM

Post #152 of 193

Shortcut

Re: [Paul] Bug or feature? In reply to

no problem - all my tables are empty anyway - but for some it is surely important...

Let me know when the new version is available for download...

What are the > issues in the html?

Klaus

Apr 6, 2003, 6:51 AM

Veteran (19537 posts)

Apr 6, 2003, 6:51 AM

Post #153 of 193

Shortcut

Re: [klauslovgreen] Bug or feature? In reply to

Quote:

What are the > issues in the html?

People wanted me to remove html from the fields incase someone entered some nasty code or just decided to go to town by formatting their folders or links =)

But, that would mean I'd have to check each field and report any errors, so the easiest thing to do it convert < to < and so if anyone enters html it will just show as plain text rather than being parsed as html.

Apr 6, 2003, 6:52 AM

Enthusiast (671 posts)

Apr 6, 2003, 6:52 AM

Post #154 of 193

Shortcut

Re: [Paul] Bug or feature? In reply to

Ah ok - sorry - I solved it with a global I use for other fields stripping html code...

Klaus

Apr 6, 2003, 7:05 AM

Veteran (19537 posts)

Apr 6, 2003, 7:05 AM

Post #155 of 193

Shortcut

Re: [klauslovgreen] Bug or feature? In reply to

Ok it has been updated. Probably created more bugs in the process Wink

Apr 6, 2003, 7:16 AM

Enthusiast (671 posts)

Apr 6, 2003, 7:16 AM

Post #156 of 193

Shortcut

Re: [Paul] Bug or feature? In reply to

Cheers Paul - will give it a go and keep you posted :-)

Klaus

Apr 6, 2003, 7:17 AM

Veteran (19537 posts)

Apr 6, 2003, 7:17 AM

Post #157 of 193

Shortcut

Re: [klauslovgreen] Bug or feature? In reply to

I dread seeing replies in this thread now as I keep thinking it's another bug report Angelic

Apr 6, 2003, 7:59 AM

Enthusiast (671 posts)

Apr 6, 2003, 7:59 AM

Post #158 of 193

Shortcut

Think it is there now :-) In reply to

Hi Paul,

Seems everyhting is under control now - could not put my fingers on anything.. :-)

Thanks for your help
Klaus

Apr 6, 2003, 8:18 AM

Enthusiast (671 posts)

Apr 6, 2003, 8:18 AM

Post #159 of 193

Shortcut

Re: [Paul] Bug or feature? In reply to

Hi Paul,

One more question - how can I use HTML code in the e-mail message (Recommend.eml.html)?

Klaus

Apr 6, 2003, 9:01 AM

Veteran (19537 posts)

Apr 6, 2003, 9:01 AM

Post #160 of 193

Shortcut

Re: [klauslovgreen] Bug or feature? In reply to

You'd need to change the header passed into GT::Mail on line 918 of MyLinks2.pm. You'd need to add:

type => 'text/html',

Last edited by:

Paul: Apr 6, 2003, 9:01 AM

Apr 6, 2003, 9:08 AM

Enthusiast (671 posts)

Apr 6, 2003, 9:08 AM

Post #161 of 193

Shortcut

Re: [Paul] Bug or feature? In reply to

yes it worked - thanks Paul

Klaus

Apr 6, 2003, 9:52 AM

Enthusiast (671 posts)

Apr 6, 2003, 9:52 AM

Post #162 of 193

Shortcut

Re: [Paul] Bug or feature? In reply to

Hi Paul,

In the recommed function - if you leave freind name empty or enter a non valid e-mail address I get:

The email address 'ARRAY(0x84fd674)' is invalid.

Any suggestions?
Klaus

Apr 6, 2003, 9:55 AM

Veteran (19537 posts)

Apr 6, 2003, 9:55 AM

Post #163 of 193

Shortcut

Re: [klauslovgreen] Bug or feature? In reply to

Blech. Line 862 of MyLinks2.pm change:

Code:
unless ($input->{$field}->[2] =~ /^[a-zA-Z ]+$/) { 
       $error .= Links::language('MY_REC_BAD_NAME', $input->{$field})  . '<br>'; 
       next; 
} 
unless ($input->{$field}->[1] =~ /^\S+@\S+\.\S+$/i) { 
       $error .= Links::language('MY_REC_BAD_EMAIL', $input->{$field}) . '<br>'; 
       next; 
}

to...

Code:
unless ($input->{$field}->[2] =~ /^[a-zA-Z ]+$/) { 
       $error .= Links::language('MY_REC_BAD_NAME', $input->{$field}->[2])  . '<br>'; 
       next; 
} 
unless ($input->{$field}->[1] =~ /^\S+@\S+\.\S+$/i) { 
       $error .= Links::language('MY_REC_BAD_EMAIL', $input->{$field}->[1]) . '<br>'; 
       next; 
}

Last edited by:

Paul: Apr 6, 2003, 9:55 AM

Apr 6, 2003, 10:04 AM

Enthusiast (671 posts)

Apr 6, 2003, 10:04 AM

Post #164 of 193

Shortcut

Re: [Paul] Bug or feature? In reply to

Thnaks Paul - hope that's the last time I need to bother you with this plugin Blush

Klaus

Apr 7, 2003, 9:53 AM

Veteran (1240 posts)

Apr 7, 2003, 9:53 AM

Post #165 of 193

Shortcut

Re: [klauslovgreen] Bug or feature? In reply to

Paul:

Just d/led the plug-in, and I am starting to edit the templates. I have a couple extra User fields (Location, Hobbies, etc) and I wanted to add those fields to your "my_profile.html" page, so that the user could edit them all there.

Is it OK if I just add the new fields to the html page, or do I also have to edit youe of the .pm files and all so that those "new" fields are recognized and updated?

Thanks!
dave

Big Cartoon DataBase
Big Comic Book DataBase

Apr 7, 2003, 10:05 AM

Veteran (19537 posts)

Apr 7, 2003, 10:05 AM

Post #166 of 193

Shortcut

Re: [carfac] Bug or feature? In reply to

You can just add them into the template - no perl code changes needed =)

Last edited by:

Paul: Apr 7, 2003, 10:47 AM

Apr 7, 2003, 10:20 AM

Veteran (1240 posts)

Apr 7, 2003, 10:20 AM

Post #167 of 193

Shortcut

Re: [Paul] Bug or feature? In reply to

Paul:

Thanks- that makes it easy!
dave

Big Cartoon DataBase
Big Comic Book DataBase

Apr 7, 2003, 11:29 AM

Enthusiast (671 posts)

Apr 7, 2003, 11:29 AM

Post #168 of 193

Shortcut

Suggestion In reply to

Hi Poul,

Two things (for the next version I suppose as this one is done).

1. Option to select which folder is default
2. Option to make multiple link move

Cheers
Klaus

Apr 7, 2003, 11:34 AM

Veteran (19537 posts)

Apr 7, 2003, 11:34 AM

Post #169 of 193

Shortcut

Re: [klauslovgreen] Suggestion In reply to

Thanks for the ideas. They'll no doubt get added this week sometime.

Apr 8, 2003, 2:47 PM

Veteran (1240 posts)

Apr 8, 2003, 2:47 PM

Post #170 of 193

Shortcut

Re: [Paul] Suggestion In reply to

Paul:

Hate to be the pest, but a couple things...

MY_BADLINK_URL came up when testing Reccomend It, using my addy and name, and no TO addy or name... Might want to add that into your language pack.

When I go to see the user list, I put ONE public folder in it (mine!) for right now. But it does not show up- in fact, it teells me there are 0 users, not 1.

Also, when pulling up the User List, I found it VERY CPU intensive- 15-20 percent, for 20 seconds or so... the only thing I have that runs that hard is a rebuild of Links! Smile

OK, all fairly minor things, but thought you would want to be aware!

Other than that, looks good. Hope to put it online later tomorrow.
dave

Big Cartoon DataBase
Big Comic Book DataBase

Apr 8, 2003, 3:35 PM

Veteran (19537 posts)

Apr 8, 2003, 3:35 PM

Post #171 of 193

Shortcut

Re: [carfac] Suggestion In reply to

Quote:

MY_BADLINK_URL came up when testing Reccomend It, using my addy and name, and no TO addy or name... Might want to add that into your language pack.

Hmm. MY_BADLINK_URL is for a URL that is dead. You can add the language var manually if you want - something like:

The URL '%s' is dead.

I'll fix it up though soon.

Quote:

When I go to see the user list, I put ONE public folder in it (mine!) for right now. But it does not show up- in fact, it teells me there are 0 users, not 1.

Strange. I've not seen that before. Can you tell me what you see for the entry in the MyLinks2 table and the corresponsing entry in the MyLinks2_Folders table.

Quote:

Also, when pulling up the User List, I found it VERY CPU intensive- 15-20 percent, for 20 seconds or so... the only thing I have that runs that hard is a rebuild of Links!

I am aware of that (unfortunately Unsure

)...you can see my post on it here...

http://www.gossamer-threads.com/...i?post=238753#238753

This will definitely be altered.

Last edited by:

Paul: Apr 8, 2003, 3:35 PM

Apr 8, 2003, 3:37 PM

Veteran (19537 posts)

Apr 8, 2003, 3:37 PM

Post #172 of 193

Shortcut

Re: [carfac] Suggestion In reply to

Actually ignore my reply for the second quote. It is happening for me too.

I'll update all these issues asap. Hopefull by tommorrow.

Apr 8, 2003, 3:39 PM

Veteran (19537 posts)

Apr 8, 2003, 3:39 PM

Post #173 of 193

Shortcut

Re: [carfac] Suggestion In reply to

When you made your folder public were you logged in as an administrator? If so you need to add Administrator status into the plugin options "Show Status" field.

Last edited by:

Paul: Apr 8, 2003, 3:40 PM

Apr 8, 2003, 3:57 PM

Veteran (1240 posts)

Apr 8, 2003, 3:57 PM

Post #174 of 193

Shortcut

Re: [Paul] Suggestion In reply to

Paul:

>>> I'll update all these issues asap. Hopefull by tommorrow.

No rush. I had already added some language for the one error... I just thought you would like to know.

Yes, I was logged in as am admin...

Where are the "plugin options "Show Status" field" located at?

Also, when I was in language, I see that there is a limit on the number of folders/links etc one can have (or I assume that based on some of the rror language I see there). Where do set the limits for these? Under Insralled Plug Ins, I only have an "About" link, no "set up" links or things like that. (Sorry if that is a stupid question!)
dave

Big Cartoon DataBase
Big Comic Book DataBase

Apr 8, 2003, 3:59 PM