Gossamer Forum: General: Internet Technologies: div hiding issues

May 29, 2008, 11:45 PM

Andy

Veteran / Moderator (18441 posts)

May 29, 2008, 11:45 PM

Post #1 of 9

Shortcut

div hiding issues

Hi,

Can anyone suggest why this isn't working in FF?

Code:
<script> 
function showhide(id){ 

 if (document.getElementById){ 
    obj = document.getElementById(id); 
    if (obj.style.display == "none"){ 
       obj.style.display = ""; 
    } else { 
       obj.style.display = "none"; 
    } 

    if (id != 'title_div') { title_div.style.display = "none"; } 
    if (id != 'subheader_div') { subheader_div.style.display = "none"; }     
    if (id != 'lead_div') { lead_div.style.display = "none"; }     
    if (id != 'video_div') { video_div.style.display = "none"; }     
    if (id != 'testimonials_div') { testimonials_div.style.display = "none"; }     
    if (id != 'header_div') { header_div.style.display = "none"; }         
 } 
} 
</script>

Basically, it all works - appart from the last few lines.

Code:
    if (id != 'title_div') { title_div.style.display = "none"; }

..gives:

Quote:

Error: title_div is not defined
Source File: http://www.site.com/cgi-bin/add_more_info.cgi?ID=18
Line: 71

Guessing I'm using the wrong format with this bit:

Code:
title_div.style.display

...any suggestions? (I've had a look on google, but couldn't find anything helpful :/)

Cheers

Andy (mod)
andy@ultranerds.co.uk

May 30, 2008, 12:19 AM

brewt

Staff (4101 posts)

May 30, 2008, 12:19 AM

Post #2 of 9

Shortcut

Re: [Andy] div hiding issues In reply to

It's as the error says - title_div is not defined. Did you initialise it (in your case, did you set the html element to it)?

Adrian

May 30, 2008, 12:21 AM

Andy

Veteran / Moderator (18441 posts)

May 30, 2008, 12:21 AM

Post #3 of 9

Shortcut

Re: [brewt] div hiding issues In reply to

Hi,

Do you mean do I have the code for it?

Code:
				<div id="title_div" style="display: none;"> 
				  <input type="text" name="Title" size="30"> 
				</div>

Not sure if it makes a difference, but this is AFTER the show/hide link;

Code:
<a href="#" onclick="showhide('title_div');">Title</a></a> (<a href="#d">what is this?</a>)

..TIA!

Andy (mod)
andy@ultranerds.co.uk

May 30, 2008, 3:00 AM

neves

Novice (30 posts)

May 30, 2008, 3:00 AM

Post #4 of 9

Shortcut

Re: [Andy] div hiding issues In reply to

Code:
if (id != 'title_div') { document.getElementById("title_div").style.display = "none"; }

For things like that I use prototype.js. With prototype.js included it should look like:

Code:
if (id != 'title_div') { $("title_div").hide(); }

May 30, 2008, 3:01 AM

Andy

Veteran / Moderator (18441 posts)

May 30, 2008, 3:01 AM

Post #5 of 9

Shortcut

Re: [neves] div hiding issues In reply to

Hi,

Thanks for the reply. Whats "prototype.js" ??

Cheers

Andy (mod)
andy@ultranerds.co.uk

May 30, 2008, 3:11 AM

neves

Novice (30 posts)

May 30, 2008, 3:11 AM

Post #6 of 9

Shortcut

Re: [Andy] div hiding issues In reply to

It's a javascript framework:

http://www.prototypejs.org/

One advantage is you dont have to think about any browser compatibilities ... more or less.

May 30, 2008, 3:23 AM

Andy

Veteran / Moderator (18441 posts)

May 30, 2008, 3:23 AM

Post #7 of 9

Shortcut

Re: [neves] div hiding issues In reply to

Hi,

Thanks, works a charm Smile

Cheers

Andy (mod)
andy@ultranerds.co.uk

May 30, 2008, 9:39 PM

tandat

Enthusiast (809 posts)

May 30, 2008, 9:39 PM

Post #8 of 9

Shortcut

Re: [Andy] div hiding issues In reply to

Hi Andy,

This should be the missing tag div of 'title_div'. Something like <div id="title_div"...>

Cheers,

Dat

Programming and creating plugins and templates
Blog

May 30, 2008, 11:41 PM

Andy

Veteran / Moderator (18441 posts)

May 30, 2008, 11:41 PM

Post #9 of 9

Shortcut

Re: [tandat] div hiding issues In reply to

Hi,

I already have that:

Code:
<div id="title_div" style="display: none;"> 
  <input type="text" name="Title" size="30"> 
</div>

Doesn't matter now though - as I've got it workin :)

Cheers

Andy (mod)
andy@ultranerds.co.uk