Gossamer Forum
(Advanced Search)
for
Home : Products : Gossamer Links : Discussions :

GLinks 3RC - View Search Logs Bug

Apr 3, 2005, 12:56 AM
rocco
User (77 posts)
Apr 3, 2005, 12:56 AM
Post #1 of 7
Views: 2324
Shortcut
Quote Reply
GLinks 3RC - View Search Logs Bug
Some minor bugs with the Search Logger feature :

1. The "Last Searched" field always shows the same date/time stamp for all entries. The date is just the last search made. I assume this is not what's intended.
2. If you toggle the "Results" column, the results are not ordered correctly. For eg. I get (1, 490, 387, 15) for ascending order and (15, 387, 490,1) for descending order.

Regards,
Peter Puglisi
www.ausfreedom.com
Ultimate Freedom is our game.

Last edited by:

rocco: Apr 3, 2005, 1:01 AM
Apr 3, 2005, 7:51 AM
rocco
User (77 posts)
Apr 3, 2005, 7:51 AM
Post #2 of 7
Views: 2241
Shortcut
Quote Reply
Re: [rocco] GLinks 3RC - View Search Logs Bug In reply to
Also noticed that.

The cgi parameters for the "Last Searched" link is something like:
...admin.cgi?do=page;page=tools_search_logs.html;sb=slog_hits;so

For the "Results" link, they are:
...admin.cgi?do=page;page=tools_search_logs.html;sb=slog_last;so

The "sb" parameters look incorrectly mismatched and are probably related to the problem.

Regards,
Peter Puglisi
www.ausfreedom.com
Ultimate Freedom is our game.
Apr 3, 2005, 9:26 AM
HyperTherm
Enthusiast (928 posts)
HyperTherm's avatar
Apr 3, 2005, 9:26 AM
Post #3 of 7
Views: 2241
Shortcut
Quote Reply
Re: [rocco] GLinks 3RC - View Search Logs Bug In reply to
The error is confirmed here also.
Toggling on Results count does not work as it should be.
Time always gets updtaed for all historical searches also with the time of last search.

Thanks
HyTC
==================================
Mail Me If Contacting Privately Is That Necessary.
==================================
Apr 4, 2005, 4:13 PM
brewt
Staff (4101 posts)
brewt's avatar
Apr 4, 2005, 4:13 PM
Post #4 of 7
Views: 2218
Shortcut
Quote Reply
Re: [rocco] GLinks 3RC - View Search Logs Bug In reply to
Here's a patch to admin/templates/admin/tools_search_logs.html:
Code:
--- tools_search_logs.html 15 Mar 2005 23:12:09 -0000 1.6
+++ tools_search_logs.html 4 Apr 2005 22:25:44 -0000 1.7
@@ -20,8 +20,8 @@
<tr>
<th width="45%" class="heading"><a href="admin.cgi?do=page;page=tools_search_logs.html;sb=slog_query;so=<%if not so or sb ne 'slog_query' or so eq 'DESC'%>ASC<%else%>DESC<%endif%>;nh=<%nh%>;mh=<%mh%>">Query</a></th>
<th width="9%" class="heading"><a href="admin.cgi?do=page;page=tools_search_logs.html;sb=slog_count;so=<%if not so or sb ne 'slog_count' or so eq 'ASC'%>DESC<%else%>ASC<%endif%>;nh=<%nh%>;mh=<%mh%>">Count</a></th>
- <th width="22%" class="heading"><a href="admin.cgi?do=page;page=tools_search_logs.html;sb=slog_hits;so=<%if not so or sb ne 'slog_hits' or so eq 'ASC'%>DESC<%else%>ASC<%endif%>;nh=<%nh%>;mh=<%mh%>">Last Searched</a></th>
- <th width="10%" class="heading"><a href="admin.cgi?do=page;page=tools_search_logs.html;sb=slog_last;so=<%if not so or sb ne 'slog_last' or so eq 'ASC'%>DESC<%else%>ASC<%endif%>;nh=<%nh%>;mh=<%mh%>">Results</a></th>
+ <th width="22%" class="heading"><a href="admin.cgi?do=page;page=tools_search_logs.html;sb=slog_last;so=<%if not so or sb ne 'slog_last' or so eq 'ASC'%>DESC<%else%>ASC<%endif%>;nh=<%nh%>;mh=<%mh%>">Last Searched</a></th>
+ <th width="10%" class="heading"><a href="admin.cgi?do=page;page=tools_search_logs.html;sb=slog_hits;so=<%if not so or sb ne 'slog_hits' or so eq 'ASC'%>DESC<%else%>ASC<%endif%>;nh=<%nh%>;mh=<%mh%>">Results</a></th>
<th width="14%" class="heading"><a href="admin.cgi?do=page;page=tools_search_logs.html;sb=slog_time;so=<%if not so or sb ne 'slog_time' or so eq 'ASC'%>DESC<%else%>ASC<%endif%>;nh=<%nh%>;mh=<%mh%>">Avg.&nbsp;Time Elapsed</a></th>
</tr>

@@ -29,7 +29,7 @@
<tr>
<td><a href="<%cgi_url%>/search.cgi?query=<%escape_url slog_query%>" target="_linksearch"><%escape_html slog_query%></a></td>
<td><%slog_count%></td>
- <td><nobr><%GT::Date::date_get($slot_last, '%yyyy%-%mm%-%dd% %h%:%MM% %tt%')%></nobr></td>
+ <td><nobr><%GT::Date::date_get($slog_last, '%yyyy%-%mm%-%dd% %h%:%MM% %tt%')%></nobr></td>
<td><%slog_hits%></td>
<td><%if slog_time%><%slog_time_formatted%><%else%><i>Unknown</i><%endif%></td>
</tr>

Adrian
Apr 4, 2005, 4:19 PM
HyperTherm
Enthusiast (928 posts)
HyperTherm's avatar
Apr 4, 2005, 4:19 PM
Post #5 of 7
Views: 2213
Shortcut
Quote Reply
Re: [brewt] GLinks 3RC - View Search Logs Bug In reply to
Could this be added to the Update ?
:)

Thanks
HyTC
==================================
Mail Me If Contacting Privately Is That Necessary.
==================================
Apr 4, 2005, 9:06 PM
rocco
User (77 posts)
Apr 4, 2005, 9:06 PM
Post #6 of 7
Views: 2205
Shortcut
Quote Reply
Re: [brewt] GLinks 3RC - View Search Logs Bug In reply to
Excellent. Thanks Adrian.

Regards,
Peter Puglisi
www.ausfreedom.com
Ultimate Freedom is our game.
Apr 4, 2005, 9:50 PM
brewt
Staff (4101 posts)
brewt's avatar
Apr 4, 2005, 9:50 PM
Post #7 of 7
Views: 2186
Shortcut
Quote Reply
Re: [HyperTherm] GLinks 3RC - View Search Logs Bug In reply to
Argh, was posting the update at work, but I got distracted and didn't finish posting it. Will add it to the update system tomorrow.

Adrian