Gossamer Forum: Products: Gossamer Links: Discussions: Payment Bug

Jul 30, 2004, 1:15 AM

ryel01

Veteran (1264 posts)

Jul 30, 2004, 1:15 AM

Post #1 of 7

Shortcut

Payment Bug - Unknown Tags if no method selected

After entering their link details a user is then presented with the payment page, where they are asked to select their chosen payment method.

Bug: If the user hits 'next' without selecting any payment type the error page is returned to them but all the link and payment details are returned with "Unknown Tag:".

The payment methods are then not able to be selected because they're all "Unknown Tag:" with no forms anymore.

If someone from GT could confirm if this is a bug and post a fix that would be great.

Thanks!

Regan.

Jul 30, 2004, 1:24 AM

Andy

Veteran / Moderator (18441 posts)

Jul 30, 2004, 1:24 AM

Post #2 of 7

Shortcut

Re: [ryel01] Payment Bug - Unknown Tags if no method selected In reply to

Hi. I managed to get around this by editing payment_form.html (I believe), and just formatting it like;

<%if error%>
show <%error%>
<%else%>
.. show normal stuff
<%endif%>

Not sure if its anything deeper .. as I did notice this a while ago (on several installations). Making the above change I mentioned does seem to fix it though :)

Hope that helps.

Cheers

Andy (mod)
andy@ultranerds.co.uk

Jul 30, 2004, 1:32 AM

ryel01

Veteran (1264 posts)

Jul 30, 2004, 1:32 AM

Post #3 of 7

Shortcut

Re: [Andy] Payment Bug - Unknown Tags if no method selected In reply to

Does that mean the user has to hit the back button to select the payment again?

Jul 30, 2004, 1:36 AM

Andy

Veteran / Moderator (18441 posts)

Jul 30, 2004, 1:36 AM

Post #4 of 7

Shortcut

Re: [ryel01] Payment Bug - Unknown Tags if no method selected In reply to

Yup :(

You could just add in a javascript:history(-1) link or something after the error message. This should let you send them back a page.

Cheers

Andy (mod)
andy@ultranerds.co.uk

Jul 30, 2004, 3:01 AM

ryel01

Veteran (1264 posts)

Jul 30, 2004, 3:01 AM

Post #5 of 7

Shortcut

Re: [Andy] Payment Bug - Unknown Tags if no method selected In reply to

Hi Andy

This one's for free...

Changes to lines 102 & 103 in Add.pm

Code:
#102            print $IN->header(); 
#103            print Links::SiteHTML::display ($page, $vars); 
			my $opt = Links::Payment::load_cat_price($IN->param('cat_id')); 
			my $link = $DB->table('Links')->get($IN->param('link_id')); 
            print $IN->header(); 
			print Links::SiteHTML::display ($page, { %$vars, %$opt, %$link });

A similar fix is needed for Modify.pm too it seems because if you click on the "new payment" link next to the example of your link above the payment info then it jumps to modify... will figure that out and post it soon too.

Cool

regan

Jul 30, 2004, 3:10 AM

ryel01

Veteran (1264 posts)

Jul 30, 2004, 3:10 AM

Post #6 of 7

Shortcut

Re: [Andy] Payment Bug - Unknown Tags if no method selected In reply to

The fix for Modify.pm...

Changes to lines 90 & 91

Code:
#90            print $IN->header(); 
#91            print Links::SiteHTML::display ($page, $vars); 
			my $opt = Links::Payment::load_cat_price($IN->param('cat_id')); 
            my $link = $DB->table('Links')->get($IN->param('link_id')); 
            print $IN->header(); 
            print Links::SiteHTML::display ($page, { %$vars, %$opt, %$link });

Seems to work for me! Smile

Regan

Jul 30, 2004, 6:09 AM

Andy

Veteran / Moderator (18441 posts)

Jul 30, 2004, 6:09 AM

Post #7 of 7

Shortcut

Re: [ryel01] Payment Bug - Unknown Tags if no method selected In reply to

Thanks for sharing that :) Let see if GT can get it fixed up in the distributed version now Angelic

Cheers

Andy (mod)
andy@ultranerds.co.uk