Basically, I have two sub routines. One, called get_info() and the other show_stats(). Get_info() is called first, and then does some queries etc to get values from a SQL database. The problem I am having though is getting back the variables that were created into the show_stats() variable. I've tried array_pop() to add it to the $GLOBALS array, but that doesn't work.

Anyone got any ideas?

Thanks

Andy (mod)
andy@ultranerds.co.uk

---

Want to give me something back for my help? Please see my Amazon Wish List
GLinks ULTRA Package | GLinks ULTRA Package PRO
Links SQL Plugins | Website Design and SEO | UltraNerds | ULTRAGLobals Plugin | Pre-Made Template Sets | FREE GLinks Plugins!

Can't you pass the variables to your second routine?

Yeah, but I don't really want to do that. To make the code cleaner and a bit more easy to understand I prefer not to pass it through the subs. For that reason I am defining what subs to call at the top of the pag, like;

get_info();
show_stats();

So it executes the first sub, gets all the info, then should return the info for the show_stats one to use. But I'm not sure how to return them

Thanks anyway.

Andy (mod)
andy@ultranerds.co.uk

---

Want to give me something back for my help? Please see my Amazon Wish List
GLinks ULTRA Package | GLinks ULTRA Package PRO
Links SQL Plugins | Website Design and SEO | UltraNerds | ULTRAGLobals Plugin | Pre-Made Template Sets | FREE GLinks Plugins!

How about:

get_info(&show_stats);

Nope, and FWIW you don't need the '&' in PHP

Andy (mod)
andy@ultranerds.co.uk

---

Want to give me something back for my help? Please see my Amazon Wish List
GLinks ULTRA Package | GLinks ULTRA Package PRO
Links SQL Plugins | Website Design and SEO | UltraNerds | ULTRAGLobals Plugin | Pre-Made Template Sets | FREE GLinks Plugins!

>>Nope<<

Nope what?

>> and FWIW you don't need the '&' in PHP <<

Thats why php is so confusing ....having said that you don't need it in perl either (well depends what you are doing).

Perl and PHP are both great languages. PHP makes SQL sooo much easier (IMO) cos it has loads of functions and stuff for it (i.e. less coding...lol)...but perl has better error catching for mail sending etc (PHP just returns true or false for the delivery, and as far as i know there is no way to catch the errors)

Andy (mod)
andy@ultranerds.co.uk

---

Want to give me something back for my help? Please see my Amazon Wish List
GLinks ULTRA Package | GLinks ULTRA Package PRO
Links SQL Plugins | Website Design and SEO | UltraNerds | ULTRAGLobals Plugin | Pre-Made Template Sets | FREE GLinks Plugins!

array_pop() is removing elements not adding, you need array_push()

Im basing my answer on what I know from perl, so it if it's wrong don't blame me :)

Can't remember what it was I used actually :P Just array_pop rung a bell...lol.

I think I'm just gonna have to resort to putting the variables in the sub call

That was one of your old sigs here wasnt it?

Andy (mod)
andy@ultranerds.co.uk

---

Want to give me something back for my help? Please see my Amazon Wish List
GLinks ULTRA Package | GLinks ULTRA Package PRO
Links SQL Plugins | Website Design and SEO | UltraNerds | ULTRAGLobals Plugin | Pre-Made Template Sets | FREE GLinks Plugins!

Don't blame me if I'm wrong

Just to cover any law suits

Depends on what you want to do.

Adrian

Wrong again, it returns true or false for the delivery, BUT if you have track_errors turned on, the error message will be stored in the global variable $php_errormsg.

Adrian

And to answer your original question. Just go: global $VAR; in the sub to use a global variable (or to define it). Or you can define it in the global namespace (ie. not in a sub).

Adrian

You do if you want to pass by reference instead of creating a copy of the variable...


That aside, as was stated, yes, you need to put global $your_var in the sub you want to use the global in.

You should use as few globals as possible though.

Is there a reason for trying to avoid a lot of globals?
Cheers,
Michael Bray

Wow, thanks for that. Didn't realise about $php_errormsg. I'll have to look into this more. As for the globals, I've ended up using;


Its actually better as I can re-use one function for 12 methods (and it makes the code a bit cleaner, unusual for me ).

Thanks.

Andy (mod)
andy@ultranerds.co.uk

---

Want to give me something back for my help? Please see my Amazon Wish List
GLinks ULTRA Package | GLinks ULTRA Package PRO
Links SQL Plugins | Website Design and SEO | UltraNerds | ULTRAGLobals Plugin | Pre-Made Template Sets | FREE GLinks Plugins!

Calling a subroutine isn't a method is it?

Why don't you do all months at once?

my (@results) = getmonthstats(@months);

Well, it works, so yeah Can't you do that in Perl?

Cos I don't wanna Also, PHP doesn't use the @ sign to define arrays. You have to get used to these subtle diffeences between PHP and Perl.

Andy (mod)
andy@ultranerds.co.uk

---

Want to give me something back for my help? Please see my Amazon Wish List
GLinks ULTRA Package | GLinks ULTRA Package PRO
Links SQL Plugins | Website Design and SEO | UltraNerds | ULTRAGLobals Plugin | Pre-Made Template Sets | FREE GLinks Plugins!

Yes. it's poor programming practice. Well, if you're doing something small it's ok but one you start getting at even a bit of complexity you should avoid them.

scope your variables to be used only where they are needed. That way it's easier to track down a problem. A global can be changed anywhere, and you could lose track of it, thus it gets changed somewhere, and you can't figure out why you're getting something different than what you're expecting.

And if you find yourself doing something like

my_sub($var1, $var2, $var3...$var18) {

(which addmittedly can grow tiresome), then find a better way to house your data instead of in seperate variables. There's nothing wrong with storing everything in an array (php) or hash (perl) and just passing that.

--mark

I was referring to the word "method" rather than the actual code.

A method is not what you were just describing as a method, at least not in perl.