Hello... I'm having a problem with CGI.PM upload function:

--------
$image = $q->param('image');
open(IMGFL,">$imageloc");
while ($bytesread=read($image,$buffer,1024)){
print IMGFL $buffer;
}
close(IMGFL);
--------

Binary files are broken ... it looks like it is uploading in text mode (i noticed this with images)

ideas?

You aren't using CGI.pm to upload :)

Use:

http://stein.cshl.org/.../CGI/#upload_caveats

- wil

Hi Paul!

Your code works great on windows ... THANKS!!!!
but I'm having the same problem on unix.
I tried to remove the binmode ...no results :(

Ideas? How can I make it work on a nix o.s.?

What's the error message? It should work on Unix. Maybe you should check file permissions, or even better CHMOD the file before printing to it.

This is the 'correct' CGI.pm way of doing things.


- wil

wil,

the problem is that it is uploading in text mode ... resulting that images are broken.

i don't get any server error. the file goes up to the server and the file-size is correct .

I use that code I gave you and it works fine on linux and windows.

But the method Paul shows you doesn't upload anything in ASCII or BINARY mode, that all is does is write the data to a file. It's up to you what extension you put on the file after, maybe that's the problem?

- wil

>>But the method Paul shows you doesn't upload anything in ASCII or BINARY mode<<

Yes it does, otherwise I would have wasted my time adding in binmode()

http://www.perldoc.com/...od/func/binmode.html

Strange, because the solution I provided in this post works for me without any mention of binmode.

- wil

Take a look at the binmode link above...it explains when it is needed and when it isn't.

It is generally needed for compatibility......anyway, that wasn't the comment you made...you said the code I provided didn't affect the mode that the file was uploaded in, not whether it worked or not.

OK. thank you for your help ...

Code from Paul is great on windows but wil's code works for linux.

I guess we solved the problem. Thank you!!

Wils code is practically the same as mine...the only difference is the binmode line. If you think that is causing you problems try chaging it to:

binmode(IMGFL) if $^O eq 'MSWin32';

And I'm changing permissions before writing.

- wil

Yes I was looking at that before...the code doesn't make sense...you are chmodding something non existant?

If you change your code to:

chmod (0777, $filename) or die;

....you'll probably find it dies

ok works ... just tired :(((
thanks. but what about 'MSWin32'?
will it work fine always?

The while loop works fine on linux, trust me :)

Do you want me to prove it?

Yeah it will work.

Here's my little demo:

http://www.wiredon.net/cgi-bin/proof/index.cgi

http://www.wiredon.net/...f/index.cgi?source=1

Doesn't work for me - I upload and then get a 404 error while trying to view the file I uploaded :-)

- wil

Works fine for me...I tested about 15 times ;)

What filename did you enter?

This is working on win, unix, linux ...


open(IMGFL,">$imageloc");
binmode(IMGFL) if $^O eq 'MSWin32';
while (<$image>){print IMGFL;}
close(IMGFL);



RobyOne