I don't know about you, but this code scares the bejeebers out of me. 
Things like:
open(IN, "$ENV{'QUERY_STRING'}");
or worse:
I would not recommend putting this code on anyone's server. It would be very easy to cause damage, or crash the script (that's my impression from a 5 minute glance).
A good way to check if your program follows good programming practices is to check if open() calls and other system calls are checked for errors. Novice programmers will often do:
open (IN, "blah.txt");
and not check to see if the open was successful. This will cause the script to continue running when it should have coughed up an error, leading to possible disasertous results..
Just my 0.02..
Alex
Things like:
Quote:
if(-e "$InDir/$ENV{'QUERY_STRING'}") { open(IN, "$ENV{'QUERY_STRING'}");
or worse:
Quote:
open(INFO, ">$InfoDir/$form{'id'}");I would not recommend putting this code on anyone's server. It would be very easy to cause damage, or crash the script (that's my impression from a 5 minute glance).
A good way to check if your program follows good programming practices is to check if open() calls and other system calls are checked for errors. Novice programmers will often do:
open (IN, "blah.txt");
and not check to see if the open was successful. This will cause the script to continue running when it should have coughed up an error, leading to possible disasertous results..
Just my 0.02..
Alex
