Gossamer Forum
(Advanced Search)
for
Home : Products : Gossamer Links : Discussions :

Luna template change request

Apr 8, 2006, 12:24 AM
rgbworld
User (325 posts)
rgbworld's avatar
Apr 8, 2006, 12:24 AM
Post #1 of 8
Views: 3182
Shortcut
Quote Reply
Luna template change request
I would like to request 2 additional templates to be added to the default luna template set.

The template would be called 'include_contentwrapper.html'.
It would be inserted BETWEEN 'contentwrapper' and 'shadowleft'.

This would allow inserting content within the contentwrapper immediately preceeding
the shadowed content area. It involves splitting the currently merged css into 2 separate div's.
So, to do this from my side, involves editing every template.

It would also be nice to have an 'include' within the shadowed content area.
This should be called 'include_content.html' as it is actually in the content tag.

Default Luna CSS
Code:
<%include include_leftsidebar.html%>
<div id="contentwrapper" class="shadowleft">
<div class="shadowtop"><div class="shadowtopleft"></div><div class="shadowtopright"></div></div>
<div class="shadowright">
<div id="content">


</div>
</div>
<div class="shadowbottom"><div class="shadowbottomleft"></div><div class="shadowbottomright"></div></div>
</div>
<%include include_rightsidebar.html%>


Proposed Change
Code:
<%include include_leftsidebar.html%>
<div id="contentwrapper">

<%include include_contentwrapper.html%>

<div class="shadowleft">

<div class="shadowtop"><div class="shadowtopleft"></div><div class="shadowtopright"></div></div>
<div class="shadowright">
<div id="content">

<%include include_content.html%>

</div>
</div>
<div class="shadowbottom"><div class="shadowbottomleft"></div><div class="shadowbottomright"></div></div>
</div>

</div>

<%include include_rightsidebar.html%>


Hopefully it makes sense. My experience with the luna template set, these includes would benefit many,
and I don't see any compatibility issues by splitting that dual div into 2 separate ones. Just include 2
more template html files, so we can add text messages and the like either immediately above, or
inside the shadowed content area.

Please let me know if you will seriously concider this change.
Hope I have that last closing div in the right place <g>.

Thank you,
Chris

Oh, you might also concider includes at the top and bottom of the areas in example.
i.e. a start and end that would allow content to be added below the areas mentioned.
RGB World, Inc. - Software &amp; Web Development.
rgbworld.com

Last edited by:

rgbworld: Apr 8, 2006, 12:28 AM
Apr 8, 2006, 1:48 AM
brewt
Staff (4101 posts)
brewt's avatar
Apr 8, 2006, 1:48 AM
Post #2 of 8
Views: 3131
Shortcut
Quote Reply
Re: [rgbworld] Luna template change request In reply to
Unfortunately, there's a million places where people might want to add extra things and it would just end up being a ton of different includes. We originally wanted to have template templates, where each base template would be just a bunch of includes - making it extremely easy for experienced users for adding something to every template, but it would have made it hell for new users to comprehend.

Adrian
Apr 9, 2006, 1:56 AM
rgbworld
User (325 posts)
rgbworld's avatar
Apr 9, 2006, 1:56 AM
Post #3 of 8
Views: 3105
Shortcut
Quote Reply
Re: [brewt] Luna template change request In reply to
In Reply To:
Unfortunately, there's a million places where people might want to add extra things and it would just end up being a ton of different includes.[/quote]
I understand that, but I only suggested 2 places. <g>

The 2 includes that were suggested are in the most common place for people to want to include custom content.
Like how about actually in the content area?

FYI, I am not a big fan of the shadowed borders, an I eliminate them via css.
The fact that there are 2 styles in 1 div tag, makes it impossible to add anything
between the 2 without separating them. 'Between' being inside the wrapper, yet outside the shadows.

I can explain further...
Errors are by default (luna) displayed in 'include_contentheader.html'.
When used in a 3 column setup, and an error appears, the entire content area is shifted down.
This includes the left and right columns, so there is a blank area above the left/right columns
to the left and right of the error message. I prefer the top of the left and right columns to remain
stationary, and the error to shift the content only (usually a form with missing data) down.

So, I moved the error display from 'include_contentheader.html'. to 'include_header.html'
Errors now display between the logo and login of the header. This does not then shift the
content down. I would prefer to put the error messages in the wrapper (within shadows or above),
but I do not want to have to override every template. So I am comprimising (again).

This also holds true for banner ads that I want to display... they either need to end up
immediately above the shadowed content area, or within the content area, but there is
no easy way to acomplish this.

I would like to at least get other users opinions on the matter, and if enough people
agree, the 2 includes should be added to the default luna templates. IMHO.

Can we take a poll?

Thanks,
Chris

RGB World, Inc. - Software &amp; Web Development.
rgbworld.com
Apr 9, 2006, 4:25 PM
aus_dave
User (276 posts)
Apr 9, 2006, 4:25 PM
Post #4 of 8
Views: 3087
Shortcut
Quote Reply
Re: [rgbworld] Luna template change request In reply to
In Reply To:
Errors are by default (luna) displayed in 'include_contentheader.html'. When used in a 3 column setup, and an error appears, the entire content area is shifted down. This includes the left and right columns, so there is a blank area above the left/right columns to the left and right of the error message.
I have a 2-column layout and I agree the placement of the error messages does pose some problems with shifting the left sidebar content down. I have tried to work around this with floats etc. in CSS but can't seem to get it right.

I haven't done anything about it yet but I would like to shift the error message inside the content div at some stage. It is not a simple job though as the error messages are displayed in quite a few templates, and some testing is required to make sure it all works properly.
Apr 9, 2006, 10:55 PM
rgbworld
User (325 posts)
rgbworld's avatar
Apr 9, 2006, 10:55 PM
Post #5 of 8
Views: 3091
Shortcut
Quote Reply
Re: [aus_dave] Luna template change request In reply to
I have attached some screen-shots showing what's possible if GT will
agree to add at least the <%include include_contentwrapper.html%>

In addition to the placement of errors and messages, it is the perfect
place to add a banner script without having to screw with the entire layout.

Brewt, I have PM'd you with login info to my dev site.
Hopefully you can login there and take a look at it.

I think if you do, you will agree to make the requested change.
Hopefully you will add both includes. I could show more examples of why.

As more and more people migrate to 3.x templates, it will become a bigger issue.
I have only used the luna templates, and these 2 includes have always seemed to be missing.

Thanks for your time.

Chris
RGB World, Inc. - Software &amp; Web Development.
rgbworld.com

Attached Files:

Apr 11, 2006, 7:50 PM
rgbworld
User (325 posts)
rgbworld's avatar
Apr 11, 2006, 7:50 PM
Post #6 of 8
Views: 3065
Shortcut
Quote Reply
Re: [rgbworld] Luna template change request In reply to
I am going to stick with my opinion that the 2 'includes' that I requested
should absolutely be added to the core luna template set.

I have updated the entire luna template set on a dev install, and have
once again attached a screen shot. These 2 pictures differ from the previous
post wrt to errors and messages. The errors and messages are now displayed
in the 'content' via my new 'include_content.html', and banner ads are
displayed via the new 'include_contentwrapper.html'.

Errors/messages in prev post screen shots had to share the same space with the
banners, so it was one or the other if adding only the 'include_contentwrapper.html'.
By adding both includes, they now both have a home. Check it out!

Error display is of course removed from 'include_contentheader.html'.

So, I have added the 2 includes, and if GT would like to take a look,
I can provide login info to the dev site. I can also provide the entire
template set if needed, but it basically has the exact 2 edits's I orig requested.
I spent a lot of time to show GT the mod implimented on a default install.
It would be great if someone would at least have-a-look-see. <g>

It looks very professional. It integrates a place for banner ads.
It keeps content from shifting around on errors/messages.
It will work in 2 or 3 column mode. It is backward compatible.
It is all-around a great improvement.

I am going to use my modified template set from here on out.
I think I will call it 'luna_plus' as it doesnt really change anything
other than adding the 2 includes and cleaning up messages.

I think it will be a pain in my butt to maintain updates to the set though.

Thanks again,
Chris
RGB World, Inc. - Software &amp; Web Development.
rgbworld.com

Attached Files:

Apr 15, 2006, 1:32 PM
rgbworld
User (325 posts)
rgbworld's avatar
Apr 15, 2006, 1:32 PM
Post #7 of 8
Views: 3051
Shortcut
Quote Reply
Re: [rgbworld] Luna template change request In reply to
I am trying to make the mod I requested to the luna template set,
and I have 1 problem. I have spent hours and hours trying to figure it out.
All I have done is split <div id="contentwrapper" class="shadowleft">
into 2 separate divs and added an additional close div to balance tags.
No css changes or any other mods.

Code:
<%include include_leftsidebar.html%>
<div id="contentwrapper">
<div class="shadowleft">
<div class="shadowtop"><div class="shadowtopleft"></div><div class="shadowtopright"></div></div>
<div class="shadowright">
<div id="content">

...

</div>
</div>
<div class="shadowbottom"><div class="shadowbottomleft"></div><div class="shadowbottomright"></div></div>
</div>
</div>
<%include include_rightsidebar.html%>

The problem I have is only with IE Windows.
The right shadow initially appears, but when I mouse-over the navbar,
the right shadow completely disappears and only re-appears on refresh.

Brewt?
Do I have to edit the css in order for splitting the contentwrapper div into 2 divs to work?

Thank you,
Chris
RGB World, Inc. - Software &amp; Web Development.
rgbworld.com
Apr 20, 2006, 3:00 PM
rgbworld
User (325 posts)
rgbworld's avatar
Apr 20, 2006, 3:00 PM
Post #8 of 8
Views: 3033
Shortcut
Quote Reply
Re: [rgbworld] Luna template change request In reply to
Hope it is acceptable to reply to my own questions :-)

In Reply To:
The problem I have is only with IE Windows.
The right shadow initially appears, but when I mouse-over the navbar,
the right shadow completely disappears and only re-appears on refresh.

Do I have to edit the css in order for splitting the contentwrapper div into 2 divs to work?
[/quote]
Fixed...

Code:
.shadowright {
position: relative;
}

From the web...
Quote:
To remedy the problem, simply insert position: relative into the CSS command for the disappearing element, and for some bizarre reason that'll usually fix the problem. If this doesn't work (it sometimes doesn't), assign a width to the offending element in the CSS and that should fix the problem.



Works perfectly.

Chris
RGB World, Inc. - Software &amp; Web Development.
rgbworld.com