Gossamer Forum
Home : Products : Others : Gossamer Community :

dynamic_preserve still not implemented

Quote Reply
dynamic_preserve still not implemented
I have 2 problems, both related to URL parameter preserving:

  1. The dynamic_preserve option is still not implemented into GCommunity. FrownFrownFrown
    Without this, the plugin development is really difficulter, since the developer has to develop URL parameter preserving, which may cause to replace many features. That makes the situation similar when we create mods: plugin result will be not upgrade-safe.

    Currently the URL parameter preserve is solved by this template condition way:
    <%if t%>;t=<%t%><%endif%>
    That's really poor and inefficient Frown


  2. I saw code parts for URL parameter preserving in GT::SQL::Admin, but I did not see any implementation of it in GCommunity.

  3. Also there is a "bug" in GT::SQL::Admin module (stores the params in unordered hash), which results, that all GT applications (including LinksSQL) doesn't keep the order of URL parameters, however sometime there would be useful to have the parameters in same order:

    Code:
    # Get the variables that need to be preserved and generate urls for them.
    my $preserve_hash = $self->preserve();
    my $preserve = '';
    foreach my $p (keys %$preserve_hash) {
    $preserve .= qq|&$p=$preserve_hash->{$p}|;
    }

Alex, I hope you will consider fixing these problems.

Thanks in advance,

Best regards,
Webmaster33


Paid Support
from Webmaster33. Expert in Perl programming & Gossamer Threads applications. (click here for prices)
Webmaster33's products (upd.2004.09.26) | Private message | Contact me | Was my post helpful? Donate my help...
Quote Reply
Re: [webmaster33] dynamic_preserve still not implemented In reply to
Hi,

We'll look at implementing number 1. As for number 2, while it may be nice to have them an order, this is pretty low priority.

Cheers,

Alex
--
Gossamer Threads Inc.
Quote Reply
Re: [Alex] dynamic_preserve still not implemented In reply to
1) dynamic_preserve:
Thanks for considering to implement it.

2) preserve URL param order:
Well, yes, I aggree it is a low priority feature, however note, that would not very difficult to implement it (at least info GT::SQL::Admin::preserve() function).

Let me see, how the URL param preserving is solved currently.
In LinksSQL:
On admin side I think GT::SQL::Admin::preserve() is used.
On user side if I remember correctly, in LinksSQL you used Links::clean_output() function to reparse ouput page & add preserved URL params to all links. That's unnecessary action & waste of CPU power. That could be solved the similarly how it's done on admin side, using the preserve() function when building an URL.

In GT Community:
Currently implemented through templates. This will change if dynamic_preserve will be implemented

Other GT apps:
I don't really know them in details, so I don't know if they have (or they need to have at all) URL preservation.


All in all, IMHO implementing the URL preserving through a fine API, may save GT from later URL problems. GT::SQL::Admin::preserve() seems to be a good starting point.
Also if preserve() would be implemented into LinksSQL, it would also save some CPU power for LinksSQL sites.

Best regards,
Webmaster33


Paid Support
from Webmaster33. Expert in Perl programming & Gossamer Threads applications. (click here for prices)
Webmaster33's products (upd.2004.09.26) | Private message | Contact me | Was my post helpful? Donate my help...