Gossamer Forum
Home : Products : Gossamer Links : Development, Plugins and Globals :

MyLinks SQL

(Page 6 of 8)
> > > >
Quote Reply
Re: [klauslovgreen] MyLinks SQL In reply to
This is a bug =( ....it's in the my_custom subroutine too.

You need to switch $IN->param and the custom user option, so for example:

Code:
my $ord = $USER->{SortField} || $IN->param('sf') || $opts->{'Sort Field'} || 'ID';
my $way = $USER->{SortOrd} || $IN->param('so') || $opts->{'Sort Order'} || 'ASC';

...would become:

Code:
my $ord = $IN->param('sf') || $USER->{SortField} || $opts->{'Sort Field'} || 'ID';
my $way = $IN->param('so') || $USER->{SortOrd} || $opts->{'Sort Order'} || 'ASC';
Quote Reply
Re: [klauslovgreen] MyLinks SQL In reply to
You need:

onclick="return the_warning('<%escape_js Title%>');"

..was that my fault again or had you changed the javascript?
Quote Reply
Re: [Paul] MyLinks SQL In reply to
No it was not even in the latest template set - only the javascript at the top - but never called in the my_links.html

Works now after adding the return

Cheers
Klaus

http://www.ameinfo.com
Quote Reply
Re: [Paul] MyLinks SQL In reply to
Thanks Paul - I assume you will update the plugin with the latest bug fixes so I can just download it again after the week-end?

Klaus

http://www.ameinfo.com
Quote Reply
Re: [klauslovgreen] MyLinks SQL In reply to
It has been updated =)
Quote Reply
Re: [Paul] MyLinks SQL In reply to
I also would like to display the comment on the user's list of saved links - I assume that this is how most people will use it rather than having to click to read the comment?

I would like to turn it into more of a personal review of the site - I might make it publicly viewable - not sure about this. I have changed it so that the comment can be entered into a text box but I want to stop html being added and would like to convert line breaks to <br> tags.

Obviously I can do this myself but if everyone uses it in the same way it would be easier if it was added to the plugin?
Quote Reply
Re: [afinlr] MyLinks SQL In reply to
Quote:
I also would like to display the comment on the user's list of saved links

You can just insert <%my_comment%> into my_public_link.html or my_link.html instead of using the popup.

If people want html removing etc, please let me know.
Quote Reply
Re: [Paul] MyLinks SQL In reply to
Paul,

The problem with the comment thing was that on the my_comment.html template you wrote call the input field "comment" - is that not suppose to be my_comment?

Cheers
Klaus

http://www.ameinfo.com
Quote Reply
Re: [klauslovgreen] MyLinks SQL In reply to
No, the comment field is just used for that form and then gets inserted into the database. The column name is my_comment wihch is what is sent to the template as a tag.
Quote Reply
Re: [Paul] MyLinks SQL In reply to
Ok well it works fine now (using "comment" as input) - but perhaps that was the reason <%comment%> worked - sometimes..

Thanks Paul

Klaus

http://www.ameinfo.com
Quote Reply
Re: [Paul] MyLinks SQL In reply to
Paul:

>>> If people want html removing etc, please let me know.

Yes, I think this would be good.
dave

Big Cartoon DataBase
Big Comic Book DataBase
Quote Reply
Re: [carfac] MyLinks SQL In reply to
I agree, this would be very usefull.

~ ERASER


Free JavaScripts @ Insight Eye
Quote Reply
Bug or feature? In reply to
I noticed that if I add a link to the default folder and then moce the link to another folder then I can add the same link again to the default folder and move it one more time to the other folder..

Should MyLinks2 not check if a link is avaiable in any folder the user has?

Cheers
Klaus

http://www.ameinfo.com
Quote Reply
Re: [klauslovgreen] MyLinks SQL In reply to
Hi Paul,

Teh sort issue (where the dropdown can't remember the current staus) is also a problem on the users list...

Klaus

http://www.ameinfo.com
Quote Reply
Re: [klauslovgreen] Bug or feature? In reply to
Regarding the sorting...when did you last install an update?...I just checked the lastest copy and the fix is present...

Code:
my $ord = $IN->param('sf') || $opts->{'User Sort Field'} || 'Username';
my $way = $IN->param('so') || $opts->{'User Sort Order'} || 'ASC';


Quote:
I noticed that if I add a link to the default folder and then moce the link to another folder then I can add the same link again to the default folder and move it one more time to the other folder..

Hmm this is an "overlook" on my part. It will throw an error if you try to add the same link to the same folder twice. You can fix this in sub my_link_add by changing:

Code:
# Make sure the link doesn't exist in this folder.
if ($DB->table('MyLinks2')->count({ my_user_username_fk => $USER->{Username}, my_folder_id_fk => $fid, my_link_id_fk => $lid })) {

to...

Code:
# Make sure the link doesn't exist.
if ($DB->table('MyLinks2')->count({ my_user_username_fk => $USER->{Username}, my_link_id_fk => $lid })) {

...then it will make sure the link doesn't exist anywhere rather than just in the current folder.

Last edited by:

Paul: Apr 6, 2003, 1:26 AM
Quote Reply
Re: [Paul] Bug or feature? In reply to
I updated today - few hours ago?

Have you added the check of links in any folder to the current version available from admin?

Klaus

http://www.ameinfo.com
Quote Reply
Re: [klauslovgreen] Bug or feature? In reply to
Yeah it's updated now.

I've just checked the sorting on the user page and the select list selects the correct field when playing with the sort order.
Quote Reply
Re: [Paul] Bug or feature? In reply to
Cheers Paul

http://www.ameinfo.com
Quote Reply
Re: [Paul] Bug or feature? In reply to
Hi Paul,

How can I disable the URL check when using the recommend feature?

Many of my entries does not have a URL
Klaus

http://www.ameinfo.com
Quote Reply
Re: [klauslovgreen] Bug or feature? In reply to
Hmm, I'll add a plugin option to let you turn it on/off. I just have to get some breakfast and I'll update the plugin.
Quote Reply
Re: [Paul] Bug or feature? In reply to
Perfect - I'm sure other will appreciate this too :-)

Klaus

http://www.ameinfo.com
Quote Reply
Folder order In reply to
Hi Paul,

How are the folders sorted? - they do not seem to be affected by the Profile settings?

Klaus

http://www.ameinfo.com
Quote Reply
Re: [klauslovgreen] Folder order In reply to
Folders aren't sorted (but they are now Wink)

I've added sorting options for the public/private folder lists as well as in the plugin options page in the admin panel. I've added a plugin option for turning URL checking on and off and I'm just about to deal with the html issue.
Quote Reply
Re: [Paul] Folder order In reply to
so I would have to replace my templates? Frown

Or could you advise the changes by any chance...

Is it ready for download now?

Klaus

http://www.ameinfo.com
Quote Reply
Re: [klauslovgreen] Folder order In reply to
No it's not ready yet.

I think what I'm going to do regarding the html is just change < to &lt; otherwise I'd have to add error checking for every field.

Yes there would be template changes. As long as you've edited your templates using the template editor then you'll have a custom copy in the "local" directory and so when you install, the new ones will go in the main template directory and then you can cut/paste the changes.

The changes are in:

my_home.html
my_public_home.html
my_users.html

I think that's all Crazy

Last edited by:

Paul: Apr 6, 2003, 6:43 AM
> > > >