Gossamer Forum
(Advanced Search)
for
Home : Products : Gossamer Links : Development, Plugins and Globals :

Bug in authentication routines?

Oct 14, 2004, 12:25 PM
Andy
Veteran / Moderator (18436 posts)
Andy's avatar
Oct 14, 2004, 12:25 PM
Post #1 of 5
Views: 2235
Shortcut
Quote Reply
Bug in authentication routines?
Hi guys. Think I've found a bug in Links/Authenticate.pm (line 177). It currently looks like;

Code:
my $session_cookie = $IN->cookie ( -name => 's', -value => $session_id, -path => '/' );

... but should it be something like;

Code:
my $session_cookie = $IN->cookie ( -name => 's', -value => $session_id, -path => '/', -expires => '+2y' );

I've tried this change on a dev site, and it seems to take effect.

Is this a bug, or a "feature"? (if its a feature, shouldn't there be an admin option, which enters a value for -expires?). I'm almost definate that this worked on 2.1.2 =)

Anyway, I'm off for the night now. Just thought I would post something, so that people can see the problem Smile).

Night

Andy (mod)
andy@ultranerds.co.uk
Want to give me something back for my help? Please see my Amazon Wish List
GLinks ULTRA Package | GLinks ULTRA Package PRO
Links SQL Plugins | Website Design and SEO | UltraNerds | ULTRAGLobals Plugin | Pre-Made Template Sets | FREE GLinks Plugins!
Oct 14, 2004, 3:26 PM
brewt
Staff (4101 posts)
brewt's avatar
Oct 14, 2004, 3:26 PM
Post #2 of 5
Views: 2133
Shortcut
Quote Reply
Re: [Andy] Bug in authentication routines? In reply to
It looks like Links SQL is weird and doesn't worry about the cookies on the user side. It only cares that the session exists in the session table.

Adrian
Oct 15, 2004, 12:32 AM
Andy
Veteran / Moderator (18436 posts)
Andy's avatar
Oct 15, 2004, 12:32 AM
Post #3 of 5
Views: 2145
Shortcut
Quote Reply
Re: [brewt] Bug in authentication routines? In reply to
Thanks for the reply. So should it be working like this as default?

Cheers

Andy (mod)
andy@ultranerds.co.uk
Want to give me something back for my help? Please see my Amazon Wish List
GLinks ULTRA Package | GLinks ULTRA Package PRO
Links SQL Plugins | Website Design and SEO | UltraNerds | ULTRAGLobals Plugin | Pre-Made Template Sets | FREE GLinks Plugins!
Oct 15, 2004, 1:24 AM
brewt
Staff (4101 posts)
brewt's avatar
Oct 15, 2004, 1:24 AM
Post #4 of 5
Views: 2107
Shortcut
Quote Reply
Re: [Andy] Bug in authentication routines? In reply to
Yup.

Adrian
Oct 15, 2004, 3:05 AM
Andy
Veteran / Moderator (18436 posts)
Andy's avatar
Oct 15, 2004, 3:05 AM
Post #5 of 5
Views: 2123
Shortcut
Quote Reply
Re: [brewt] Bug in authentication routines? In reply to
Ah, no worries then. I've updated it on the site where we were having the problem, so it works ok for them (when someone opens + closes their browser).

I guess its just handy to have posted this though, in case anyone else want's / need's to update their install Smile

Cheers

Andy (mod)
andy@ultranerds.co.uk
Want to give me something back for my help? Please see my Amazon Wish List
GLinks ULTRA Package | GLinks ULTRA Package PRO
Links SQL Plugins | Website Design and SEO | UltraNerds | ULTRAGLobals Plugin | Pre-Made Template Sets | FREE GLinks Plugins!