Gossamer Forum
Home : Products : Gossamer Links : Development, Plugins and Globals :

Re: [webmaster33] bug in dir Converter

Quote Reply
Re: [webmaster33] bug in dir Converter In reply to
Quote:
It is needed in my development process. Otherwise when checking for syntax with -c option I will get error.

It is not needed, you should use something like the following:

perl -c -I/path/to/admin/directory

Quote:
Data::Dumper is used for debugging in development phase. I don't care about GT::Dumper (which module is not standard in Perl, but Data::Dumpler is).

You are missing the point. GT::Dumper isn't a standard perl module, but it will be installed on EVERY copy of Links SQL using your plugin and it is specific to Links SQL making it a more suitable choice.

Quote:
You are right, that they could be declared in one step.
But usage of 13 "my" declarations does simply not matter in fact of the speed.

Yes it does.

Quote:
The optimization you suggest is unnecessary, since in the full execution time these 13 "my"-s are executed in less than 1%. Optimization is unnecessary for such small speed gain.

Not only should speed optimizations be used when necessary (and where you even admit you could improve it) but also aesthetically and syntactically it would lead to an improvement.

Quote:
This does not mean any problems...
It's my programming style, and I like using not instead of ! for easier readibility.

There is a difference in precedence between "not" and "!" - it's not a question of programmingstyle. I suggest you read the perldocs.

Quote:
Not incorrect. Both gives the same result, when comparing 2 integers

Again read the perldocs. It is incorrect usage, any perl programmer will confirm that.

Quote:
Same as above, with the addition, that there are NO number comparisions using 'eq'!!!
You meant this code part?: $IN->param("step1") eq "1" .... also in html sourse: <INPUT TYPE="CHECKBOX" NAME="step1" VALUE="1">
All input parameters you get from the form are strings, so you statement is simply not true.
So it causes NO problems.

See my answer above.

Quote:
Paul, Yogi: you should try out this small example

You example doesn't prove anything as you aren't even using any blocks Sly

Quote:
So your comment was NOT valid in CGI mode. Unfortunately under mod_perl the my() declaration usage on file level will not work if it's used under mod_perl. The mod_perl is the only reason to correct it, and avoid usage of my() declarations on file level.

Sorry, I'm afraid you are incorrect again. It has nothing to do with mod_perl.

Quote:
Go ahead Paul, do hundreds of tests on my plugin, discover all the possible problems it has, and tell me all the problems!

I didn't have to do hundreds of test...a quick scan through the code was enough to spot several potential problems.

If you choose not to correct them then only yourself and the people using your plugins will lose out in the end...I am just trying to assist you :)

I do think though you need to view the perldocs, especially regarding the use of my(0 and globals and also eq/ne/!=/==

Last edited by:

Paul: Mar 13, 2003, 5:17 AM
Subject Author Views Date
Thread; hot thread bug in dir Converter ridesworld 11646 Mar 12, 2003, 8:07 AM
Post; hot thread Re: [ridesworld] bug in dir Converter
Andy 11277 Mar 12, 2003, 8:17 AM
Thread; hot thread Re: [ridesworld] bug in dir Converter
Paul 11312 Mar 12, 2003, 8:47 AM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 11177 Mar 13, 2003, 4:55 AM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 8402 Mar 13, 2003, 5:15 AM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 8408 Mar 13, 2003, 7:07 AM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 8414 Mar 13, 2003, 7:14 AM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 8314 Mar 13, 2003, 8:13 AM
Post; hot thread Re: [webmaster33] bug in dir Converter
klauslovgreen 8325 Mar 13, 2003, 8:40 AM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 8382 Mar 13, 2003, 9:03 AM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 8882 Mar 13, 2003, 9:29 AM
Post; hot thread Re: [webmaster33] bug in dir Converter
Paul 8317 Mar 13, 2003, 9:32 AM
Thread; hot thread Re: [ridesworld] bug in dir Converter
webmaster33 11326 Mar 12, 2003, 10:12 AM
Thread; hot thread Re: [webmaster33] bug in dir Converter
ridesworld 11300 Mar 12, 2003, 12:29 PM
Thread; hot thread Re: [ridesworld] bug in dir Converter
Paul 11407 Mar 12, 2003, 12:48 PM
Post; hot thread Re: [Paul] bug in dir Converter
webmaster33 11221 Mar 12, 2003, 1:08 PM
Thread; hot thread Re: [ridesworld] bug in dir Converter
webmaster33 11302 Mar 12, 2003, 1:11 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
yogi 11327 Mar 12, 2003, 1:19 PM
Thread; hot thread Re: [yogi] bug in dir Converter
Paul 11268 Mar 12, 2003, 1:26 PM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 11252 Mar 12, 2003, 1:54 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 11237 Mar 12, 2003, 2:10 PM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 11303 Mar 12, 2003, 2:22 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 11254 Mar 12, 2003, 2:27 PM
Post; hot thread Re: [Paul] bug in dir Converter
webmaster33 11184 Mar 12, 2003, 2:37 PM
Thread; hot thread Re: [yogi] bug in dir Converter
webmaster33 11244 Mar 12, 2003, 2:47 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
yogi 11252 Mar 12, 2003, 2:51 PM
Thread; hot thread Re: [yogi] bug in dir Converter
webmaster33 11257 Mar 12, 2003, 2:57 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 11259 Mar 12, 2003, 3:19 PM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 11239 Mar 12, 2003, 4:43 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
ridesworld 11349 Mar 13, 2003, 2:33 AM
Thread; hot thread Re: [ridesworld] bug in dir Converter
Paul 11220 Mar 13, 2003, 3:21 AM
Post; hot thread Re: [Paul] bug in dir Converter
webmaster33 11162 Mar 13, 2003, 3:35 AM
Post; hot thread Re: [ridesworld] bug in dir Converter
webmaster33 11134 Mar 13, 2003, 3:36 AM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 8373 Mar 13, 2003, 5:31 AM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 8382 Mar 13, 2003, 7:02 AM
Post; hot thread Re: [webmaster33] bug in dir Converter
Paul 8356 Mar 13, 2003, 7:07 AM
Thread; hot thread Re: [ridesworld] bug in dir Converter
webmaster33 8348 Mar 29, 2003, 10:00 AM
Thread; hot thread Re: [webmaster33] bug in dir Converter
cwi 8273 Mar 29, 2003, 10:07 AM
Thread; hot thread Re: [cwi] bug in dir Converter
webmaster33 8290 Mar 29, 2003, 10:15 AM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 8303 Mar 29, 2003, 11:20 AM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 8285 Mar 29, 2003, 12:13 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 8320 Mar 29, 2003, 12:37 PM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 8318 Mar 29, 2003, 1:09 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 8309 Mar 29, 2003, 1:15 PM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 8310 Mar 29, 2003, 1:20 PM
Post; hot thread Re: [webmaster33] bug in dir Converter
Paul 8226 Mar 29, 2003, 1:21 PM