Gossamer Forum
Home : Products : Gossamer Links : Development, Plugins and Globals :

Re: [ridesworld] bug in dir Converter

Quote Reply
Re: [ridesworld] bug in dir Converter In reply to
Ok, sorry I noticed some potential problems that I feel need pointing out. Here goes:

1) "use lib" is used in the perl module but it isn't needed.

2) Data::Dumper debugging code is left in the code. That's not a major issue but it is loading a module that isn't needed. The reason for pointing this out too is that GT::Dumper is a better option for compatiblity sake (yes I know DAta::Dumper is standard but still).

3) Excessive use of "my" at the top. my() is actually a sub-routine so there about 13 sub-routine calls when this could be reduced to one or two by declaring more than one variable at once.

4) "not" used where "!" would be more appropriate.

5) Unnecessary escaping of single quotes inside qq||

6) Incorrect use of "ne" when comparing numerics. Should use "!="

7) Incorrect use of eq when comparing numerics. Should use "=="

8) Unnecessary use of parenthesis in regexes when no capturing is needed (this affects speed).

9) Escpaing of forward slashes in regexes could be avoided by changing the substitution delimiter.

10) Use of my() outside a sub-routine (thanks Yogi).

That's it for now - there may be other things I've missed. I think the plugin would fail under mod_perl.

This is intended as constructive criticizm.

Last edited by:

Paul: Mar 12, 2003, 8:51 AM
Subject Author Views Date
Thread; hot thread bug in dir Converter ridesworld 12300 Mar 12, 2003, 8:07 AM
Post; hot thread Re: [ridesworld] bug in dir Converter
Andy 11920 Mar 12, 2003, 8:17 AM
Thread; hot thread Re: [ridesworld] bug in dir Converter
Paul 11958 Mar 12, 2003, 8:47 AM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 11821 Mar 13, 2003, 4:55 AM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 8880 Mar 13, 2003, 5:15 AM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 8886 Mar 13, 2003, 7:07 AM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 8894 Mar 13, 2003, 7:14 AM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 8793 Mar 13, 2003, 8:13 AM
Post; hot thread Re: [webmaster33] bug in dir Converter
klauslovgreen 8801 Mar 13, 2003, 8:40 AM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 8859 Mar 13, 2003, 9:03 AM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 9359 Mar 13, 2003, 9:29 AM
Post; hot thread Re: [webmaster33] bug in dir Converter
Paul 8794 Mar 13, 2003, 9:32 AM
Thread; hot thread Re: [ridesworld] bug in dir Converter
webmaster33 11972 Mar 12, 2003, 10:12 AM
Thread; hot thread Re: [webmaster33] bug in dir Converter
ridesworld 11946 Mar 12, 2003, 12:29 PM
Thread; hot thread Re: [ridesworld] bug in dir Converter
Paul 12052 Mar 12, 2003, 12:48 PM
Post; hot thread Re: [Paul] bug in dir Converter
webmaster33 11869 Mar 12, 2003, 1:08 PM
Thread; hot thread Re: [ridesworld] bug in dir Converter
webmaster33 11948 Mar 12, 2003, 1:11 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
yogi 11975 Mar 12, 2003, 1:19 PM
Thread; hot thread Re: [yogi] bug in dir Converter
Paul 11915 Mar 12, 2003, 1:26 PM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 11895 Mar 12, 2003, 1:54 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 11882 Mar 12, 2003, 2:10 PM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 11948 Mar 12, 2003, 2:22 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 11899 Mar 12, 2003, 2:27 PM
Post; hot thread Re: [Paul] bug in dir Converter
webmaster33 11828 Mar 12, 2003, 2:37 PM
Thread; hot thread Re: [yogi] bug in dir Converter
webmaster33 11891 Mar 12, 2003, 2:47 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
yogi 11898 Mar 12, 2003, 2:51 PM
Thread; hot thread Re: [yogi] bug in dir Converter
webmaster33 11905 Mar 12, 2003, 2:57 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 11904 Mar 12, 2003, 3:19 PM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 11884 Mar 12, 2003, 4:43 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
ridesworld 11995 Mar 13, 2003, 2:33 AM
Thread; hot thread Re: [ridesworld] bug in dir Converter
Paul 11866 Mar 13, 2003, 3:21 AM
Post; hot thread Re: [Paul] bug in dir Converter
webmaster33 11805 Mar 13, 2003, 3:35 AM
Post; hot thread Re: [ridesworld] bug in dir Converter
webmaster33 11776 Mar 13, 2003, 3:36 AM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 8852 Mar 13, 2003, 5:31 AM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 8860 Mar 13, 2003, 7:02 AM
Post; hot thread Re: [webmaster33] bug in dir Converter
Paul 8845 Mar 13, 2003, 7:07 AM
Thread; hot thread Re: [ridesworld] bug in dir Converter
webmaster33 8828 Mar 29, 2003, 10:00 AM
Thread; hot thread Re: [webmaster33] bug in dir Converter
cwi 8751 Mar 29, 2003, 10:07 AM
Thread; hot thread Re: [cwi] bug in dir Converter
webmaster33 8768 Mar 29, 2003, 10:15 AM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 8781 Mar 29, 2003, 11:20 AM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 8762 Mar 29, 2003, 12:13 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 8798 Mar 29, 2003, 12:37 PM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 8795 Mar 29, 2003, 1:09 PM
Thread; hot thread Re: [webmaster33] bug in dir Converter
Paul 8790 Mar 29, 2003, 1:15 PM
Thread; hot thread Re: [Paul] bug in dir Converter
webmaster33 8788 Mar 29, 2003, 1:20 PM
Post; hot thread Re: [webmaster33] bug in dir Converter
Paul 8702 Mar 29, 2003, 1:21 PM