Gossamer Forum
Home : Products : Gossamer Forum : Discussion :

signature separater

Quote Reply
signature separater
hmmm ... seen this in action on another forum recently ... it was pretty nice.

how about adding a simple line above the signature ???

Could even get really fancy and offer this as a uer profile option ...

what you others think?

openoffice + gimp + sketch ... Smile
Quote Reply
Re: [QooQ] signature separater In reply to
good idea.

Maybe specify a character like * or - and the code automatically produces the line so all are the same length.

$sig_bar = '*' x 75;
Quote Reply
Re: [RedRum] signature separater In reply to
Or perhaps I could just add a template tag [line] which would add a <hr> tag and then people could put it in their own signatures as they like.

Jason Rhinelander
Gossamer Threads
jason@gossamer-threads.com
Quote Reply
Re: [jagerman] signature separater In reply to
Hmm do you think the hr under the subject line and another hr above the sig would look too cluttered?

It would be cool if we could change the hr properties like [line color="#FFFFFF" noshade]
Quote Reply
Re: [RedRum] signature separater In reply to
yep, yep, yep,

First I was gonna suggest just a simple
tag which could be used as the standard default option, but Paul is actually in tune with me on this one. It would be nice to go with a favorite character or even just being able to change the html properties of the line.

Smile

openoffice + gimp + sketch ... Smile
Quote Reply
Re: [RedRum] signature separater In reply to
Quote:
[line color="#FFFFFF" noshade]

As much as I hate to admit it, that's currently a little out of the scope for template tags. Tags like [url ...] ... [/url], [email]...[/email], are currently hard-coded. The custom markup extendibility comes when you want to add something simple - like [line] => <hr> or [:)] => <img whatever>. There _IS_, however, a plugin hook for converting markup, so something that allowed for custom [line] tags would be possible to do. It is doubtful that it will make it into the core of the code before the final (1.0.0) release, however if someone else doesn't experiment with making a plugin Wink then I suppose I could write one up.

Jason Rhinelander
Gossamer Threads
jason@gossamer-threads.com
Quote Reply
Re: [QooQ] signature separater In reply to
I posted this problem awhile back in this forum...Wink
========================================
Buh Bye!

Cheers,
Me
Quote Reply
Re: [jagerman] signature separater In reply to
CoolCool

I'll have a go but err..........
Quote Reply
Re: [AnthroRules] signature separater In reply to
Smile

seems like a lot of ideas are being repeated recently ... should've checked for your post.

openoffice + gimp + sketch ... Smile
Quote Reply
Re: [QooQ] signature separater In reply to
Hi:

I hate ressurecting this old thread, but I thought it better than starting a new one on the same subject...

Anyway, I do want to put a seperator between the message body and the appended sig... I have been all over the templetes, and it looks like the sig is added when the message is first saved. OK, so where is that? I just want to add a simple <HR> tag between the body and the <%user_signature%> tag.... I just cannot find were!



Thanks!
dave

Big Cartoon DataBase
Big Comic Book DataBase
Quote Reply
Re: [carfac] signature separater In reply to
You want to do this just for yourself (like mine), or for everyone, automatically?

Jason Rhinelander
Gossamer Threads
jason@gossamer-threads.com
Quote Reply
Re: [Jagerman] signature separater In reply to
Jagerman:

Thanks! I would like to make it automatic for everyone. If I could figure out the place that <%post_message%> is combined to <%user_signature%>, I would like to hard code it to be:

<%post_message%> . <P><HR><P> . <%user_signature%>
dave

Big Cartoon DataBase
Big Comic Book DataBase
Quote Reply
Re: [carfac] signature separater In reply to
In Reply To:
If I could figure out the place that <%post_message%> is combined to <%user_signature%>

If you check the "Append signature to post" checkbox, it adds '[signature]' to the end of your post. [signature] is not really anything special just a markup tag that gets replaced with your signature - you can put it in a post as an ordinary markup tag if you want:

So, as to where to change this, there is a plugin hook called 'convert_signature' in GForum::Convert which is responsible for the substitution. The change would be simple - instead of:

Code:
else {
$$sig
}
it'd be:
Code:
else {
'<p><hr><p>' . $$sig
}

In fact, seeing as this is a nice simple change, I think I'll add it, as a config option, to 1.2.0 Wink

Jason Rhinelander
Gossamer Threads
jason@gossamer-threads.com
Quote Reply
Re: [Jagerman] signature separater In reply to
Jagerman:

Thanks do much for letting me know where to look- I was in the templetes.... and from there to gforum.cgi, post.pm... I doubt I would have found this ever!

Thanks for adding it to 1.2... If I could make one MORE suggestion, if yu are going to do that anyway, you might want to add a variable "sig_seperate" or something.... so a user could do:

<BR><HR><B>

<P><HR><P>

<P>----------------------------------<P.

or whatever they liked! Wink

(Wow- now I am part of forum code... cool!)

Thanks!
dave

Big Cartoon DataBase
Big Comic Book DataBase
Quote Reply
Re: [carfac] signature separater In reply to
I added two configuration variables under Setup -> Markup: 'markup_signature_prefix' and 'markup_signature_suffix' - an admin can define them to be whatever they way (it defaults to nothing).

Jason Rhinelander
Gossamer Threads
jason@gossamer-threads.com
Quote Reply
Re: [carfac] signature separater In reply to
OK, slight problem....

the <HR> appears if someone does NOT have a signature, too. Can I do something like



else {

if $$sig {

'<br>
--------------------------<p>' . $$sig

}

else {

$$sig

}/egi

dave

Big Cartoon DataBase
Big Comic Book DataBase
Quote Reply
Re: [carfac] signature separater In reply to
Try these - Convert replaces admin/GForum/Convert.pm, and setup_markup.html replaces admin/templates/admin/setup_markup.html. Then just go to Setup -> Markup, and you'll have the two new options. I made it only add the prefix/suffix only if there actually is a signature that contains something other than spaces.

Jason Rhinelander
Gossamer Threads
jason@gossamer-threads.com
Quote Reply
Re: [Jagerman] signature separater In reply to
Jagerman:

Sorry for the extra work I caused you! But it works like acharm! thanks!
dave

Big Cartoon DataBase
Big Comic Book DataBase
Quote Reply
Re: [Jagerman] signature separater In reply to
Hi Jagerman,

When is 1.2.0 expected - and is there a list of changes/features somewhere?

Klaus

http://www.ameinfo.com
Quote Reply
Re: [Jagerman] signature separater In reply to
Hi Jason,

Is it possible to have the french version of Convert.pm with the signature feature?

Thank you! Smile

François
Quote Reply
Re: [Franco] signature separater In reply to
In Reply To:
Is it possible to have the french version of Convert.pm with the signature feature?

Hi François,

I've attached the french Convert.pm, but I don't yet have the french translations for the template - the attached template is the french translation, but the descriptions for the two options are still in english.

Jason Rhinelander
Gossamer Threads
jason@gossamer-threads.com
Quote Reply
Re: [Jagerman] signature separater In reply to
Thank you, Jason.

I get "Unknown Tag: 'cfg_markup_signature_prefix'" in the markup signature_prefix field and "Unknown Tag: 'cfg_markup_signature_suffix'" in markup_signature_suffix field. Unsure

Thank you,

François
Quote Reply
Re: [Franco] signature separater In reply to
Just add a couple lines at the top of GForum/Config/Data.pm, after the '{', containing:

'markup_signature_prefix' => '',
'markup_signature_suffix' => '',

That should fix it up and allow you to save.

Jason Rhinelander
Gossamer Threads
jason@gossamer-threads.com
Quote Reply
Re: [Jagerman] signature separater In reply to
Now I understand why I was not able to add myself the signature feature in french Convert.pm. Laugh

Thank you! Smile

Last edited by:

Franco: Apr 27, 2003, 4:45 PM
Quote Reply
Re: [Jagerman] signature separater In reply to
Jason:

I've substituted the files and added the markup "br" to my signature on our forum but there seems to be an extra space between the horizontal rule and the start of my signature. (was that the object here, I hope?)

It might be connected to a problem I once told you about. For some reason, carriage returns and blank spaces appear in the signature box of users profiles, even when they don't have a signature. It happens at random and makes for extra empty space at the bottom of posts. I'll go in to users profiles and delete the blanks in a signature but they seem to insert themselves randomly.

Ghost in the machine?

BTW, we should be moving the forum to the new server in the next week or two, but I don't see how this can be connected to our server problems.

Steve

Visit The Guitar Diner

Last edited by:

Boomer: Apr 27, 2003, 6:44 PM
Quote Reply
Re: [Boomer] signature separater In reply to
Hi Boomer, this is (unfortunately) because of the way <hr> tags work. Basically, if you use:

Code:
[hr]
Text

as your signature, that gets converted the this html:

Code:
<hr><br> Text

The <br> is there because you hit enter after the [hr]. You can, however, get around this fairly easily by not hitting enter after the [hr] tag. I do this for my signature here:

Code:
[hr]Jason Rhinelander
Gossamer Threads
[email]jason@gossamer-threads.com[/email]

Alternatively, you can edit the [hr] markup tag, and try checking the "Clear spaces" option, which should make it work a little more like you want.

Jason Rhinelander
Gossamer Threads
jason@gossamer-threads.com
Quote Reply
Re: [Jagerman] signature separater In reply to
In Reply To:
[/code]
The
is there because you hit enter after the [hr].
Well, duh ... that was pretty stupid of me ...

Steve

Visit The Guitar Diner

Last edited by:

Boomer: Apr 27, 2003, 7:06 PM
Quote Reply
Re: [Jagerman] signature separater In reply to
Hi Jason,

Since I use the new french Convert.pm file, all the links in my forum are now formated with redirections. They are not plain links as before, even when we are not logged.

Thank you.

François
Quote Reply
Re: [Jagerman] signature separater In reply to
Hi Jason,

I found how to reproduce the bug with Convert.pm: when the user select "Append signature to post" the links in the post work with redirections. If the user don't select "Append signature to post" the links don't use redirections (they are instead plain html links).

I noticed also that if the user modify his post and add his signature by selecting "Append signature to post" the links in his post will use after a double redirections like this: "http://www.gossamer-threads.com/perl/gforum/gforum.cgi?url=http://www.gossamer-threads.com/perl/gforum/gforum.cgi?url=http://www.USER-SITE.com" Unsure

Thank you.

François

Last edited by:

Franco: Apr 29, 2003, 4:34 AM
Quote Reply
Re: [Jagerman] signature separater In reply to
Hi Jason,

With the "bug" I mentioned in my previous post, our forum is loosing ranking position in search engines. It's a lot better for ranking position to have plain html links instead of cgi redirections. Is it possible to have a bug fix for this?

Thank you.

François
Quote Reply
Re: [Jagerman] signature separater In reply to
The signature separater doesn't work in privates messages.

François
Quote Reply
Re: [Jagerman] signature separater In reply to
Unsure May we have the french file Convert.pm without the bugs??

Thank you.
Quote Reply
Re: [Jagerman] signature separater In reply to
I'm still waiting for french Convert.pm. Unsure

Thank you.

François
Quote Reply
Re: [Jagerman] signature separater In reply to
The html code for the signature separater appears in the subscribe emails.

I'm still waiting for the Convert.pm french version without the bugs... What's going on guys? Unsure