Mailing List Archive: Zope: Dev

Zope trunk: browser views

Index | Next | Previous | View Threaded

y.2012 at wcm-solutions

Jul 10, 2012, 7:29 AM

Post #1 of 5 (247 views)
Permalink

Zope trunk: browser views

Hi!

Zope 2 has customized implementations of the ``browser:view`` and
``browser:page`` directives. I tried to make that code more similar to
zope.browserpage without breaking Zope 2 and CMF. I guess the biggest
change I made was removing the Five version of BrowserView from the base
classes.

Please let me know if you have any questions or if I did break something.

Cheers,

Yuppie
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

charlie.clark at clark-consulting

Jul 10, 2012, 7:56 AM

Post #2 of 5 (239 views)
Permalink

Re: Zope trunk: browser views [In reply to]

Am 10.07.2012, 16:29 Uhr, schrieb yuppie <y.2012 [at] wcm-solutions>:

> Hi!
> Zope 2 has customized implementations of the ``browser:view`` and
> ``browser:page`` directives. I tried to make that code more similar to
> zope.browserpage without breaking Zope 2 and CMF. I guess the biggest
> change I made was removing the Five version of BrowserView from the base
> classes.
> Please let me know if you have any questions or if I did break
> something.

Hi Yuppie,

I'm sure that's going to break any code that has

from Products.Five import BrowserView

in it. What should this be replaced by? And what changes in ZCML? Most of
my code sits upon CMF so I hope I should be reasonably insulated through
that.

But the change is probably a good thing™ so thanks in advance.

Charlie
--
Charlie Clark
Managing Director
Clark Consulting & Research
German Office
Kronenstr. 27a
Düsseldorf
D- 40217
Tel: +49-211-600-3657
Mobile: +49-178-782-6226
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

y.2012 at wcm-solutions

Jul 10, 2012, 8:10 AM

Post #3 of 5 (240 views)
Permalink

Re: Zope trunk: browser views [In reply to]

Charlie Clark wrote:
> Am 10.07.2012, 16:29 Uhr, schrieb yuppie <y.2012 [at] wcm-solutions>:
>> I guess the biggest
>> change I made was removing the Five version of BrowserView from the
>> base classes.
>> Please let me know if you have any questions or if I did break
>> something.
>
> I'm sure that's going to break any code that has
>
> from Products.Five import BrowserView
>
> in it. What should this be replaced by? And what changes in ZCML? Most
> of my code sits upon CMF so I hope I should be reasonably insulated
> through that.
>
> But the change is probably a good thing™ so thanks in advance.

What I wanted to say is that I removed that BrowserView from the classes
automatically added by ``browser:view`` and ``browser:page`` directives.
You still can import and use the Five version of BrowserView in classes
specified explicitly in ZCML.

Cheers, Yuppie
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

hanno at hannosch

Jul 10, 2012, 11:23 AM

Post #4 of 5 (236 views)
Permalink

Re: Zope trunk: browser views [In reply to]

On Tue, Jul 10, 2012 at 7:29 AM, yuppie <y.2012 [at] wcm-solutions> wrote:
> Zope 2 has customized implementations of the ``browser:view`` and
> ``browser:page`` directives. I tried to make that code more similar to
> zope.browserpage without breaking Zope 2 and CMF. I guess the biggest change
> I made was removing the Five version of BrowserView from the base classes.
>
> Please let me know if you have any questions or if I did break something.

Did you add a changelog entry? Maybe that could mention that the aq_*
attributes are no longer available on those views/pages (Five's
BrowserView's only purpose is to provide those for backwards
compatibility).

Hanno
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

y.2012 at wcm-solutions

Jul 11, 2012, 11:19 AM

Post #5 of 5 (231 views)
Permalink

Re: Zope trunk: browser views [In reply to]

Hanno Schlichting wrote:
> On Tue, Jul 10, 2012 at 7:29 AM, yuppie <y.2012 [at] wcm-solutions> wrote:
>> Zope 2 has customized implementations of the ``browser:view`` and
>> ``browser:page`` directives. I tried to make that code more similar to
>> zope.browserpage without breaking Zope 2 and CMF. I guess the biggest change
>> I made was removing the Five version of BrowserView from the base classes.
>>
>> Please let me know if you have any questions or if I did break something.
>
> Did you add a changelog entry? Maybe that could mention that the aq_*
> attributes are no longer available on those views/pages (Five's
> BrowserView's only purpose is to provide those for backwards
> compatibility).

Done.

Cheers, Yuppie
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads