Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Zope: Dev

Undeclared dependency of zope.site on zope.app.publication

 

 

Zope dev RSS feed   Index | Next | Previous | View Threaded


tl at gocept

Sep 22, 2009, 11:06 PM

Post #1 of 6 (753 views)
Permalink
Undeclared dependency of zope.site on zope.app.publication

I just noticed that zope.site depends on zope.app.publication, both via
configure.zcml and the tests. The dependency isn't currently declared.
On the other hand, zope.app.publication doesn't yet depend on zope.site.

I'd like to get rid of the dependency of zope.site on zope.app.publisher
and I think it would be OK to invert it by moving the relevant ZCML
declarations (two event handler registrations) and the two pieces of test
regarding traversal behaviour to zope.app.publisher, which would thereby
grow a new dependency on zope.site. What do others think?

--
Thomas



_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


mh at gocept

Sep 23, 2009, 12:52 AM

Post #2 of 6 (730 views)
Permalink
Re: Undeclared dependency of zope.site on zope.app.publication [In reply to]

Am 23.09.2009 um 08:06 schrieb Thomas Lotze:
> I just noticed that zope.site depends on zope.app.publication, both
> via
> configure.zcml and the tests. The dependency isn't currently declared.
> On the other hand, zope.app.publication doesn't yet depend on
> zope.site.
>
> I'd like to get rid of the dependency of zope.site on
> zope.app.publisher

Do you mean zope.app.publication here and in the following lines?

> and I think it would be OK to invert it by moving the relevant ZCML
> declarations (two event handler registrations) and the two pieces of
> test
> regarding traversal behaviour to zope.app.publisher, which would
> thereby
> grow a new dependency on zope.site. What do others think?

Yours sincerely,
--
Michael Howitz · mh [at] gocept · software developer
gocept gmbh & co. kg · forsterstraße 29 · 06112 halle (saale) · germany
http://gocept.com · tel +49 345 1229889 8 · fax +49 345 1229889 1
Zope and Plone consulting and development

_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


tl at gocept

Sep 23, 2009, 12:56 AM

Post #3 of 6 (728 views)
Permalink
Re: Undeclared dependency of zope.site on zope.app.publication [In reply to]

Michael Howitz wrote:

> Am 23.09.2009 um 08:06 schrieb Thomas Lotze:
>> I just noticed that zope.site depends on zope.app.publication, both via
>> configure.zcml and the tests. The dependency isn't currently declared.
>> On the other hand, zope.app.publication doesn't yet depend on zope.site.
>>
>> I'd like to get rid of the dependency of zope.site on zope.app.publisher
>
> Do you mean zope.app.publication here and in the following lines?

Yes, of course.

--
Thomas



_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


faassen at startifact

Sep 24, 2009, 7:48 AM

Post #4 of 6 (692 views)
Permalink
Re: Undeclared dependency of zope.site on zope.app.publication [In reply to]

Thomas Lotze wrote:
> I just noticed that zope.site depends on zope.app.publication, both via
> configure.zcml and the tests. The dependency isn't currently declared.
> On the other hand, zope.app.publication doesn't yet depend on zope.site.
>
> I'd like to get rid of the dependency of zope.site on zope.app.publisher
> and I think it would be OK to invert it by moving the relevant ZCML
> declarations (two event handler registrations) and the two pieces of test
> regarding traversal behaviour to zope.app.publisher, which would thereby
> grow a new dependency on zope.site. What do others think?

At first glance I'm +1 on doing this. We'll need analyze what we can do
with zope.app.publication too.

Regards,

Martijn

_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


tl at gocept

Sep 28, 2009, 11:24 PM

Post #5 of 6 (656 views)
Permalink
Re: Undeclared dependency of zope.site on zope.app.publication [In reply to]

Martijn Faassen wrote:

> Thomas Lotze wrote:
>> I just noticed that zope.site depends on zope.app.publication, both via
>> configure.zcml and the tests. The dependency isn't currently declared.
>> On the other hand, zope.app.publication doesn't yet depend on zope.site.
>>
>> I'd like to get rid of the dependency of zope.site on zope.app.publisher
>> and I think it would be OK to invert it by moving the relevant ZCML
>> declarations (two event handler registrations) and the two pieces of
>> test regarding traversal behaviour to zope.app.publisher, which would
>> thereby grow a new dependency on zope.site. What do others think?
>
> At first glance I'm +1 on doing this. We'll need analyze what we can do
> with zope.app.publication too.

I've just committed changes to the packages to remove any trace of
zope.app.publication from zope.site. The handlers in question are still
implemented by zope.site as they are not z.a.p specific, and conditionally
registered by z.a.p if zope.site is installed. This makes zope.site a
testing dependency of zope.app.publication.

Could someone with the appropriate privileges please grant me PyPI access
to the two packages so I can make releases? (Though releasing zope.site
might wait until another issue involving it has been resolved.)

--
Thomas



_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )


faassen at startifact

Sep 29, 2009, 4:11 AM

Post #6 of 6 (652 views)
Permalink
Re: Undeclared dependency of zope.site on zope.app.publication [In reply to]

Hey,

Thomas Lotze wrote:
[snip]
> Could someone with the appropriate privileges please grant me PyPI access
> to the two packages so I can make releases? (Though releasing zope.site
> might wait until another issue involving it has been resolved.)

I've given you access to both.

Regards,

Martijn


_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

Zope dev RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.