Mailing List Archive: Zope: Dev

zope.location.pickling.PathPersistent and BBB

Index | Next | Previous | View Threaded

thomas at thomas-lotze

Sep 9, 2009, 5:31 AM

Post #1 of 5 (811 views)
Permalink

zope.location.pickling.PathPersistent and BBB

While wondering about the ITraverser interface being defined by
zope.location, we noticed that the zope.location.pickling.PathPersistent
class (which is this package's only user of the interface) is decorated
with a recent BBB comment, and had been questioned by a XXX comment for
some time before that.

The class doesn't seem to be used anywhere in Zope, so removing it would
rid zope.location of some unused code as well as make it possible to move
ITraverser back to zope.traversing where it fits much better
conceptionally.

What are your opinions on this, does anyone object?

--
Thomas

_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

tl at gocept

Sep 16, 2009, 6:33 AM

Post #2 of 5 (730 views)
Permalink

Re: zope.location.pickling.PathPersistent and BBB [In reply to]

I asked about this before; let me do so again before assuming silence to
mean consent:

There's a PathPersistent class in zope.location.pickling which is
decorated with a recent BBB comment, and had been questioned by a XXX
comment for some time before that.

The class doesn't seem to be used anywhere in Zope, so removing it would
rid zope.location of some unused code. As PathPersistent is the only user
of the ITraverser interface within zope.location, removing it would also
make it possible to move ITraverser back to zope.traversing where it fits
much better conceptionally.

Does anyone object to these changes?

--
Thomas

_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

kobold at kobold

Sep 16, 2009, 6:46 AM

Post #3 of 5 (718 views)
Permalink

Re: zope.location.pickling.PathPersistent and BBB [In reply to]

Hello,

* 2009-09-16 15:34, Thomas Lotze wrote:
> There's a PathPersistent class in zope.location.pickling which is
> decorated with a recent BBB comment, and had been questioned by a XXX
> comment for some time before that.
>
> [snip]
>
> Does anyone object to these changes?

+1, I fully agree with the change.

Fabio
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

faassen at startifact

Sep 16, 2009, 2:44 PM

Post #4 of 5 (708 views)
Permalink

Re: zope.location.pickling.PathPersistent and BBB [In reply to]

Thomas Lotze wrote:
> I asked about this before; let me do so again before assuming silence to
> mean consent:
>
> There's a PathPersistent class in zope.location.pickling which is
> decorated with a recent BBB comment, and had been questioned by a XXX
> comment for some time before that.
>
> The class doesn't seem to be used anywhere in Zope, so removing it would
> rid zope.location of some unused code. As PathPersistent is the only user
> of the ITraverser interface within zope.location, removing it would also
> make it possible to move ITraverser back to zope.traversing where it fits
> much better conceptionally.
>
> Does anyone object to these changes?

Sounds like you did the research. I'm +1 on removing it.

Regards,

Martijn

_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

tl at gocept

Sep 17, 2009, 6:40 AM

Post #5 of 5 (711 views)
Permalink

Re: zope.location.pickling.PathPersistent and BBB [In reply to]

Martijn Faassen wrote:

> Sounds like you did the research.

I've considered all packages mentioned in the current ztk.cfg that come
from the zope.* namespace. The BBB stuff from zope.location.pickling is
neither used by any of them, nor do compat-tests involving the pinned
versions of those packages and the modified zope.location fail.

Come to think about it, I'm not sure whether and how far I should
investigate beyond the ztk for removals like this; are there zope.*
packages in the repository that should no longer be cared about at all?

> I'm +1 on removing it.

Done.

--
Thomas

_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads