Mailing List Archive: Zope: Dev

Re: SVN: Sandbox/nadako/zope.app.publisher/ Clean up dependencies.

Index | Next | Previous | View Threaded

tseaver at palladion

Aug 27, 2009, 11:10 AM

Post #1 of 10 (1102 views)
Permalink

Re: SVN: Sandbox/nadako/zope.app.publisher/ Clean up dependencies.

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Stephan Richter wrote:
> On Thursday 27 August 2009, Dan Korostelev wrote:
>> extras_require={
>> 'test': [.'zope.testing',
>> 'zope.app.testing',
>> 'zope.app.securitypolicy',
>> 'zope.app.zcmlfiles',
>> + 'zope.container>=3.8.3',
>> 'zope.site'],
>
> You can not require a minor version in setup.py.

Huh? setuptools doesn't care about how many dots are in the dependency.

Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tseaver [at] palladion
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFKlswi+gerLs4ltQ4RArxQAJ0e5m81OKm731uCeWClD8nUcSgDxwCghwcz
KZa18cxrUyXVpuVy17cbhVk=
=fZr2
-----END PGP SIGNATURE-----

_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

hanno at hannosch

Aug 27, 2009, 11:18 AM

Post #2 of 10 (1052 views)
Permalink

Re: SVN: Sandbox/nadako/zope.app.publisher/ Clean up dependencies. [In reply to]

On Thu, Aug 27, 2009 at 8:10 PM, Tres Seaver<tseaver [at] palladion> wrote:
> Stephan Richter wrote:
>> You can not require a minor version in setup.py.
>
> Huh? setuptools doesn't care about how many dots are in the dependency.

What Stefan probably meant here was: You *shouldn't* require minor
versions in setup.py. That was the consensus reached the last time we
fought about version requirements in setup.py.

In this case the requirement is correct, though. As zope.container
3.8.3 (as well as 3.8.2) introduced API incompatible changes. The
above policy of only requiring features releases would have worked if
both 3.8.2 and 3.8.3 would have been proper new feature releases.
Since they weren't the requirement is OK as is.

To make every policy happy, some new 3.9 release of zope.container and
some re-releasing of a no-API-changes 3.8.4 release would be required
- quite tedious and not worth it IMHO ;-)

Hanno
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

srichter at cosmos

Aug 27, 2009, 12:07 PM

Post #3 of 10 (1049 views)
Permalink

Re: SVN: Sandbox/nadako/zope.app.publisher/ Clean up dependencies. [In reply to]

On Thursday 27 August 2009, Hanno Schlichting wrote:
> To make every policy happy, some new 3.9 release of zope.container and
> some re-releasing of a no-API-changes 3.8.4 release would be required
> - quite tedious and not worth it IMHO ;-)

I disagree. Somebody did a mistake and should try to fix it. If we keep
slipping in minor versions in setup.py, we will eventually bring development
to a halt again.

Regards,
Stephan
--
Entrepreneur and Software Geek
Google me. "Zope Stephan Richter"
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

charlie.clark at clark-consulting

Aug 27, 2009, 12:19 PM

Post #4 of 10 (1050 views)
Permalink

Re: SVN: Sandbox/nadako/zope.app.publisher/ Clean up dependencies. [In reply to]

Am 27.08.2009, 21:07 Uhr, schrieb Stephan Richter
<srichter [at] cosmos>:

> I disagree. Somebody did a mistake and should try to fix it. If we keep
> slipping in minor versions in setup.py, we will eventually bring
> development
> to a halt again.

I wouldn't have chosen this as my first post but I agree. If you are going
to follow numbering conventions then stick with them and patch releases
should never change an API.

Now the formalities: hi, to all who know me! To others - I reckon I'm the
slowest runner on the Zope track, currently about three to six years
behind the curve but at some point I discovered there are others even
slower than me.

Charlie
--
Charlie Clark
Managing Director
Clark Consulting & Research Ltd.
German Office
Helmholtzstr. 20
Düsseldorf
D- 40215
Tel: +49-211-600-3657
GSM: +49-178-782-6226
Company No. 06770088
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

tseaver at palladion

Aug 27, 2009, 12:48 PM

Post #5 of 10 (1050 views)
Permalink

Re: SVN: Sandbox/nadako/zope.app.publisher/ Clean up dependencies. [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Stephan Richter wrote:
> On Thursday 27 August 2009, Tres Seaver wrote:
>> Stephan Richter wrote:
>>> On Thursday 27 August 2009, Dan Korostelev wrote:
>>>> extras_require={
>>>> 'test': [.'zope.testing',
>>>> 'zope.app.testing',
>>>> 'zope.app.securitypolicy',
>>>> 'zope.app.zcmlfiles',
>>>> + 'zope.container>=3.8.3',
>>>> 'zope.site'],
>>> You can not require a minor version in setup.py.
>> Huh? setuptools doesn't care about how many dots are in the dependency.
>
> This is not a technical but a process requirement that we discussed on the
> mailing list and was captured in the steering committee decision list.

OK: "can not" signalled something different to me. It happens that the
particular case here requires bending that rule, I think (3.8.2 just
won't work with the package).

Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tseaver [at] palladion
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFKluMA+gerLs4ltQ4RAkKxAJ40c6cXv4RYvr/JEGU2rpNscMR0PQCgn3SA
ZnzGase5cDZ73z+4qOZ3X1Y=
=trbt
-----END PGP SIGNATURE-----
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

nadako at gmail

Aug 27, 2009, 2:02 PM

Post #6 of 10 (1048 views)
Permalink

Re: SVN: Sandbox/nadako/zope.app.publisher/ Clean up dependencies. [In reply to]

2009/8/27 Stephan Richter <srichter [at] cosmos>:
> On Thursday 27 August 2009, Hanno Schlichting wrote:
>> To make every policy happy, some new 3.9 release of zope.container and
>> some re-releasing of a no-API-changes 3.8.4 release would be required
>> - quite tedious and not worth it IMHO ;-)
>
> I disagree. Somebody did a mistake and should try to fix it. If we keep
> slipping in minor versions in setup.py, we will eventually bring development
> to a halt again.

Well, I thinked about that, but it was hard to choose the right way.
zope.container 3.8.3 doesn't really have any API changes, the only
thing that was changed is that two zcml adapter registration was added
to configure.zcml (and those adapters were are already in
zope.container). No python changes, no dependency changes. Does it
really worth a new "feature release"? New zope.app.publisher needs
this adapter registration for its functional tests though, so it won't
work with older zope.container versions.

Should I release zope.container 3.9.0 and then zope.app.publisher
3.10.0 only because of that thing? (note that it's only a test
dependency requirement)

--
WBR, Dan Korostelev
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

srichter at cosmos

Aug 27, 2009, 2:11 PM

Post #7 of 10 (1042 views)
Permalink

Re: SVN: Sandbox/nadako/zope.app.publisher/ Clean up dependencies. [In reply to]

On Thursday 27 August 2009, Dan Korostelev wrote:
> Well, I thinked about that, but it was hard to choose the right way.
> zope.container 3.8.3 doesn't really have any API changes, the only
> thing that was changed is that two zcml adapter registration was added
> to configure.zcml (and those adapters were are already in
> zope.container). No python changes, no dependency changes. Does it
> really worth a new "feature release"? New zope.app.publisher needs
> this adapter registration for its functional tests though, so it won't
> work with older zope.container versions.

Yes, because people need to be aware that there are now 2 new adapter
registrations around, which might in fact interfere with their registrations.

> Should I release zope.container 3.9.0 and then zope.app.publisher
> 3.10.0 only because of that thing? (note that it's only a test
> dependency requirement)

Definitely create a zope.container 3.9.0 release. I forgot what we said about
changing dependencies, but I am pretty sure they also always require a major
update, so yes, 3.10.0 for zope.app.publisher.

Regards,
Stephan
--
Entrepreneur and Software Geek
Google me. "Zope Stephan Richter"
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

nadako at gmail

Aug 27, 2009, 2:33 PM

Post #8 of 10 (1048 views)
Permalink

Re: SVN: Sandbox/nadako/zope.app.publisher/ Clean up dependencies. [In reply to]

2009/8/28 Stephan Richter <srichter [at] cosmos>:
> On Thursday 27 August 2009, Dan Korostelev wrote:
>> Well, I thinked about that, but it was hard to choose the right way.
>> zope.container 3.8.3 doesn't really have any API changes, the only
>> thing that was changed is that two zcml adapter registration was added
>> to configure.zcml (and those adapters were are already in
>> zope.container). No python changes, no dependency changes. Does it
>> really worth a new "feature release"? New zope.app.publisher needs
>> this adapter registration for its functional tests though, so it won't
>> work with older zope.container versions.
>
> Yes, because people need to be aware that there are now 2 new adapter
> registrations around, which might in fact interfere with their registrations.
>
>> Should I release zope.container 3.9.0 and then zope.app.publisher
>> 3.10.0 only because of that thing? (note that it's only a test
>> dependency requirement)
>
> Definitely create a zope.container 3.9.0 release.

That's done.

> I forgot what we said about changing dependencies, but I am pretty sure
> they also always require a major update, so yes, 3.10.0 for zope.app.publisher.

Hmm, that change looks more like a bug fix to me (the dependencies
were wrong in the previous release of zope.app.publisher and now they
are fixed), so may be it should be 3.9.1 nevertheless?

--
WBR, Dan Korostelev
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

srichter at cosmos

Aug 28, 2009, 10:49 AM

Post #9 of 10 (1022 views)
Permalink

Re: SVN: Sandbox/nadako/zope.app.publisher/ Clean up dependencies. [In reply to]

On Thursday 27 August 2009, Dan Korostelev wrote:
> > I forgot what we said about changing dependencies, but I am pretty sure
> > they also always require a major update, so yes, 3.10.0 for
> > zope.app.publisher.
>
> Hmm, that change looks more like a bug fix to me (the dependencies
> were wrong in the previous release of zope.app.publisher and now they
> are fixed), so may be it should be 3.9.1 nevertheless?

I would make it 3.10.0, so that it is clear there was a mixup.

Regards,
Stephan
--
Entrepreneur and Software Geek
Google me. "Zope Stephan Richter"
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

faassen at startifact

Aug 31, 2009, 11:46 AM

Post #10 of 10 (961 views)
Permalink

Re: SVN: Sandbox/nadako/zope.app.publisher/ Clean up dependencies. [In reply to]

Hanno Schlichting wrote:
> On Thu, Aug 27, 2009 at 8:10 PM, Tres Seaver<tseaver [at] palladion> wrote:
>> Stephan Richter wrote:
>>> You can not require a minor version in setup.py.
>> Huh? setuptools doesn't care about how many dots are in the dependency.
>
> What Stefan probably meant here was: You *shouldn't* require minor
> versions in setup.py. That was the consensus reached the last time we
> fought about version requirements in setup.py.

It's official, documented ZTK steering group policy:

http://docs.zope.org/zopetoolkit/steeringgroup/decisions.html

Regards,

Martijn

_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
https://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
https://mail.zope.org/mailman/listinfo/zope-announce
https://mail.zope.org/mailman/listinfo/zope )

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads