Mailing List Archive: Zope: Dev

utilities and python version in zope2.12

Index | Next | Previous | View Threaded

jonas at freesources

Jul 5, 2009, 4:55 PM

Post #1 of 8 (973 views)
Permalink

utilities and python version in zope2.12

Hello,

I just recognized that lots of utilities in zope2.12 still do have
python2.4 as interpreter while the release notes of zope2.12 talk about
python2.5 and python2.6 being the only supported python versions.

greetings,
jonas
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )

tseaver at palladion

Jul 5, 2009, 7:24 PM

Post #2 of 8 (929 views)
Permalink

Re: utilities and python version in zope2.12 [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jonas Meurer wrote:
> Hello,
>
> I just recognized that lots of utilities in zope2.12 still do have
> python2.4 as interpreter while the release notes of zope2.12 talk about
> python2.5 and python2.6 being the only supported python versions.

True, but likely harmless: anything installed via a "console script"
entry point will have its shebang line rewritten to use whatver
fully-qualified interpreter path is used to run 'setup.py'.

I would be glad to check in a patch which changed them all, however ;)

Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tseaver [at] palladion
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFKUWBr+gerLs4ltQ4RAt9RAKDa5DL4nNyu031Yp1yZWdy+zagPOACfaK3+
6zIFfRx5KY7oTGZuw7wzX2Y=
=uVYA
-----END PGP SIGNATURE-----

_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )

jonas at freesources

Jul 6, 2009, 2:01 PM

Post #3 of 8 (907 views)
Permalink

Re: utilities and python version in zope2.12 [In reply to]

On 05/07/2009 Tres Seaver wrote:
> Jonas Meurer wrote:
> > Hello,
> >
> > I just recognized that lots of utilities in zope2.12 still do have
> > python2.4 as interpreter while the release notes of zope2.12 talk about
> > python2.5 and python2.6 being the only supported python versions.
>
> True, but likely harmless: anything installed via a "console script"
> entry point will have its shebang line rewritten to use whatver
> fully-qualified interpreter path is used to run 'setup.py'.
>
> I would be glad to check in a patch which changed them all, however ;)

I would be happy to provide a patch, but what exactly should I replace
python2.4 with?

The WHATSNEW document talks about both python2.5 and python2.6 being
supported. I think that using /usr/bin/python is not an option, as that
one might link to python3{.0/.1} in the future as well.

I see two solutions:

chose either python2.5 or python2.6 as prefered version and stick to
that one, or fix the build system to always set the python interpreter
for all scripts.

Even worse, at grepping for "env python" I found that two scripts still
have the python2.1 interpreter hardcoded:

src/AccessControl/securitySuite/regressionSecurity.py
src/Products/ZCTextIndex/tests/mhindex.py

some more stats:

27 scripts do have set an interpreter in their first line:

2 scripts with python2.1
9 scripts with python2.4
16 scripts with python (system default)

I would suggest to fix the build system (configure script) to set the
python interpreter to whatever is given as --with-python.

greetings,
jonas

Attachments:

signature.asc (0.19 KB)

lists at zopyx

Jul 6, 2009, 9:09 PM

Post #4 of 8 (900 views)
Permalink

Re: utilities and python version in zope2.12 [In reply to]

As Tres already pointed out: the *relevant* scripts are registered using
entry points afaik and will use the right Python interpreter.

Wrong references to old Python versions in

src/AccessControl/securitySuite/regressionSecurity.py
src/Products/ZCTextIndex/tests/mhindex.py

should be fixed but this only a cosmetic issue here.

Andreas

On 06.07.09 23:01, Jonas Meurer wrote:
> On 05/07/2009 Tres Seaver wrote:
>
>> Jonas Meurer wrote:
>>
>>> Hello,
>>>
>>> I just recognized that lots of utilities in zope2.12 still do have
>>> python2.4 as interpreter while the release notes of zope2.12 talk about
>>> python2.5 and python2.6 being the only supported python versions.
>>>
>> True, but likely harmless: anything installed via a "console script"
>> entry point will have its shebang line rewritten to use whatver
>> fully-qualified interpreter path is used to run 'setup.py'.
>>
>> I would be glad to check in a patch which changed them all, however ;)
>>
> I would be happy to provide a patch, but what exactly should I replace
> python2.4 with?
>
> The WHATSNEW document talks about both python2.5 and python2.6 being
> supported. I think that using /usr/bin/python is not an option, as that
> one might link to python3{.0/.1} in the future as well.
>
> I see two solutions:
>
> chose either python2.5 or python2.6 as prefered version and stick to
> that one, or fix the build system to always set the python interpreter
> for all scripts.
>
> Even worse, at grepping for "env python" I found that two scripts still
> have the python2.1 interpreter hardcoded:
>
> src/AccessControl/securitySuite/regressionSecurity.py
> src/Products/ZCTextIndex/tests/mhindex.py
>
> some more stats:
>
> 27 scripts do have set an interpreter in their first line:
>
> 2 scripts with python2.1
> 9 scripts with python2.4
> 16 scripts with python (system default)
>
> I would suggest to fix the build system (configure script) to set the
> python interpreter to whatever is given as --with-python.
>
> greetings,
> jonas
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Zope-Dev maillist - Zope-Dev [at] zope
> http://mail.zope.org/mailman/listinfo/zope-dev
> ** No cross posts or HTML encoding! **
> (Related lists -
> http://mail.zope.org/mailman/listinfo/zope-announce
> http://mail.zope.org/mailman/listinfo/zope )
>

--
ZOPYX Ltd. & Co. KG - Charlottenstr. 37/1 - 72070 T�bingen - Germany
Web: www.zopyx.com - Email: info [at] zopyx - Phone +49 - 7071 - 793376
Registergericht: Amtsgericht Stuttgart, Handelsregister A 381535
Gesch�ftsf�hrer/Gesellschafter: ZOPYX Limited, Birmingham, UK
------------------------------------------------------------------------
E-Publishing, Python, Zope & Plone development, Consulting

Attachments:

lists.vcf (0.31 KB)

jonas at freesources

Jul 10, 2009, 7:27 AM

Post #5 of 8 (893 views)
Permalink

Re: utilities and python version in zope2.12 [In reply to]

Hello again,

On 07/07/2009 Andreas Jung wrote:
> As Tres already pointed out: the *relevant* scripts are registered using
> entry points afaik and will use the right Python interpreter.
>
> Wrong references to old Python versions in
>
> src/AccessControl/securitySuite/regressionSecurity.py
> src/Products/ZCTextIndex/tests/mhindex.py
>
> should be fixed but this only a cosmetic issue here.

and as I can see in svn, you already fixed both of them. thanks for
that.

but what about all the scripts that still have python2.4 hardcoded as
interpreter? if zope2.12 doesn't support python2.4, these should be
fixed as well in my eyes.

here's a list of scripts that use hardcoded python2.4 interpreter:

src/Zope2/utilities/check_catalog.py
src/Zope2/utilities/compilezpy.py
src/Zope2/utilities/copyzopeskel.py
src/Zope2/utilities/decompilezpy.py
src/Zope2/utilities/load_site.py
src/Zope2/utilities/mkzeoinstance.py
src/Zope2/utilities/mkzopeinstance.py
src/Zope2/utilities/requestprofiler.py
src/Zope2/utilities/zpasswd.py

and one test has a python2.4 requirement in documentation:

src/ZPublisher/tests/generate_conflicts.py

see the attached patch to fix these remaining ones.

greetings,
jonas

Attachments:

zope2.12-rm_python2.4_refs.patch (4.84 KB)

jonas at freesources

Jul 14, 2009, 9:14 AM

Post #6 of 8 (827 views)
Permalink

Re: utilities and python version in zope2.12 [In reply to]

Hey,

is there any reason why my patch has been ignored so far? if there are
issues with it, please tell me so I can fix them ...

greetings,
jonas

On 10/07/2009 Jonas Meurer wrote:
> Hello again,
>
> On 07/07/2009 Andreas Jung wrote:
> > As Tres already pointed out: the *relevant* scripts are registered using
> > entry points afaik and will use the right Python interpreter.
> >
> > Wrong references to old Python versions in
> >
> > src/AccessControl/securitySuite/regressionSecurity.py
> > src/Products/ZCTextIndex/tests/mhindex.py
> >
> > should be fixed but this only a cosmetic issue here.
>
> and as I can see in svn, you already fixed both of them. thanks for
> that.
>
> but what about all the scripts that still have python2.4 hardcoded as
> interpreter? if zope2.12 doesn't support python2.4, these should be
> fixed as well in my eyes.
>
> here's a list of scripts that use hardcoded python2.4 interpreter:
>
> src/Zope2/utilities/check_catalog.py
> src/Zope2/utilities/compilezpy.py
> src/Zope2/utilities/copyzopeskel.py
> src/Zope2/utilities/decompilezpy.py
> src/Zope2/utilities/load_site.py
> src/Zope2/utilities/mkzeoinstance.py
> src/Zope2/utilities/mkzopeinstance.py
> src/Zope2/utilities/requestprofiler.py
> src/Zope2/utilities/zpasswd.py
>
> and one test has a python2.4 requirement in documentation:
>
> src/ZPublisher/tests/generate_conflicts.py
>
> see the attached patch to fix these remaining ones.
>
> greetings,
> jonas
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )

lists at zopyx

Jul 15, 2009, 1:29 AM

Post #7 of 8 (835 views)
Permalink

Re: utilities and python version in zope2.12 [In reply to]

On 14.07.09 18:14, Jonas Meurer wrote:
> Hey,
>
> is there any reason why my patch has been ignored so far? if there are
> issues with it, please tell me so I can fix them ...

Please submit patches to the bugtracker. Don't expect that I follow any
posting
and check it for patches.

Andreas

Attachments:

lists.vcf (0.31 KB)

jonas at freesources

Jul 15, 2009, 4:48 AM

Post #8 of 8 (818 views)
Permalink

Re: utilities and python version in zope2.12 [In reply to]

On 15/07/2009 Andreas Jung wrote:
> On 14.07.09 18:14, Jonas Meurer wrote:
> > Hey,
> >
> > is there any reason why my patch has been ignored so far? if there are
> > issues with it, please tell me so I can fix them ...
>
> Please submit patches to the bugtracker. Don't expect that I follow any
> posting and check it for patches.

all right: https://bugs.launchpad.net/zope2/+bug/399633

greetings,
jonas
_______________________________________________
Zope-Dev maillist - Zope-Dev [at] zope
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads