Mailing List Archive: Zope: Dev

RFC: zope.app.pagetemplate.engine dependencies

Index | Next | Previous | View Threaded

tseaver at palladion

May 25, 2009, 9:37 AM

Post #1 of 7 (535 views)
Permalink

RFC: zope.app.pagetemplate.engine dependencies

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Resolution #1
=============

Whereas:

- - The 'zope.app.pagetemplate.engine' module pulls in nothing from
'zope.app' packages except some antique testing support in doctest;

- - that module is potentially useful outside the scope of the Zope3 ZMI;

therefore be it resolved:

- - that we move the 'engine' module to 'zope.pagetemplate', along with
its supporting scaffolding, and clean up the tests.

Resolution #2
=============

Whereas:

- - The 'evaluateInlineCode' support in the 'engine' module has
no tests;

- - its comments indicate that it exists to support 'zope.app.pythonpage',
which doesn't even import the module;

- - third-party consumers of the feature have a recently-released version
of the egg which they can continue using indefinitely;

therefore be it resolved:

- - that we remove the code entirely, documenting the backward
incompatibility in a new feature release.

Resolution #3
=============

Whereas:

- - In Zope2, the 'Products.PageTemplates.Expressions' module depends
on the 'zope.app.pagetemplates.engine' module, but only uses its
'ZopeEngine' class;

- - Zope2 further supplies its own context class (to avoid using the Zope3
security model);

- - one remaining bit of non-overridden functionality is the Zope3-
proxified 'getFunctionNamespace' wrapper, which probably won't work
at all as intended;

- - the other bit is the use of the AdapterNamespaces bit, which feeds
into the 'getFunctionNamespace' bit;

therefore be it resolved:

- - that we forego using the 'ZopeEngine' class completely in Zope2,
providing instead a forked / simplified implementation.

Debate, anyone?

Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tseaver[at]palladion.com
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFKGsle+gerLs4ltQ4RAgNKAJwOyvPTdkV40l6YaE7LgXNvts9eagCdHlRF
WYPBpVkAXT7nBhX9hSTj9rY=
=5xWq
-----END PGP SIGNATURE-----

_______________________________________________
Zope-Dev maillist - Zope-Dev[at]zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )

chrism at plope

May 25, 2009, 9:50 AM

Post #2 of 7 (501 views)
Permalink

Re: RFC: zope.app.pagetemplate.engine dependencies [In reply to]

On 5/25/09 12:37 PM, Tres Seaver wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Resolution #1
> =============
>
> Whereas:

..snip..

> Debate, anyone?

+1.

- C
_______________________________________________
Zope-Dev maillist - Zope-Dev[at]zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )

hannosch at hannosch

May 25, 2009, 10:10 AM

Post #3 of 7 (505 views)
Permalink

Re: RFC: zope.app.pagetemplate.engine dependencies [In reply to]

Chris McDonough wrote:
> On 5/25/09 12:37 PM, Tres Seaver wrote:
>>
>> Debate, anyone?
>
> +1.

+1, you? ;)

Hanno

_______________________________________________
Zope-Dev maillist - Zope-Dev[at]zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )

faassen at startifact

May 25, 2009, 12:15 PM

Post #4 of 7 (500 views)
Permalink

Re: RFC: zope.app.pagetemplate.engine dependencies [In reply to]

Tres Seaver wrote:
> Resolution #1
> =============

+1

> Resolution #2
> =============
>
> Whereas:
[removing evaluateInlineCode]

zope.app.catalog: old-fashioned HTTP log test. Not very important.
zope.app.publication: the same
zope.app.exception: the same

zope.app.session: actually turns on evaluateInlineCode in test setup for
some reason. A discussion topic.

zope.app.zptpage: actual code and tests that mess around with
evaluateInlineCode. A discussion topic

zope.app.session seems to be almost wholly moved to zope.session,
leaving some ZMI stuff behind. I think this means we can safely ignore
zope.app.session.

zope.app.zptpage is the most interesting. It maintains an
evaluateInlineCode attribute and passes it along to
zope.app.pagetemplate. Of course it also is there to support the ZMI.
Since it's unlikely anyone actually has *useful* ZPT pages with inline
code, as nobody is programming with the ZMI anyway, I propose we just
rip this support out of here. But this can be done later when we see
things break.

+1 for removing it.

> Resolution #3
> =============

I'm fine with this, though haven't done any real analysis. :)

Regards,

Martijn

_______________________________________________
Zope-Dev maillist - Zope-Dev[at]zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )

tseaver at palladion

May 25, 2009, 1:08 PM

Post #5 of 7 (491 views)
Permalink

Re: RFC: zope.app.pagetemplate.engine dependencies [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Tres Seaver wrote:

> Resolution #1
> =============
>
> Whereas:
>
> - The 'zope.app.pagetemplate.engine' module pulls in nothing from
> 'zope.app' packages except some antique testing support in doctest;
>
> - that module is potentially useful outside the scope of the Zope3 ZMI;
>
> therefore be it resolved:
>
> - that we move the 'engine' module to 'zope.pagetemplate', along with
> its supporting scaffolding, and clean up the tests.

Done, and released in the following:

- http://pypi.python.org/pypi/zope.pagetemplate/3.5.0
- http://pypi.python.org/pypi/zope.app.pagetemplate/3.7.0

I also had to release an updated 'zope.app.publisher', in order to get
the tests for 'zope.app.pagetemplate' to pass: the older version was
depending on being able to import the 'engine' module from the old location:

http://pypi.python.org/pypi/zope.app.publisher/3.8.1

Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tseaver[at]palladion.com
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFKGvqk+gerLs4ltQ4RAtQVAKCCaozyXLF8zz9P7sTG/EbeFZdpeQCfRawJ
wevk9XNVT7RGFRKfYV6nFJA=
=tbs9
-----END PGP SIGNATURE-----

_______________________________________________
Zope-Dev maillist - Zope-Dev[at]zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )

tseaver at palladion

May 25, 2009, 1:13 PM

Post #6 of 7 (492 views)
Permalink

Re: RFC: zope.app.pagetemplate.engine dependencies [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martijn Faassen wrote:
> Tres Seaver wrote:

>> Resolution #2
>> =============
>>
>> Whereas:
> [removing evaluateInlineCode]
>
> zope.app.catalog: old-fashioned HTTP log test. Not very important.
> zope.app.publication: the same
> zope.app.exception: the same
>
> zope.app.session: actually turns on evaluateInlineCode in test setup for
> some reason. A discussion topic.
>
> zope.app.zptpage: actual code and tests that mess around with
> evaluateInlineCode. A discussion topic
>
> zope.app.session seems to be almost wholly moved to zope.session,
> leaving some ZMI stuff behind. I think this means we can safely ignore
> zope.app.session.
>
> zope.app.zptpage is the most interesting. It maintains an
> evaluateInlineCode attribute and passes it along to
> zope.app.pagetemplate. Of course it also is there to support the ZMI.
> Since it's unlikely anyone actually has *useful* ZPT pages with inline
> code, as nobody is programming with the ZMI anyway, I propose we just
> rip this support out of here. But this can be done later when we see
> things break.
>
> +1 for removing it.

Ah, the code refered to 'zope.app.pythonpage', but should have been
talking about 'zope.app.zptpage'. It should be simple for that package
to pick up the implementation of 'evaluateCode' and add it to a custom
'ZopeContext' derivative which it uses when evaluating the page.

>> Resolution #3
>> =============
>
> I'm fine with this, though haven't done any real analysis. :)

This is a "back to the future" change (or feels like it, anyway).

Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tseaver[at]palladion.com
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFKGvvR+gerLs4ltQ4RAgOEAKDLvaaqnviDYek692cnSER/qqlFiACgmhB8
AIiZKBXxgJ/5pZFW41vAQ10=
=/cMi
-----END PGP SIGNATURE-----

_______________________________________________
Zope-Dev maillist - Zope-Dev[at]zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )

tseaver at palladion

May 25, 2009, 6:36 PM

Post #7 of 7 (492 views)
Permalink

Re: RFC: zope.app.pagetemplate.engine dependencies [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Tres Seaver wrote:

> Resolution #3
> =============
>
> Whereas:
>
> - In Zope2, the 'Products.PageTemplates.Expressions' module depends
> on the 'zope.app.pagetemplates.engine' module, but only uses its
> 'ZopeEngine' class;
>
> - Zope2 further supplies its own context class (to avoid using the Zope3
> security model);
>
> - one remaining bit of non-overridden functionality is the Zope3-
> proxified 'getFunctionNamespace' wrapper, which probably won't work
> at all as intended;
>
> - the other bit is the use of the AdapterNamespaces bit, which feeds
> into the 'getFunctionNamespace' bit;
>
> therefore be it resolved:
>
> - that we forego using the 'ZopeEngine' class completely in Zope2,
> providing instead a forked / simplified implementation.

Done. Zope2 no longer imports / depnds on zope.app.pagetemplate
directly at all.

Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tseaver[at]palladion.com
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFKG0ef+gerLs4ltQ4RAs+NAJ9auYhR7cdjhueap2XBJHzdSNPc+ACggh9Q
pEzQbdFdU6nABlVpO5HoLfU=
=A4h8
-----END PGP SIGNATURE-----

_______________________________________________
Zope-Dev maillist - Zope-Dev[at]zope.org
http://mail.zope.org/mailman/listinfo/zope-dev
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope )

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com