Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Zope: CMF

CMF 2.2 icon_expr vs. content_icon

 

 

Zope cmf RSS feed   Index | Next | Previous | View Threaded


optilude+lists at gmail

Nov 6, 2009, 12:07 AM

Post #1 of 2 (67 views)
Permalink
CMF 2.2 icon_expr vs. content_icon

Hi,

What's the reasoning behind having both a content_icon and an icon_expr
property on FTIs in CMF 2.2?

Apart from being really confusing, it seems that DynamicType.getIcon()
returns fti.getIcon() (with some mangling), which returns self.content_icon.

Hence, if you set an icon with icon_expr and leave content_icon,
getIcon() always returns an empty string.

This sounds like a bug to me, but I'm not sure how best to fix it:

- remove one of content_icon and icon_expr?
- make TypeInfo.getIcon() check both? If so, which takes precedence?
- make Dynamictype.getIcon() check both? If so, which takes precedence?

Martin

--
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book

_______________________________________________
Zope-CMF maillist - Zope-CMF[at]zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests


y.2009 at wcm-solutions

Nov 6, 2009, 1:48 AM

Post #2 of 2 (60 views)
Permalink
Re: CMF 2.2 icon_expr vs. content_icon [In reply to]

Martin Aspeli wrote:
> What's the reasoning behind having both a content_icon and an icon_expr
> property on FTIs in CMF 2.2?
>
> Apart from being really confusing, it seems that DynamicType.getIcon()
> returns fti.getIcon() (with some mangling), which returns self.content_icon.
>
> Hence, if you set an icon with icon_expr and leave content_icon,
> getIcon() always returns an empty string.
>
> This sounds like a bug to me, but I'm not sure how best to fix it:
>
> - remove one of content_icon and icon_expr?
> - make TypeInfo.getIcon() check both? If so, which takes precedence?
> - make Dynamictype.getIcon() check both? If so, which takes precedence?

See https://bugs.launchpad.net/zope-cmf/+bug/397795

Yuppie

_______________________________________________
Zope-CMF maillist - Zope-CMF[at]zope.org
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

Zope cmf RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact lists@gossamer-threads.com
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.