Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Zope: CMF

Generic Setup upgrade steps

 

 

Zope cmf RSS feed   Index | Next | Previous | View Threaded


gotcha at bubblenet

Sep 3, 2009, 3:52 AM

Post #1 of 2 (747 views)
Permalink
Generic Setup upgrade steps

Hi,

I just went through the Generic Setup upgrade steps code.

I am surprised that `manage_doUpgrades` method of the tool does not
check if the step is applicable : AFAICS the `isProposed` method is only
used by the ZPT UI.

I would suggest that `doStep` method of `upgradeStep` class should check
applicability or at least that the tool should check before running the
step.

Opinions ?
--
Godefroid Chapelle (aka __gotcha) http://bubblenet.be

_______________________________________________
Zope-CMF maillist - Zope-CMF [at] zope
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests


y.2009 at wcm-solutions

Sep 3, 2009, 6:22 AM

Post #2 of 2 (689 views)
Permalink
Re: Generic Setup upgrade steps [In reply to]

Hi!


Godefroid Chapelle wrote:
> I am surprised that `manage_doUpgrades` method of the tool does not
> check if the step is applicable : AFAICS the `isProposed` method is only
> used by the ZPT UI.
>
> I would suggest that `doStep` method of `upgradeStep` class should check
> applicability or at least that the tool should check before running the
> step.
>
> Opinions ?

-1

'isProposed' just gives a recommendation. Sometimes it is useful to
(re-)run steps that are not proposed. The ZMI page and
'manage_doUpgrades' intentionally allow to ignore 'isProposed' restrictions.


Cheers,

Yuppie

_______________________________________________
Zope-CMF maillist - Zope-CMF [at] zope
https://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

Zope cmf RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.