Mailing List Archive: Zope: CMF

Improvements to Discussion Items

Index | Next | Previous | View Threaded

optilude+lists at gmail

Mar 22, 2009, 2:45 AM

Post #1 of 2 (796 views)
Permalink

Improvements to Discussion Items

Hi,

I've been working on improving commenting in Plone. I'm not 100% sure
we'll stay with CMFDefault's idea of Discussion Items forever, but for
now there are a couple of low-risk things that would make them a lot
more useful.

1) Fire an IObjectAddedEvent when a Discussion Item is created
2) Fire an IObjectRemovedEvent when a Discussion Item deleted
3) Do not hardcode the review_state of a Discuss Item. This allows
discussion items to participate in workflow.

4) Create discussion items based on an IFactory utility rather than
hardcoding the class.

I've implemented 1-3, along with a simple review workflow and indexers
that index the number of comments and the people who've commented on a
content item (to make it easier to find items the current user has
commented on, and to show the number of comments an item has received in
a content listing), in a new Plone product, collective.discussionplus.
There's a file of simple monkey patches to CMFDefault here:

http://dev.plone.org/collective/browser/collective.discussionplus/trunk/collective/discussionplus/patches.py

Would it be useful to push this down into CMF itself? I can't promise I
have time to do that (with tests) in the short term, but I'm happy to
help anyone who wants to do it. I may find time later, of course.

Martin

--
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book

_______________________________________________
Zope-CMF maillist - Zope-CMF [at] lists
http://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

charlie at begeistert

Mar 24, 2009, 2:29 PM

Post #2 of 2 (723 views)
Permalink

Re: Improvements to Discussion Items [In reply to]

Am 22.03.2009 um 10:45 schrieb Martin Aspeli:

> 1) Fire an IObjectAddedEvent when a Discussion Item is created
> 2) Fire an IObjectRemovedEvent when a Discussion Item deleted
> 3) Do not hardcode the review_state of a Discuss Item. This allows
> discussion items to participate in workflow.
>
> 4) Create discussion items based on an IFactory utility rather than
> hardcoding the class.
>
> I've implemented 1-3, along with a simple review workflow and indexers
> that index the number of comments and the people who've commented on a
> content item (to make it easier to find items the current user has
> commented on, and to show the number of comments an item has
> received in
> a content listing), in a new Plone product, collective.discussionplus.
> There's a file of simple monkey patches to CMFDefault here:
>
> http://dev.plone.org/collective/browser/collective.discussionplus/trunk/collective/discussionplus/patches.py
>
> Would it be useful to push this down into CMF itself? I can't
> promise I
> have time to do that (with tests) in the short term, but I'm happy to
> help anyone who wants to do it. I may find time later, of course.

Hiya Martin,

thanks very much for this. Seems to make a lot of sense to me. I'll
put it on to my to-do list when I've actually done the two things on
there already.

Charlie
--
Charlie Clark
Helmholtzstr. 20
Düsseldorf
D- 40215
Tel: +49-211-938-5360
GSM: +49-178-782-6226

_______________________________________________
Zope-CMF maillist - Zope-CMF [at] lists
http://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads