Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Zope: CMF

Re: SVN: Products.CMFDefault/trunk/setup.py - dependency cleanup

 

 

Zope cmf RSS feed   Index | Next | Previous | View Threaded


tseaver at palladion

Feb 16, 2009, 8:44 AM

Post #1 of 5 (490 views)
Permalink
Re: SVN: Products.CMFDefault/trunk/setup.py - dependency cleanup

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Yvo Schubbe wrote:
> Log message for revision 96580:
> - dependency cleanup
>
> Changed:
> U Products.CMFDefault/trunk/setup.py
>
> -=-
> Modified: Products.CMFDefault/trunk/setup.py
> ===================================================================
> --- Products.CMFDefault/trunk/setup.py 2009-02-16 10:42:54 UTC (rev 96579)
> +++ Products.CMFDefault/trunk/setup.py 2009-02-16 10:43:09 UTC (rev 96580)
> @@ -45,14 +45,18 @@
> setup_requires=['eggtestinfo',
> ],
> install_requires=[.
> - #'Zope >= 2.10.4',
> 'setuptools',
> + #'Zope2 >= 2.10.4',
> 'Products.CMFCore',
> - 'Products.DCWorkflow',
> 'Products.GenericSetup',
> ],
> - tests_require=['zope.testing>=3.7.0',
> - ],
> + tests_require=[.
> + 'zope.testing >= 3.7.0',
> + 'Products.DCWorkflow',
> + ],
> + extras_require = dict(
> + test = ['Products.DCWorkflow'],
> + ),

Can somebody explain the dependency on DCWorkflow's ZCML getting loaded?
This seems like it should be ripped out: no tests should need to get
actaul DCWrolfow instances configured. Or are we trying to run
functional tests against a site configured from a profile which uses
DCWorkflow?


Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tseaver[at]palladion.com
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJmZfZ+gerLs4ltQ4RAhaEAKCwoZOfwjbjfltvdHOdAQ8OvQeFEgCfQDGp
V2pNxMBXIYLVWBsaei2/y5k=
=Sbzi
-----END PGP SIGNATURE-----
_______________________________________________
Zope-CMF maillist - Zope-CMF[at]lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests


tseaver at palladion

Feb 16, 2009, 8:44 AM

Post #2 of 5 (458 views)
Permalink
Re: SVN: Products.CMFDefault/trunk/setup.py - dependency cleanup [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Yvo Schubbe wrote:
> Log message for revision 96580:
> - dependency cleanup
>
> Changed:
> U Products.CMFDefault/trunk/setup.py
>
> -=-
> Modified: Products.CMFDefault/trunk/setup.py
> ===================================================================
> --- Products.CMFDefault/trunk/setup.py 2009-02-16 10:42:54 UTC (rev 96579)
> +++ Products.CMFDefault/trunk/setup.py 2009-02-16 10:43:09 UTC (rev 96580)
> @@ -45,14 +45,18 @@
> setup_requires=['eggtestinfo',
> ],
> install_requires=[.
> - #'Zope >= 2.10.4',
> 'setuptools',
> + #'Zope2 >= 2.10.4',
> 'Products.CMFCore',
> - 'Products.DCWorkflow',
> 'Products.GenericSetup',
> ],
> - tests_require=['zope.testing>=3.7.0',
> - ],
> + tests_require=[.
> + 'zope.testing >= 3.7.0',
> + 'Products.DCWorkflow',
> + ],
> + extras_require = dict(
> + test = ['Products.DCWorkflow'],
> + ),

Can somebody explain the dependency on DCWorkflow's ZCML getting loaded?
This seems like it should be ripped out: no tests should need to get
actaul DCWrolfow instances configured. Or are we trying to run
functional tests against a site configured from a profile which uses
DCWorkflow?


Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tseaver[at]palladion.com
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJmZfZ+gerLs4ltQ4RAhaEAKCwoZOfwjbjfltvdHOdAQ8OvQeFEgCfQDGp
V2pNxMBXIYLVWBsaei2/y5k=
=Sbzi
-----END PGP SIGNATURE-----

_______________________________________________
Zope-CMF maillist - Zope-CMF[at]lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests


jens at dataflake

Feb 16, 2009, 9:33 AM

Post #3 of 5 (458 views)
Permalink
Re: SVN: Products.CMFDefault/trunk/setup.py - dependency cleanup [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


On Feb 16, 2009, at 17:44 , Tres Seaver wrote:

> Can somebody explain the dependency on DCWorkflow's ZCML getting
> loaded?
> This seems like it should be ripped out: no tests should need to get
> actaul DCWrolfow instances configured. Or are we trying to run
> functional tests against a site configured from a profile which uses
> DCWorkflow?

Well, the use of the DCWorkflow profile is indirect.
CMFDefault.testing defines a functional test layer that instantiates a
portal using the CMFDefault default profile. Without loading the
DCWorkflow profile, workflow creation fails with the traceback below.

jens


Set up Products.CMFDefault.testing.FunctionalLayer Traceback (most
recent call last):
File "/usr/local/py24/CMF.buildout-trunk/eggs/zope.testing-3.7.1-
py2.4.egg/zope/testing/testrunner/runner.py", line 360, in run_layer
setup_layer(options, layer, setup_layers)
File "/usr/local/py24/CMF.buildout-trunk/eggs/zope.testing-3.7.1-
py2.4.egg/zope/testing/testrunner/runner.py", line 536, in setup_layer
layer.setUp()
File "/usr/local/py24/CMF.buildout-trunk/src/Products.CMFDefault/
Products/CMFDefault/testing.py", line 41, in setUp
snapshot=False)
File "/usr/local/py24/CMF.buildout-trunk/src/Products.CMFDefault/
Products/CMFDefault/factory.py", line 63, in addConfiguredSite
setup_tool.runAllImportStepsFromProfile('profile-%s' % profile_id)
File "/usr/local/py24/CMF.buildout-trunk/src/Products.GenericSetup/
Products/GenericSetup/tool.py", line 327, in
runAllImportStepsFromProfile
ignore_dependencies=ignore_dependencies)
File "/usr/local/py24/CMF.buildout-trunk/src/Products.GenericSetup/
Products/GenericSetup/tool.py", line 1082, in _runImportStepsFromContext
message = self._doRunImportStep(step, context)
File "/usr/local/py24/CMF.buildout-trunk/src/Products.GenericSetup/
Products/GenericSetup/tool.py", line 996, in _doRunImportStep
return handler(context)
File "/usr/local/py24/CMF.buildout-trunk/src/Products.CMFCore/
Products/CMFCore/exportimport/workflow.py", line 126, in
importWorkflowTool
importObjects(tool, '', context)
File "/usr/local/py24/CMF.buildout-trunk/src/Products.GenericSetup/
Products/GenericSetup/utils.py", line 821, in importObjects
importer.body = body
File "/usr/local/py24/CMF.buildout-trunk/src/Products.GenericSetup/
Products/GenericSetup/utils.py", line 505, in _importBody
self._importNode(dom.documentElement)
File "/usr/local/py24/CMF.buildout-trunk/src/Products.CMFCore/
Products/CMFCore/exportimport/workflow.py", line 63, in _importNode
self._initObjects(node)
File "/usr/local/py24/CMF.buildout-trunk/src/Products.GenericSetup/
Products/GenericSetup/utils.py", line 566, in _initObjects
raise ValueError("unknown meta_type '%s'" % meta_type)
ValueError: unknown meta_type 'Workflow'



-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)

iEYEARECAAYFAkmZo08ACgkQRAx5nvEhZLJw/gCgtRL31njX0iG5oOAxs9Q51qre
OcAAn0Ra7YOYiCwpSRRHAi7z5e4wrUlz
=DfYB
-----END PGP SIGNATURE-----
_______________________________________________
Zope-CMF maillist - Zope-CMF[at]lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests


tseaver at palladion

Feb 16, 2009, 9:40 AM

Post #4 of 5 (460 views)
Permalink
Re: SVN: Products.CMFDefault/trunk/setup.py - dependency cleanup [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jens Vagelpohl wrote:
>
> On Feb 16, 2009, at 17:44 , Tres Seaver wrote:
>
>> Can somebody explain the dependency on DCWorkflow's ZCML getting
>> loaded?
>> This seems like it should be ripped out: no tests should need to get
>> actaul DCWrolfow instances configured. Or are we trying to run
>> functional tests against a site configured from a profile which uses
>> DCWorkflow?
>
> Well, the use of the DCWorkflow profile is indirect.
> CMFDefault.testing defines a functional test layer that instantiates a
> portal using the CMFDefault default profile. Without loading the
> DCWorkflow profile, workflow creation fails with the traceback below.

Thanks, I had just chased that down myself. I have the sense that
CMFDefault is probably ripe for a split: all the code which backs
persistent objects (content types, the site itself, the tools) should
stay, but the part which actually provides the default baseline profile
should maybe be split out.


Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tseaver[at]palladion.com
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJmaT9+gerLs4ltQ4RAkr1AJ4yo2tW6q9juSZ8qntz2TLVS488IACeJaaN
GZXjUslc1Gf/bWkUog4iJek=
=gVze
-----END PGP SIGNATURE-----
_______________________________________________
Zope-CMF maillist - Zope-CMF[at]lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests


tseaver at palladion

Feb 16, 2009, 9:40 AM

Post #5 of 5 (460 views)
Permalink
Re: SVN: Products.CMFDefault/trunk/setup.py - dependency cleanup [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jens Vagelpohl wrote:
>
> On Feb 16, 2009, at 17:44 , Tres Seaver wrote:
>
>> Can somebody explain the dependency on DCWorkflow's ZCML getting
>> loaded?
>> This seems like it should be ripped out: no tests should need to get
>> actaul DCWrolfow instances configured. Or are we trying to run
>> functional tests against a site configured from a profile which uses
>> DCWorkflow?
>
> Well, the use of the DCWorkflow profile is indirect.
> CMFDefault.testing defines a functional test layer that instantiates a
> portal using the CMFDefault default profile. Without loading the
> DCWorkflow profile, workflow creation fails with the traceback below.

Thanks, I had just chased that down myself. I have the sense that
CMFDefault is probably ripe for a split: all the code which backs
persistent objects (content types, the site itself, the tools) should
stay, but the part which actually provides the default baseline profile
should maybe be split out.


Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tseaver[at]palladion.com
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFJmaT9+gerLs4ltQ4RAkr1AJ4yo2tW6q9juSZ8qntz2TLVS488IACeJaaN
GZXjUslc1Gf/bWkUog4iJek=
=gVze
-----END PGP SIGNATURE-----

_______________________________________________
Zope-CMF maillist - Zope-CMF[at]lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

Zope cmf RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact lists@gossamer-threads.com
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.