Mailing List Archive: Zope: CMF

[dev] type infos and 'add' actions - a proposal

Index | Next | Previous | View Threaded

y.2008 at wcm-solutions

Jul 21, 2008, 3:51 AM

Post #1 of 6 (438 views)
Permalink

[dev] type infos and 'add' actions - a proposal

Hi!

This is a proposal for implementing one part of what we discussed in
this thread:
http://mail.zope.org/pipermail/zope-cmf/2008-July/027500.html

Using add views instead of folder_factories for creating content makes
it necessary to provide some kind of menu items for them. In CMF menu
items are usually represented by 'actions'.

Type infos already define most data required for actions:

- 'id': can be reused

- 'title': can be reused; if we want action titles like 'Add File ...'
instead of 'File' we can change that in the template

- 'description': has already the same purpose as in actions

- 'icon': 'content_icon' is a path relative to the site root, but we can
use the same icon and compute the required absolute path

- 'available': can be computed using allowType of the container

- 'allowed': can be computed using isConstructionAllowed

Missing are these properties:

- 'category': can be hardcoded, e.g. as 'folder/add'

- 'url': requires a new type info property, I propose to use 'url_expr'
to keep it in sync with normal Action objects

- 'visible': can be hardcoded as True

So instead of adding separate 'add' actions we can extend the type info
classes, making them implement IAction as well.

listActions of the types tool would include type infos if they provide
IAction *and* have an url specified.

As always, feedback is welcome.

Cheers,

Yuppie

_______________________________________________
Zope-CMF maillist - Zope-CMF[at]lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

tseaver at palladion

Jul 21, 2008, 7:07 AM

Post #2 of 6 (417 views)
Permalink

Re: [dev] type infos and 'add' actions - a proposal [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

yuppie wrote:
> Hi!
>
>
> This is a proposal for implementing one part of what we discussed in
> this thread:
> http://mail.zope.org/pipermail/zope-cmf/2008-July/027500.html
>
> Using add views instead of folder_factories for creating content makes
> it necessary to provide some kind of menu items for them. In CMF menu
> items are usually represented by 'actions'.
>
>
> Type infos already define most data required for actions:
>
> - 'id': can be reused
>
> - 'title': can be reused; if we want action titles like 'Add File ...'
> instead of 'File' we can change that in the template
>
> - 'description': has already the same purpose as in actions
>
> - 'icon': 'content_icon' is a path relative to the site root, but we can
> use the same icon and compute the required absolute path
>
> - 'available': can be computed using allowType of the container
>
> - 'allowed': can be computed using isConstructionAllowed
>
> Missing are these properties:
>
> - 'category': can be hardcoded, e.g. as 'folder/add'
>
> - 'url': requires a new type info property, I propose to use 'url_expr'
> to keep it in sync with normal Action objects
>
> - 'visible': can be hardcoded as True
>
>
> So instead of adding separate 'add' actions we can extend the type info
> classes, making them implement IAction as well.
>
> listActions of the types tool would include type infos if they provide
> IAction *and* have an url specified.
>
>
> As always, feedback is welcome.

+1. Seems a simple, straighforward extension, with zero BBB problems.

Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tseaver[at]palladion.com
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIhJgu+gerLs4ltQ4RAmZpAKCzp8t3m5Xf/NAq+ShK8tQwULR5LACgjhU+
oBdD84fizqzDGOmUFR5d9wI=
=rcl2
-----END PGP SIGNATURE-----

_______________________________________________
Zope-CMF maillist - Zope-CMF[at]lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

jens at dataflake

Jul 21, 2008, 7:13 AM

Post #3 of 6 (423 views)
Permalink

Re: [dev] type infos and 'add' actions - a proposal [In reply to]

On Jul 21, 2008, at 12:51 , yuppie wrote:

> Hi!
>
>
> This is a proposal for implementing one part of what we discussed in
> this thread:
> http://mail.zope.org/pipermail/zope-cmf/2008-July/027500.html

+1 from me. Thanks for proactively taking this on.

jens

_______________________________________________
Zope-CMF maillist - Zope-CMF[at]lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

charlie at begeistert

Jul 21, 2008, 12:17 PM

Post #4 of 6 (412 views)
Permalink

Re: [dev] type infos and 'add' actions - a proposal [In reply to]

Am 21.07.2008 um 12:51 schrieb yuppie:

> So instead of adding separate 'add' actions we can extend the type
> info classes, making them implement IAction as well.
>
> listActions of the types tool would include type infos if they
> provide IAction *and* have an url specified.
>
>
> As always, feedback is welcome.

+1 an excellent suggestion!

Charlie
--
Charlie Clark
Helmholtzstr. 20
D�sseldorf
D- 40215
Tel: +49-211-938-5360
GSM: +49-178-782-6226

_______________________________________________
Zope-CMF maillist - Zope-CMF[at]lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

optilude at gmx

Jul 21, 2008, 2:04 PM

Post #5 of 6 (416 views)
Permalink

Re: [dev] type infos and 'add' actions - a proposal [In reply to]

Hi Yuppie,

> This is a proposal for implementing one part of what we discussed in
> this thread:
> http://mail.zope.org/pipermail/zope-cmf/2008-July/027500.html
>
> Using add views instead of folder_factories for creating content makes
> it necessary to provide some kind of menu items for them. In CMF menu
> items are usually represented by 'actions'.
>
>
> Type infos already define most data required for actions:
>
> - 'id': can be reused
>
> - 'title': can be reused; if we want action titles like 'Add File ...'
> instead of 'File' we can change that in the template
>
> - 'description': has already the same purpose as in actions
>
> - 'icon': 'content_icon' is a path relative to the site root, but we can
> use the same icon and compute the required absolute path
>
> - 'available': can be computed using allowType of the container
>
> - 'allowed': can be computed using isConstructionAllowed
>
> Missing are these properties:
>
> - 'category': can be hardcoded, e.g. as 'folder/add'
>
> - 'url': requires a new type info property, I propose to use 'url_expr'
> to keep it in sync with normal Action objects

I wonder whether addview_url or something similar would be more
appropriate, since "the url of a type" is somewhat ambiguous.

> - 'visible': can be hardcoded as True
>
>
> So instead of adding separate 'add' actions we can extend the type info
> classes, making them implement IAction as well.

How about making them adaptable to IAction instead of directly
implementing it? That sounds cleaner than trying to bend some of the old
properties.

> listActions of the types tool would include type infos if they provide
> IAction *and* have an url specified.

Apart from the two comments above, a great +1. :)

Martin

--
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book

_______________________________________________
Zope-CMF maillist - Zope-CMF[at]lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

y.2008 at wcm-solutions

Jul 29, 2008, 11:35 AM

Post #6 of 6 (366 views)
Permalink

Re: [dev] type infos and 'add' actions - a proposal [In reply to]

Hi!

Martin Aspeli wrote:
>> - 'url': requires a new type info property, I propose to use
>> 'url_expr' to keep it in sync with normal Action objects
>
> I wonder whether addview_url or something similar would be more
> appropriate, since "the url of a type" is somewhat ambiguous.

Ok. I changed that to 'add_view_expr'. The '_expr' suffix is used to
implement special behavior for expressions.

>> So instead of adding separate 'add' actions we can extend the type
>> info classes, making them implement IAction as well.
>
> How about making them adaptable to IAction instead of directly
> implementing it? That sounds cleaner than trying to bend some of the old
> properties.

Don't think so. IAction just adds one method: getInfoData(). The names I
mentioned are keys in the data structure returned by that method, not
bent properties.

My changes are now checked in on the trunk. So far I didn't add a
'portal_type' variable to the expression context because I don't know an
easy way to do that. The action machinery expects that all callable
attributes of all actions take the same expression context as argument.

Cheers,

Yuppie

_______________________________________________
Zope-CMF maillist - Zope-CMF[at]lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com