Mailing List Archive: Zope: CMF

[dev] GenericSetup: using global steps

Index | Next | Previous | View Threaded

y.2007- at wcm-solutions

Dec 19, 2007, 12:53 PM

Post #1 of 12 (1588 views)
Permalink

[dev] GenericSetup: using global steps

Hi!

GenericSetup trunk has global step registries. I propose to use the new
ZCML directive for registering all GenericSetup and CMF import and
export steps globally. And to remove the import_steps.xml and
export_steps.xml files from the profiles shipped with CMF.

This also requires to add a flag file for the 'various' step.

I already started implementing this. If there are no objections, I'll
soon check in my changes.

Cheers,

Yuppie

_______________________________________________
Zope-CMF maillist - Zope-CMF [at] lists
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

plone at hannosch

Dec 19, 2007, 4:10 PM

Post #2 of 12 (1538 views)
Permalink

Re: [dev] GenericSetup: using global steps [In reply to]

yuppie wrote:
> GenericSetup trunk has global step registries. I propose to use the new
> ZCML directive for registering all GenericSetup and CMF import and
> export steps globally. And to remove the import_steps.xml and
> export_steps.xml files from the profiles shipped with CMF.
>
> This also requires to add a flag file for the 'various' step.
>
> I already started implementing this. If there are no objections, I'll
> soon check in my changes.

+1

Hanno

_______________________________________________
Zope-CMF maillist - Zope-CMF [at] lists
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

wichert at wiggy

Dec 19, 2007, 5:01 PM

Post #3 of 12 (1535 views)
Permalink

Re: [dev] GenericSetup: using global steps [In reply to]

Previously yuppie wrote:
> GenericSetup trunk has global step registries. I propose to use the new
> ZCML directive for registering all GenericSetup and CMF import and
> export steps globally. And to remove the import_steps.xml and
> export_steps.xml files from the profiles shipped with CMF.
>
> This also requires to add a flag file for the 'various' step.
>
> I already started implementing this. If there are no objections, I'll
> soon check in my changes.

+1

there is one thing missing at the moment: unregistering the old
profile-registered steps. I'm not sure what the right way to do that is.

Wichert.

--
Wichert Akkerman <wichert [at] wiggy> It is simple to make things.
http://www.wiggy.net/ It is hard to make things simple.
_______________________________________________
Zope-CMF maillist - Zope-CMF [at] lists
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

y.2007- at wcm-solutions

Dec 20, 2007, 3:37 AM

Post #4 of 12 (1535 views)
Permalink

Re: [dev] GenericSetup: using global steps [In reply to]

Hi!

Wichert Akkerman wrote:
> Previously yuppie wrote:
>> GenericSetup trunk has global step registries. I propose to use the new
>> ZCML directive for registering all GenericSetup and CMF import and
>> export steps globally. And to remove the import_steps.xml and
>> export_steps.xml files from the profiles shipped with CMF.
>>
>> This also requires to add a flag file for the 'various' step.
>>
>> I already started implementing this. If there are no objections, I'll
>> soon check in my changes.
>
> +1
>
> there is one thing missing at the moment: unregistering the old
> profile-registered steps. I'm not sure what the right way to do that is.

listExportSteps() and getSortedImportSteps() now have unit tests and no
longer return duplicates. AFAICS we now have a clean override behavior
and nothing breaks if the same step is registered locally *and* globally.

But I agree there should be a way to remove obsolete and broken local
steps. A method that removes local duplicates of global steps and a
method that removes broken steps would be useful. Not sure if they
should be run automatically or if there should be a cleanup button in
the UI.

Cheers,

Yuppie

_______________________________________________
Zope-CMF maillist - Zope-CMF [at] lists
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

m.van.rees at zestsoftware

Dec 21, 2007, 1:39 AM

Post #5 of 12 (1531 views)
Permalink

Re: [dev] GenericSetup: using global steps [In reply to]

yuppie, on 2007-12-20:
> Hi!
>
>
> Wichert Akkerman wrote:
>> Previously yuppie wrote:
>>> GenericSetup trunk has global step registries. I propose to use the new
>>> ZCML directive for registering all GenericSetup and CMF import and
>>> export steps globally. And to remove the import_steps.xml and
>>> export_steps.xml files from the profiles shipped with CMF.
>>>
>>> This also requires to add a flag file for the 'various' step.
>>>
>>> I already started implementing this. If there are no objections, I'll
>>> soon check in my changes.
>>
>> +1
>>
>> there is one thing missing at the moment: unregistering the old
>> profile-registered steps. I'm not sure what the right way to do that is.
>
> listExportSteps() and getSortedImportSteps() now have unit tests and no
> longer return duplicates. AFAICS we now have a clean override behavior
> and nothing breaks if the same step is registered locally *and* globally.
>
> But I agree there should be a way to remove obsolete and broken local
> steps. A method that removes local duplicates of global steps and a
> method that removes broken steps would be useful. Not sure if they
> should be run automatically or if there should be a cleanup button in
> the UI.

You probably know perfectly well how to do this, but for the record,
here is some installer code from a client project where we remove an
obsolete import step.

registry = setup.getImportStepRegistry()
if u'lumberjack' in registry.listSteps():
print >> out, "Found stale lumberjack import step, removing it."
registry._registered.pop(u'lumberjack')
temp = registry._registered
registry._registered = temp
del temp
print >> out, "Removed stale lumberjack import step."

--
Maurits van Rees | http://maurits.vanrees.org/
Work | http://zestsoftware.nl/
"From an eekhoorn grows an oak." [semi-Dutch proverb]

_______________________________________________
Zope-CMF maillist - Zope-CMF [at] lists
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

wichert at wiggy

Dec 21, 2007, 3:28 AM

Post #6 of 12 (1536 views)
Permalink

Re: Re: [dev] GenericSetup: using global steps [In reply to]

Previously yuppie wrote:
> Hi!
>
>
> Wichert Akkerman wrote:
> >Previously yuppie wrote:
> >>GenericSetup trunk has global step registries. I propose to use the new
> >>ZCML directive for registering all GenericSetup and CMF import and
> >>export steps globally. And to remove the import_steps.xml and
> >>export_steps.xml files from the profiles shipped with CMF.
> >>
> >>This also requires to add a flag file for the 'various' step.
> >>
> >>I already started implementing this. If there are no objections, I'll
> >>soon check in my changes.
> >
> >+1
> >
> >there is one thing missing at the moment: unregistering the old
> >profile-registered steps. I'm not sure what the right way to do that is.
>
> listExportSteps() and getSortedImportSteps() now have unit tests and no
> longer return duplicates. AFAICS we now have a clean override behavior
> and nothing breaks if the same step is registered locally *and* globally.

Great, thanks for doing that.

> But I agree there should be a way to remove obsolete and broken local
> steps. A method that removes local duplicates of global steps and a
> method that removes broken steps would be useful. Not sure if they
> should be run automatically or if there should be a cleanup button in
> the UI.

I would prefer manually: otherwise we risk breaking things if someone
tries a newer version of a product and then downgrades and suddenly
looses the step registrations. I will see if I can make a ZMI page for
that over the next week.

Wichert.

--
Wichert Akkerman <wichert [at] wiggy> It is simple to make things.
http://www.wiggy.net/ It is hard to make things simple.
_______________________________________________
Zope-CMF maillist - Zope-CMF [at] lists
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

charlie at begeistert

Dec 21, 2007, 4:17 AM

Post #7 of 12 (1528 views)
Permalink

Re: [dev] GenericSetup: using global steps [In reply to]

Am 19.12.2007 um 21:53 schrieb yuppie:

> GenericSetup trunk has global step registries. I propose to use the
> new ZCML directive for registering all GenericSetup and CMF import
> and export steps globally. And to remove the import_steps.xml and
> export_steps.xml files from the profiles shipped with CMF.

Sounds good to me although I'm not 100% sure if I understand the
implications. I've never worked with import & export: don't they just
produce pickles. I have recently had the need to replace existing
profiles and it would seem logical to me to be able to do this from
ZCML assuming the XML for the properties is correct - I've noticed
that this does not get checked when starting Zope.

Charlie
--
Charlie Clark
Helmholtzstr. 20
D�sseldorf
D- 40215
Tel: +49-211-938-5360
GSM: +49-178-782-6226

_______________________________________________
Zope-CMF maillist - Zope-CMF [at] lists
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

y.2007- at wcm-solutions

Dec 22, 2007, 6:09 AM

Post #8 of 12 (1528 views)
Permalink

Re: [dev] GenericSetup: using global steps [In reply to]

yuppie wrote:
> GenericSetup trunk has global step registries. I propose to use the new
> ZCML directive for registering all GenericSetup and CMF import and
> export steps globally. And to remove the import_steps.xml and
> export_steps.xml files from the profiles shipped with CMF.
>
> This also requires to add a flag file for the 'various' step.
>
> I already started implementing this. If there are no objections, I'll
> soon check in my changes.

Done.

Not sure what to do with the 'content' steps: The 'content' export step
is the only one I would not like to run by default. A content snapshot
might be quite expensive.

For now the 'content' steps still must be registered locally or in
custom ZCML.

Yuppie

_______________________________________________
Zope-CMF maillist - Zope-CMF [at] lists
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

tseaver at palladion

Dec 22, 2007, 10:09 AM

Post #9 of 12 (1521 views)
Permalink

Re: [dev] GenericSetup: using global steps [In reply to]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

yuppie wrote:
> yuppie wrote:
>> GenericSetup trunk has global step registries. I propose to use the new
>> ZCML directive for registering all GenericSetup and CMF import and
>> export steps globally. And to remove the import_steps.xml and
>> export_steps.xml files from the profiles shipped with CMF.
>>
>> This also requires to add a flag file for the 'various' step.
>>
>> I already started implementing this. If there are no objections, I'll
>> soon check in my changes.
>
> Done.
>
> Not sure what to do with the 'content' steps: The 'content' export step
> is the only one I would not like to run by default. A content snapshot
> might be quite expensive.

Worse, an import is potentially destructive. I am now of the opinion
that content import / export should be treated as a separate
application, not built into the profile.

> For now the 'content' steps still must be registered locally or in
> custom ZCML.

Tres.
- --
===================================================================
Tres Seaver +1 540-429-0999 tseaver [at] palladion
Palladion Software "Excellence by Design" http://palladion.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHbVLF+gerLs4ltQ4RAqKWAKCUD/EcpzrssBj+16aOELEdr6ECbACgvDtV
Qcus85UPVTKl9aZ1mPmASDw=
=5p1T
-----END PGP SIGNATURE-----

_______________________________________________
Zope-CMF maillist - Zope-CMF [at] lists
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

tseaver at palladion

Dec 22, 2007, 10:09 AM

Post #10 of 12 (1528 views)
Permalink

Re: [dev] GenericSetup: using global steps [In reply to]

optilude at gmx

Dec 22, 2007, 12:04 PM

Post #11 of 12 (1522 views)
Permalink

Re: [dev] GenericSetup: using global steps [In reply to]

Tres Seaver wrote:

> Worse, an import is potentially destructive. I am now of the opinion
> that content import / export should be treated as a separate
> application, not built into the profile.

From a design perspective, I'd tend to agree. I've always felt that the
'structure' import step sat a bit awkwardly with the rest of GS.

That said, there are grey bits. For example, I'm working on a Plone
enhancement to make it possible to manage portlet setup (assignment) via
GenericSetup. That's easy enough for "global" portlets, but some
portlets may be assigned to specific folders. Both export and import are
tricky here.

Martin

--
Author of `Professional Plone Development`, a book for developers who
want to work with Plone. See http://martinaspeli.net/plone-book

_______________________________________________
Zope-CMF maillist - Zope-CMF [at] lists
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

wichert at wiggy

Dec 28, 2007, 3:02 AM

Post #12 of 12 (1506 views)
Permalink

Re: Re: [dev] GenericSetup: using global steps [In reply to]

Previously Wichert Akkerman wrote:
> Previously yuppie wrote:
> > But I agree there should be a way to remove obsolete and broken local
> > steps. A method that removes local duplicates of global steps and a
> > method that removes broken steps would be useful. Not sure if they
> > should be run automatically or if there should be a cleanup button in
> > the UI.
>
> I would prefer manually: otherwise we risk breaking things if someone
> tries a newer version of a product and then downgrades and suddenly
> looses the step registrations. I will see if I can make a ZMI page for
> that over the next week.

I just commited that to trunk.

Wichert.

--
Wichert Akkerman <wichert [at] wiggy> It is simple to make things.
http://www.wiggy.net/ It is hard to make things simple.
_______________________________________________
Zope-CMF maillist - Zope-CMF [at] lists
http://mail.zope.org/mailman/listinfo/zope-cmf

See http://collector.zope.org/CMF for bug reports and feature requests

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads