Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Xen: Devel

[PATCH] rename some xsenstore library functions

 

 

Xen devel RSS feed   Index | Next | Previous | View Threaded


aquynh at gmail

Jun 10, 2005, 6:01 AM

Post #1 of 3 (31 views)
Permalink
[PATCH] rename some xsenstore library functions

Some functions of xenstore library dont have xs_ as prefix. This patch
fixes the problem.

Signed-off-by: Nguyen Anh Quynh <aquynh [at] gmail>

# diffstat xenstore3.patch
fake_libxc.c | 2 +-
xenstored_core.c | 18 +++++++++---------
xenstored_test.h | 2 +-
xs.c | 14 +++++++-------
xs_lib.c | 8 ++++----
xs_lib.h | 8 ++++----
xs_random.c | 8 ++++----
xs_test.c | 4 ++--
8 files changed, 32 insertions(+), 32 deletions(-)
Attachments: xenstore3.patch (8.76 KB)


rusty at rustcorp

Jun 11, 2005, 11:39 PM

Post #2 of 3 (31 views)
Permalink
Re: [PATCH] rename some xsenstore library functions [In reply to]

On Fri, 2005-06-10 at 08:01 -0500, aq wrote:
> Some functions of xenstore library dont have xs_ as prefix. This patch
> fixes the problem.

But it's not a problem, actually. Only public functions need to start
with xs_.

Please don't apply this patch.
Rusty.
--
A bad analogy is like a leaky screwdriver -- Richard Braakman


_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xensource.com/xen-devel


aquynh at gmail

Jun 12, 2005, 8:13 AM

Post #3 of 3 (29 views)
Permalink
Re: [PATCH] rename some xsenstore library functions [In reply to]

On 6/12/05, Rusty Russell <rusty [at] rustcorp> wrote:
> On Fri, 2005-06-10 at 08:01 -0500, aq wrote:
> > Some functions of xenstore library dont have xs_ as prefix. This patch
> > fixes the problem.
>
> But it's not a problem, actually. Only public functions need to start
> with xs_.

i see the point, but the reason of this patch is that i am worried
that the code (which uses this lib) might accidentally has a conflict
function.

otherwise it is OK.

regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xensource.com/xen-devel

Xen devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.