Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Xen: Devel

[PATCH 4/7] Nested VMX: Add interface to update vPPR

 

 

Xen devel RSS feed   Index | Next | Previous | View Threaded


yang.z.zhang at intel

Aug 9, 2013, 1:49 AM

Post #1 of 4 (15 views)
Permalink
[PATCH 4/7] Nested VMX: Add interface to update vPPR

From: Yang Zhang <yang.z.zhang [at] Intel>

Add vlapic_set_ppr() to allow update vPPR which in virtual apic page.

Signed-off-by: Yang Zhang <yang.z.zhang [at] Intel>
---
xen/arch/x86/hvm/vlapic.c | 8 ++++++++
xen/include/asm-x86/hvm/vlapic.h | 1 +
2 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
index f2594dd..caab9ea 100644
--- a/xen/arch/x86/hvm/vlapic.c
+++ b/xen/arch/x86/hvm/vlapic.c
@@ -168,6 +168,14 @@ static uint32_t vlapic_get_ppr(struct vlapic *vlapic)
return ppr;
}

+uint32_t vlapic_set_ppr(struct vlapic *vlapic)
+{
+ uint32_t ppr = vlapic_get_ppr(vlapic);
+ vlapic_set_reg(vlapic, APIC_PROCPRI, ppr);
+
+ return ppr;
+}
+
static int vlapic_match_logical_addr(struct vlapic *vlapic, uint8_t mda)
{
int result = 0;
diff --git a/xen/include/asm-x86/hvm/vlapic.h b/xen/include/asm-x86/hvm/vlapic.h
index d8c9511..6109137 100644
--- a/xen/include/asm-x86/hvm/vlapic.h
+++ b/xen/include/asm-x86/hvm/vlapic.h
@@ -108,6 +108,7 @@ void vlapic_tdt_msr_set(struct vlapic *vlapic, uint64_t value);
uint64_t vlapic_tdt_msr_get(struct vlapic *vlapic);

int vlapic_accept_pic_intr(struct vcpu *v);
+uint32_t vlapic_set_ppr(struct vlapic *vlapic);

void vlapic_adjust_i8259_target(struct domain *d);

--
1.7.1


_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


andrew.cooper3 at citrix

Aug 9, 2013, 3:42 AM

Post #2 of 4 (13 views)
Permalink
Re: [PATCH 4/7] Nested VMX: Add interface to update vPPR [In reply to]

On 09/08/13 09:49, Yang Zhang wrote:
> From: Yang Zhang <yang.z.zhang [at] Intel>
>
> Add vlapic_set_ppr() to allow update vPPR which in virtual apic page.
>
> Signed-off-by: Yang Zhang <yang.z.zhang [at] Intel>

Reviewed-by: Andrew Cooper <andrew.cooper3 [at] citrix>

> ---
> xen/arch/x86/hvm/vlapic.c | 8 ++++++++
> xen/include/asm-x86/hvm/vlapic.h | 1 +
> 2 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/xen/arch/x86/hvm/vlapic.c b/xen/arch/x86/hvm/vlapic.c
> index f2594dd..caab9ea 100644
> --- a/xen/arch/x86/hvm/vlapic.c
> +++ b/xen/arch/x86/hvm/vlapic.c
> @@ -168,6 +168,14 @@ static uint32_t vlapic_get_ppr(struct vlapic *vlapic)
> return ppr;
> }
>
> +uint32_t vlapic_set_ppr(struct vlapic *vlapic)
> +{
> + uint32_t ppr = vlapic_get_ppr(vlapic);
> + vlapic_set_reg(vlapic, APIC_PROCPRI, ppr);
> +
> + return ppr;
> +}
> +
> static int vlapic_match_logical_addr(struct vlapic *vlapic, uint8_t mda)
> {
> int result = 0;
> diff --git a/xen/include/asm-x86/hvm/vlapic.h b/xen/include/asm-x86/hvm/vlapic.h
> index d8c9511..6109137 100644
> --- a/xen/include/asm-x86/hvm/vlapic.h
> +++ b/xen/include/asm-x86/hvm/vlapic.h
> @@ -108,6 +108,7 @@ void vlapic_tdt_msr_set(struct vlapic *vlapic, uint64_t value);
> uint64_t vlapic_tdt_msr_get(struct vlapic *vlapic);
>
> int vlapic_accept_pic_intr(struct vcpu *v);
> +uint32_t vlapic_set_ppr(struct vlapic *vlapic);
>
> void vlapic_adjust_i8259_target(struct domain *d);
>


_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


JBeulich at suse

Aug 9, 2013, 5:14 AM

Post #3 of 4 (11 views)
Permalink
Re: [PATCH 4/7] Nested VMX: Add interface to update vPPR [In reply to]

>>> On 09.08.13 at 10:49, Yang Zhang <yang.z.zhang [at] intel> wrote:
> From: Yang Zhang <yang.z.zhang [at] Intel>
>
> Add vlapic_set_ppr() to allow update vPPR which in virtual apic page.

Again, missing the consumer of this new function.

> +uint32_t vlapic_set_ppr(struct vlapic *vlapic)
> +{
> + uint32_t ppr = vlapic_get_ppr(vlapic);
> + vlapic_set_reg(vlapic, APIC_PROCPRI, ppr);

Blank line needed between variable declarations and first
statement.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


yang.z.zhang at intel

Aug 10, 2013, 7:50 PM

Post #4 of 4 (10 views)
Permalink
Re: [PATCH 4/7] Nested VMX: Add interface to update vPPR [In reply to]

Jan Beulich wrote on 2013-08-09:
>>>> On 09.08.13 at 10:49, Yang Zhang <yang.z.zhang [at] intel> wrote:
>> From: Yang Zhang <yang.z.zhang [at] Intel>
>>
>> Add vlapic_set_ppr() to allow update vPPR which in virtual apic page.
>
> Again, missing the consumer of this new function.
It is used in patch 6. I will mention it in comments.

>
>> +uint32_t vlapic_set_ppr(struct vlapic *vlapic) {
>> + uint32_t ppr = vlapic_get_ppr(vlapic);
>> + vlapic_set_reg(vlapic, APIC_PROCPRI, ppr);
>
> Blank line needed between variable declarations and first statement.
Sure.

>
> Jan


Best regards,
Yang



_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel

Xen devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.