Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Xen: Devel

[PATCH 01/11] xen/p2m: Fix the comment describing the P2M tree.

 

 

Xen devel RSS feed   Index | Next | Previous | View Threaded


konrad.wilk at oracle

Aug 16, 2012, 9:03 AM

Post #1 of 2 (106 views)
Permalink
[PATCH 01/11] xen/p2m: Fix the comment describing the P2M tree.

It mixed up the p2m_mid_missing with p2m_missing. Also
remove some extra spaces.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk [at] oracle>
---
arch/x86/xen/p2m.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
index 64effdc..e4adbfb 100644
--- a/arch/x86/xen/p2m.c
+++ b/arch/x86/xen/p2m.c
@@ -22,7 +22,7 @@
*
* P2M_PER_PAGE depends on the architecture, as a mfn is always
* unsigned long (8 bytes on 64-bit, 4 bytes on 32), leading to
- * 512 and 1024 entries respectively.
+ * 512 and 1024 entries respectively.
*
* In short, these structures contain the Machine Frame Number (MFN) of the PFN.
*
@@ -139,11 +139,11 @@
* / | ~0, ~0, .... |
* | \---------------/
* |
- * p2m_missing p2m_missing
- * /------------------\ /------------\
- * | [p2m_mid_missing]+---->| ~0, ~0, ~0 |
- * | [p2m_mid_missing]+---->| ..., ~0 |
- * \------------------/ \------------/
+ * p2m_mid_missing p2m_missing
+ * /-----------------\ /------------\
+ * | [p2m_missing] +---->| ~0, ~0, ~0 |
+ * | [p2m_missing] +---->| ..., ~0 |
+ * \-----------------/ \------------/
*
* where ~0 is INVALID_P2M_ENTRY. IDENTITY is (PFN | IDENTITY_BIT)
*/
@@ -423,7 +423,7 @@ static void free_p2m_page(void *p)
free_page((unsigned long)p);
}

-/*
+/*
* Fully allocate the p2m structure for a given pfn. We need to check
* that both the top and mid levels are allocated, and make sure the
* parallel mfn tree is kept in sync. We may race with other cpus, so
--
1.7.7.6


_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


stefano.stabellini at eu

Aug 17, 2012, 10:29 AM

Post #2 of 2 (103 views)
Permalink
Re: [PATCH 01/11] xen/p2m: Fix the comment describing the P2M tree. [In reply to]

On Thu, 16 Aug 2012, Konrad Rzeszutek Wilk wrote:
> It mixed up the p2m_mid_missing with p2m_missing. Also
> remove some extra spaces.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk [at] oracle>


Acked-by: Stefano Stabellini <stefano.stabellini [at] eu>

> arch/x86/xen/p2m.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/x86/xen/p2m.c b/arch/x86/xen/p2m.c
> index 64effdc..e4adbfb 100644
> --- a/arch/x86/xen/p2m.c
> +++ b/arch/x86/xen/p2m.c
> @@ -22,7 +22,7 @@
> *
> * P2M_PER_PAGE depends on the architecture, as a mfn is always
> * unsigned long (8 bytes on 64-bit, 4 bytes on 32), leading to
> - * 512 and 1024 entries respectively.
> + * 512 and 1024 entries respectively.
> *
> * In short, these structures contain the Machine Frame Number (MFN) of the PFN.
> *
> @@ -139,11 +139,11 @@
> * / | ~0, ~0, .... |
> * | \---------------/
> * |
> - * p2m_missing p2m_missing
> - * /------------------\ /------------\
> - * | [p2m_mid_missing]+---->| ~0, ~0, ~0 |
> - * | [p2m_mid_missing]+---->| ..., ~0 |
> - * \------------------/ \------------/
> + * p2m_mid_missing p2m_missing
> + * /-----------------\ /------------\
> + * | [p2m_missing] +---->| ~0, ~0, ~0 |
> + * | [p2m_missing] +---->| ..., ~0 |
> + * \-----------------/ \------------/
> *
> * where ~0 is INVALID_P2M_ENTRY. IDENTITY is (PFN | IDENTITY_BIT)
> */
> @@ -423,7 +423,7 @@ static void free_p2m_page(void *p)
> free_page((unsigned long)p);
> }
>
> -/*
> +/*
> * Fully allocate the p2m structure for a given pfn. We need to check
> * that both the top and mid levels are allocated, and make sure the
> * parallel mfn tree is kept in sync. We may race with other cpus, so
> --
> 1.7.7.6
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel [at] lists
> http://lists.xen.org/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel

Xen devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.