Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Xen: Devel

[PATCH 0/2] Document pagetable_reserve PVOP and enforce a better semantic

 

 

Xen devel RSS feed   Index | Next | Previous | View Threaded


attilio.rao at citrix

Aug 10, 2012, 7:17 AM

Post #1 of 2 (73 views)
Permalink
[PATCH 0/2] Document pagetable_reserve PVOP and enforce a better semantic

When looking for documenting the pagetable_reserve PVOP, I realized that it
assumes start == pgt_buf_start. I think this is not semantically right
(even if with the current code this should not be a problem in practice) and
what we really want is to extend the logic in order to do the RO -> RW
convertion also for the range [pgt_buf_start, start).
This patch then implements this missing conversion, adding some smaller
cleanups and finally provides documentation for the PVOP.
Please look at 2/2 for more details on how the comment is structured.
If we get this right we will have a reference to be used later on for others
PVOPs.
A preliminary version of this patch has been already reviewed by
Stefano Stabellini.

Attilio Rao (2):
XEN, X86: Improve semantic support for pagetable_reserve PVOP
Document the semantic of the pagetable_reserve PVOP

arch/x86/include/asm/x86_init.h | 19 +++++++++++++++++--
arch/x86/mm/init.c | 4 ++++
arch/x86/xen/mmu.c | 22 ++++++++++++++++++++--
3 files changed, 41 insertions(+), 4 deletions(-)

--
1.7.2.5


_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


konrad.wilk at oracle

Aug 13, 2012, 1:42 PM

Post #2 of 2 (65 views)
Permalink
Re: [PATCH 0/2] Document pagetable_reserve PVOP and enforce a better semantic [In reply to]

On Fri, Aug 10, 2012 at 03:17:05PM +0100, Attilio Rao wrote:
> When looking for documenting the pagetable_reserve PVOP, I realized that it
> assumes start == pgt_buf_start. I think this is not semantically right
> (even if with the current code this should not be a problem in practice) and
> what we really want is to extend the logic in order to do the RO -> RW
> convertion also for the range [pgt_buf_start, start).
> This patch then implements this missing conversion, adding some smaller
> cleanups and finally provides documentation for the PVOP.
> Please look at 2/2 for more details on how the comment is structured.
> If we get this right we will have a reference to be used later on for others
> PVOPs.
> A preliminary version of this patch has been already reviewed by
> Stefano Stabellini.
>
> Attilio Rao (2):
> XEN, X86: Improve semantic support for pagetable_reserve PVOP
> Document the semantic of the pagetable_reserve PVOP

The titles need a prefix, like 'x86' or 'xen/x86'.

s/PVOP/PVOPS/

>
> arch/x86/include/asm/x86_init.h | 19 +++++++++++++++++--
> arch/x86/mm/init.c | 4 ++++
> arch/x86/xen/mmu.c | 22 ++++++++++++++++++++--
> 3 files changed, 41 insertions(+), 4 deletions(-)
>
> --
> 1.7.2.5

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel

Xen devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.