Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Xen: Devel

[PATCH 20/24] xen: update xen_add_to_physmap interface

 

 

Xen devel RSS feed   Index | Next | Previous | View Threaded


stefano.stabellini at eu

Jul 26, 2012, 8:34 AM

Post #1 of 4 (161 views)
Permalink
[PATCH 20/24] xen: update xen_add_to_physmap interface

Update struct xen_add_to_physmap to be in sync with Xen's version of the
structure.
The size field was introduced by:

changeset: 24164:707d27fe03e7
user: Jean Guyader <jean.guyader [at] eu>
date: Fri Nov 18 13:42:08 2011 +0000
summary: mm: New XENMEM space, XENMAPSPACE_gmfn_range

According to the comment:

"This new field .size is located in the 16 bits padding between .domid
and .space in struct xen_add_to_physmap to stay compatible with older
versions."

This is not true on ARM where there is not padding, but it is valid on
X86, so introducing size is safe on X86 and it is going to fix the
interace for ARM.

Signed-off-by: Stefano Stabellini <stefano.stabellini [at] eu>
---
include/xen/interface/memory.h | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/include/xen/interface/memory.h b/include/xen/interface/memory.h
index abbbff0..d8e33a9 100644
--- a/include/xen/interface/memory.h
+++ b/include/xen/interface/memory.h
@@ -163,6 +163,9 @@ struct xen_add_to_physmap {
/* Which domain to change the mapping for. */
domid_t domid;

+ /* Number of pages to go through for gmfn_range */
+ uint16_t size;
+
/* Source mapping space. */
#define XENMAPSPACE_shared_info 0 /* shared info page */
#define XENMAPSPACE_grant_table 1 /* grant table page */
--
1.7.2.5


_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


konrad.wilk at oracle

Aug 1, 2012, 7:52 AM

Post #2 of 4 (157 views)
Permalink
Re: [PATCH 20/24] xen: update xen_add_to_physmap interface [In reply to]

On Thu, Jul 26, 2012 at 04:34:02PM +0100, Stefano Stabellini wrote:
> Update struct xen_add_to_physmap to be in sync with Xen's version of the
> structure.
> The size field was introduced by:
>
> changeset: 24164:707d27fe03e7
> user: Jean Guyader <jean.guyader [at] eu>
> date: Fri Nov 18 13:42:08 2011 +0000
> summary: mm: New XENMEM space, XENMAPSPACE_gmfn_range
>
> According to the comment:
>
> "This new field .size is located in the 16 bits padding between .domid
> and .space in struct xen_add_to_physmap to stay compatible with older
> versions."
>
> This is not true on ARM where there is not padding, but it is valid on
> X86, so introducing size is safe on X86 and it is going to fix the
> interace for ARM.

Has this been checked actually for backwards compatibility? It sounds
like it should work just fine with Xen 4.0 right?

I believe this also helps Mukesh's patches, so CC-ing him here for
his Ack.

I can put this in right now in tree if we are 100% sure its compatiblie with 4.0.

>
> Signed-off-by: Stefano Stabellini <stefano.stabellini [at] eu>
> ---
> include/xen/interface/memory.h | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/include/xen/interface/memory.h b/include/xen/interface/memory.h
> index abbbff0..d8e33a9 100644
> --- a/include/xen/interface/memory.h
> +++ b/include/xen/interface/memory.h
> @@ -163,6 +163,9 @@ struct xen_add_to_physmap {
> /* Which domain to change the mapping for. */
> domid_t domid;
>
> + /* Number of pages to go through for gmfn_range */
> + uint16_t size;
> +
> /* Source mapping space. */
> #define XENMAPSPACE_shared_info 0 /* shared info page */
> #define XENMAPSPACE_grant_table 1 /* grant table page */
> --
> 1.7.2.5

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


stefano.stabellini at eu

Aug 1, 2012, 9:18 AM

Post #3 of 4 (158 views)
Permalink
Re: [PATCH 20/24] xen: update xen_add_to_physmap interface [In reply to]

On Wed, 1 Aug 2012, Konrad Rzeszutek Wilk wrote:
> On Thu, Jul 26, 2012 at 04:34:02PM +0100, Stefano Stabellini wrote:
> > Update struct xen_add_to_physmap to be in sync with Xen's version of the
> > structure.
> > The size field was introduced by:
> >
> > changeset: 24164:707d27fe03e7
> > user: Jean Guyader <jean.guyader [at] eu>
> > date: Fri Nov 18 13:42:08 2011 +0000
> > summary: mm: New XENMEM space, XENMAPSPACE_gmfn_range
> >
> > According to the comment:
> >
> > "This new field .size is located in the 16 bits padding between .domid
> > and .space in struct xen_add_to_physmap to stay compatible with older
> > versions."
> >
> > This is not true on ARM where there is not padding, but it is valid on
> > X86, so introducing size is safe on X86 and it is going to fix the
> > interace for ARM.
>
> Has this been checked actually for backwards compatibility? It sounds
> like it should work just fine with Xen 4.0 right?
>
> I believe this also helps Mukesh's patches, so CC-ing him here for
> his Ack.
>
> I can put this in right now in tree if we are 100% sure its compatiblie with 4.0.

Yes, it is: 4 bytes integers are 4-byte aligned on 32 bit and 64 bit
on x86.

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


mukesh.rathor at oracle

Aug 1, 2012, 11:19 AM

Post #4 of 4 (157 views)
Permalink
Re: [PATCH 20/24] xen: update xen_add_to_physmap interface [In reply to]

On Wed, 1 Aug 2012 10:52:15 -0400
Konrad Rzeszutek Wilk <konrad.wilk [at] oracle> wrote:

> On Thu, Jul 26, 2012 at 04:34:02PM +0100, Stefano Stabellini wrote:
> > Update struct xen_add_to_physmap to be in sync with Xen's version
> > of the structure.
> > The size field was introduced by:
> >
> > changeset: 24164:707d27fe03e7
> > user: Jean Guyader <jean.guyader [at] eu>
> > date: Fri Nov 18 13:42:08 2011 +0000
> > summary: mm: New XENMEM space, XENMAPSPACE_gmfn_range
> >
> > According to the comment:
> >
> > "This new field .size is located in the 16 bits padding
> > between .domid and .space in struct xen_add_to_physmap to stay
> > compatible with older versions."
> >
> > This is not true on ARM where there is not padding, but it is valid
> > on X86, so introducing size is safe on X86 and it is going to fix
> > the interace for ARM.
>
> Has this been checked actually for backwards compatibility? It sounds
> like it should work just fine with Xen 4.0 right?
>
> I believe this also helps Mukesh's patches, so CC-ing him here for
> his Ack.

Yup, I already had that change in my tree.

thanks,
Mukesh



_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel

Xen devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.