Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Xen: Devel

[PATCH] xl: Clarify 'xend is running' error message

 

 

Xen devel RSS feed   Index | Next | Previous | View Threaded


george.dunlap at eu

Jun 21, 2012, 6:31 AM

Post #1 of 2 (62 views)
Permalink
[PATCH] xl: Clarify 'xend is running' error message

# HG changeset patch
# User George Dunlap <george.dunlap [at] eu>
# Date 1340285415 -3600
# Node ID 849fe346b05a3265894e6ce16292f81def92fce7
# Parent baa85434d0ec16629ca30b7c07deaa9beb3ea9c5
xl: Clarify 'xend is running' error message

* Give reason for check (unpredictable results)
* Give a better recommendation (shut down xend)
* Make it clear that -f is overriding a safety check.

Signed-off-by: George Dunlap <george.dunlap [at] eu>

diff --git a/tools/libxl/xl.c b/tools/libxl/xl.c
--- a/tools/libxl/xl.c
+++ b/tools/libxl/xl.c
@@ -251,9 +251,9 @@ int main(int argc, char **argv)
for (int i = 0; i < sizeof(locks)/sizeof(locks[0]); i++) {
if (!access(locks[i], F_OK) && !force_execution) {
fprintf(stderr,
-"xend is running, which prevents xl from working correctly.\n"
-"If you still want to force the execution of xl please use the -f\n"
-"option.\n"
+"xend is running, which may cause unpredictable results when using\n"
+"this xl command. Please shut down xend before continuing.\n\n"
+"(This check can be overridden with the -f option.)\n"
);
ret = 1;
goto xit;

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


Ian.Jackson at eu

Jun 29, 2012, 9:37 AM

Post #2 of 2 (42 views)
Permalink
Re: [PATCH] xl: Clarify 'xend is running' error message [In reply to]

George Dunlap writes ("[Xen-devel] [PATCH] xl: Clarify 'xend is running' error message"):
> xl: Clarify 'xend is running' error message

Acked-by: Ian Jackson <ian.jackson [at] eu>
Committed-by: Ian Jackson <ian.jackson [at] eu>

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel

Xen devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.