Mailing List Archive: Xen: Devel

[PATCH] docs/xen-headers: allow headers to be symlinks

Index | Next | Previous | View Threaded

JBeulich at suse

Jun 21, 2012, 5:20 AM

Post #1 of 3 (75 views)
Permalink

[PATCH] docs/xen-headers: allow headers to be symlinks

There's no apparent reason not to permit this, and since we don't
support out-of-source-tree builds, the least overhead way of doing
multiple, differently configured (perhaps different architecture)
builds from a single source tree is to create symlinked build trees.

Signed-off-by: Jan Beulich <jbeulich [at] suse>

--- a/docs/xen-headers
+++ b/docs/xen-headers
@@ -368,7 +368,7 @@ foreach $pass (qw(1 2)) {
find({ wanted =>
sub {
return unless m/\.h$/;
- lstat $File::Find::name or die "$File::Find::name $!";
+ stat $File::Find::name or die "$File::Find::name $!";
-f _ or die "$File::Find::name";
substr($File::Find::name, 0, 1+length $basedir)
eq "$basedir/"

Attachments:

docs-xen-header-symlink.patch (0.83 KB)

Ian.Campbell at citrix

Jun 26, 2012, 9:28 AM

Post #2 of 3 (66 views)
Permalink

Re: [PATCH] docs/xen-headers: allow headers to be symlinks [In reply to]

On Thu, 2012-06-21 at 13:20 +0100, Jan Beulich wrote:
> There's no apparent reason not to permit this, and since we don't
> support out-of-source-tree builds, the least overhead way of doing
> multiple, differently configured (perhaps different architecture)
> builds from a single source tree is to create symlinked build trees.
>
> Signed-off-by: Jan Beulich <jbeulich [at] suse>

Seems reasonable and applying the patch resulted in no change in the
output on this end:

Acked-by: Ian Campbell <ian.campbell [at] citrix>

>
> --- a/docs/xen-headers
> +++ b/docs/xen-headers
> @@ -368,7 +368,7 @@ foreach $pass (qw(1 2)) {
> find({ wanted =>
> sub {
> return unless m/\.h$/;
> - lstat $File::Find::name or die "$File::Find::name $!";
> + stat $File::Find::name or die "$File::Find::name $!";
> -f _ or die "$File::Find::name";
> substr($File::Find::name, 0, 1+length $basedir)
> eq "$basedir/"
>
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel

Ian.Jackson at eu

Jun 29, 2012, 9:35 AM

Post #3 of 3 (62 views)
Permalink

Re: [PATCH] docs/xen-headers: allow headers to be symlinks [In reply to]

Ian Campbell writes ("Re: [Xen-devel] [PATCH] docs/xen-headers: allow headers to be symlinks"):
> On Thu, 2012-06-21 at 13:20 +0100, Jan Beulich wrote:
> > There's no apparent reason not to permit this, and since we don't
> > support out-of-source-tree builds, the least overhead way of doing
> > multiple, differently configured (perhaps different architecture)
> > builds from a single source tree is to create symlinked build trees.
> >
> > Signed-off-by: Jan Beulich <jbeulich [at] suse>
>
> Seems reasonable and applying the patch resulted in no change in the
> output on this end:
>
> Acked-by: Ian Campbell <ian.campbell [at] citrix>

Indeed, this is correct. I see it's been applied.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads