Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Xen: Devel
Re: Workings/effectiveness of the xen-acpi-processor driver
 

Index | Next | Previous | View Flat


konrad at darnok

May 3, 2012, 8:46 AM


Views: 332
Permalink
Re: Workings/effectiveness of the xen-acpi-processor driver [In reply to]

On Thu, May 03, 2012 at 04:47:46PM +0200, Stefan Bader wrote:
> On 03.05.2012 14:58, Stefan Bader wrote:
>
> >>>>> So this shoudl solve the problem for the bootup processor.
> >>>>>>
> >>>>>> -boris
> >>>>>>
> >>>>>>
> >>>>>>> + };
> >>>>>>> + int ret = 0;
> >>>>>>> +
> >>>>>>> + /* Shouldn't need this as APIC is turned off for PV, and we only
> >>>>>>> + * get called on the bootup processor. But just in case. */
> >>>>>>> + if (!xen_initial_domain() || smp_processor_id())
> >>>>>>> + return 0;
> >>>>>>> +
> >>>>>>> + if (reg == APIC_LVR)
> >>>>>>> + return 0x10;
> >>>>>>> +
> >>>>>>> + if (reg != APIC_ID)
> >>>>>>> + return 0;
> >>>>>>> +
> >>>>>>> + ret = HYPERVISOR_dom0_op(&op);
> >>>>>>> + if (ret)
> >>>>>>> + return 0;
> >>>>>>> +
> >>>>>>> + return op.u.pcpu_info.apic_id;
> >>>>>>> }
> >>>>>>>
> >>>>>>> static void xen_apic_write(u32 reg, u32 val)
> >
> > I added debugging to all exit paths that could return 0 (which is what the
> > boot_cpu_physical_apicid is set to with that patch. Which would only leave the
> > case of the HV call returning the wrong value somehow...
> >
> Hmmm, so xen_apic_read is still correct...
>
> [ 0.000000] ACPI: Local APIC address 0xfee00000
> [ 0.000000] xxx xen_apic_read(20)
> [ 0.000000] xxx xen_apic_read -> 10
> [ 0.000000] boot_cpu_physical_apicid = 0
> [ 0.000000] xxx xen_apic_read(30)
> [ 0.000000] +- apic version = 10
>
> there seems to be a slightly strange tweak (at least for me) in read_apic_id...
>
> static inline unsigned int read_apic_id(void)
> {
> unsigned int reg;
>
> reg = apic_read(APIC_ID); // calls apic->read(reg)
>
> return apic->get_apic_id(reg);

Duh!! Let me spin out a new patch that will do this.
> }
>
>



> _______________________________________________
> Xen-devel mailing list
> Xen-devel [at] lists
> http://lists.xen.org/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel

Subject User Time
Workings/effectiveness of the xen-acpi-processor driver stefan.bader at canonical Apr 25, 2012, 6:00 AM
    Re: Workings/effectiveness of the xen-acpi-processor driver konrad.wilk at oracle Apr 26, 2012, 8:50 AM
        Re: Workings/effectiveness of the xen-acpi-processor driver stefan.bader at canonical Apr 26, 2012, 9:25 AM
            Re: Workings/effectiveness of the xen-acpi-processor driver konrad.wilk at oracle Apr 26, 2012, 10:04 AM
                Re: Workings/effectiveness of the xen-acpi-processor driver pasik at iki May 6, 2012, 8:23 AM
                    Re: Workings/effectiveness of the xen-acpi-processor driver konrad.wilk at oracle May 7, 2012, 10:33 AM
                        Re: Workings/effectiveness of the xen-acpi-processor driver pasik at iki May 7, 2012, 10:44 AM
            Re: Workings/effectiveness of the xen-acpi-processor driver konrad.wilk at oracle May 1, 2012, 1:02 PM
                Re: Workings/effectiveness of the xen-acpi-processor driver boris.ostrovsky at amd May 1, 2012, 3:35 PM
                    Re: Workings/effectiveness of the xen-acpi-processor driver konrad.wilk at oracle May 1, 2012, 3:54 PM
                        Re: Workings/effectiveness of the xen-acpi-processor driver konrad.wilk at oracle May 1, 2012, 5:47 PM
                            Re: Workings/effectiveness of the xen-acpi-processor driver boris.ostrovsky at amd May 1, 2012, 6:11 PM
                                Re: Workings/effectiveness of the xen-acpi-processor driver JBeulich at suse May 2, 2012, 2:19 AM
                        Re: Workings/effectiveness of the xen-acpi-processor driver stefan.bader at canonical May 2, 2012, 7:56 AM
                    Re: Workings/effectiveness of the xen-acpi-processor driver stefan.bader at canonical May 2, 2012, 1:36 AM
                    Re: Workings/effectiveness of the xen-acpi-processor driver stefan.bader at canonical May 2, 2012, 8:01 AM
                        Re: Workings/effectiveness of the xen-acpi-processor driver konrad.wilk at oracle May 2, 2012, 9:08 AM
                            Re: Workings/effectiveness of the xen-acpi-processor driver boris.ostrovsky at amd May 2, 2012, 10:06 AM
                                Re: Workings/effectiveness of the xen-acpi-processor driver konrad.wilk at oracle May 2, 2012, 10:14 AM
                                    Re: Workings/effectiveness of the xen-acpi-processor driver boris.ostrovsky at amd May 2, 2012, 2:31 PM
                                        Re: Workings/effectiveness of the xen-acpi-processor driver konrad.wilk at oracle May 2, 2012, 2:41 PM
                                            Re: Workings/effectiveness of the xen-acpi-processor driver boris.ostrovsky at amd May 2, 2012, 3:09 PM
                                                Re: Workings/effectiveness of the xen-acpi-processor driver stefan.bader at canonical May 2, 2012, 11:55 PM
                                                    Re: Workings/effectiveness of the xen-acpi-processor driver stefan.bader at canonical May 3, 2012, 3:00 AM
                                                Re: Workings/effectiveness of the xen-acpi-processor driver stefan.bader at canonical May 3, 2012, 5:58 AM
                                                    Re: Workings/effectiveness of the xen-acpi-processor driver stefan.bader at canonical May 3, 2012, 7:47 AM
                                                        Re: Workings/effectiveness of the xen-acpi-processor driver konrad at darnok May 3, 2012, 8:46 AM
                                                            Re: Workings/effectiveness of the xen-acpi-processor driver boris.ostrovsky at amd May 3, 2012, 10:02 AM
                                                            Re: Workings/effectiveness of the xen-acpi-processor driver konrad.wilk at oracle May 3, 2012, 10:08 AM
                                                                Re: Workings/effectiveness of the xen-acpi-processor driver stefan.bader at canonical May 4, 2012, 1:00 AM
                                                Re: Workings/effectiveness of the xen-acpi-processor driver konrad.wilk at oracle May 3, 2012, 9:14 AM
                            Re: Workings/effectiveness of the xen-acpi-processor driver stefan.bader at canonical May 2, 2012, 2:29 PM
                Re: Workings/effectiveness of the xen-acpi-processor driver stefan.bader at canonical May 2, 2012, 1:22 AM

  Index | Next | Previous | View Flat
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.