Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Xen: Devel

[PATCH 4/7] vgabios: Report mode not supported getting mode informations

 

 

Xen devel RSS feed   Index | Next | Previous | View Threaded


frediano.ziglio at citrix

May 1, 2012, 6:52 AM

Post #1 of 3 (78 views)
Permalink
[PATCH 4/7] vgabios: Report mode not supported getting mode informations

Signed-off-by: Frediano Ziglio <frediano.ziglio [at] citrix>
---
tools/firmware/vgabios/vbe.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/firmware/vgabios/vbe.c b/tools/firmware/vgabios/vbe.c
index 35d9866..fff314e 100644
--- a/tools/firmware/vgabios/vbe.c
+++ b/tools/firmware/vgabios/vbe.c
@@ -911,7 +911,8 @@ Bit16u *AX;Bit16u ES;Bit16u DI;
void vbe_biosfn_return_mode_information(AX, CX, ES, DI)
Bit16u *AX;Bit16u CX; Bit16u ES;Bit16u DI;
{
- Bit16u result=0x0100;
+ // error by default is 0x014f which means supported but error
+ Bit16u result=0x014f;
Bit16u ss=get_SS();
ModeInfoBlock info;
ModeInfoListItem *cur_info;
@@ -955,7 +956,6 @@ Bit16u *AX;Bit16u CX; Bit16u ES;Bit16u DI;
#ifdef DEBUG
printf("VBE *NOT* found mode %x\n",CX);
#endif
- result = 0x100;
}

if (result == 0x4f)
--
1.7.5.4


_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


frediano.ziglio at citrix

May 4, 2012, 5:36 AM

Post #2 of 3 (73 views)
Permalink
[PATCH 4/7] vgabios: Report mode not supported getting mode informations [In reply to]

If you try to get mode information for an unsupported mode
interrupt should return error but not that the function is not
supported.

Signed-off-by: Frediano Ziglio <frediano.ziglio [at] citrix>
---
tools/firmware/vgabios/vbe.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/firmware/vgabios/vbe.c b/tools/firmware/vgabios/vbe.c
index 35d9866..fff314e 100644
--- a/tools/firmware/vgabios/vbe.c
+++ b/tools/firmware/vgabios/vbe.c
@@ -911,7 +911,8 @@ Bit16u *AX;Bit16u ES;Bit16u DI;
void vbe_biosfn_return_mode_information(AX, CX, ES, DI)
Bit16u *AX;Bit16u CX; Bit16u ES;Bit16u DI;
{
- Bit16u result=0x0100;
+ // error by default is 0x014f which means supported but error
+ Bit16u result=0x014f;
Bit16u ss=get_SS();
ModeInfoBlock info;
ModeInfoListItem *cur_info;
@@ -955,7 +956,6 @@ Bit16u *AX;Bit16u CX; Bit16u ES;Bit16u DI;
#ifdef DEBUG
printf("VBE *NOT* found mode %x\n",CX);
#endif
- result = 0x100;
}

if (result == 0x4f)
--
1.7.5.4


_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


Ian.Campbell at citrix

May 4, 2012, 7:18 AM

Post #3 of 3 (73 views)
Permalink
Re: [PATCH 4/7] vgabios: Report mode not supported getting mode informations [In reply to]

On Fri, 2012-05-04 at 13:36 +0100, Frediano Ziglio wrote:
> If you try to get mode information for an unsupported mode
> interrupt should return error but not that the function is not
> supported.
>
> Signed-off-by: Frediano Ziglio <frediano.ziglio [at] citrix>
> ---
> tools/firmware/vgabios/vbe.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/firmware/vgabios/vbe.c b/tools/firmware/vgabios/vbe.c
> index 35d9866..fff314e 100644
> --- a/tools/firmware/vgabios/vbe.c
> +++ b/tools/firmware/vgabios/vbe.c
> @@ -911,7 +911,8 @@ Bit16u *AX;Bit16u ES;Bit16u DI;
> void vbe_biosfn_return_mode_information(AX, CX, ES, DI)
> Bit16u *AX;Bit16u CX; Bit16u ES;Bit16u DI;
> {
> - Bit16u result=0x0100;
> + // error by default is 0x014f which means supported but error
> + Bit16u result=0x014f;

Something odd has happened to the whitepace here. Otherwise:
Acked-by: Ian Campbell <ian.campbell [at] citrix>


> Bit16u ss=get_SS();
> ModeInfoBlock info;
> ModeInfoListItem *cur_info;
> @@ -955,7 +956,6 @@ Bit16u *AX;Bit16u CX; Bit16u ES;Bit16u DI;
> #ifdef DEBUG
> printf("VBE *NOT* found mode %x\n",CX);
> #endif
> - result = 0x100;
> }
>
> if (result == 0x4f)



_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel

Xen devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.