Mailing List Archive: Xen: Devel

[PATCH RFC V6 2/5] kvm : Fold pv_unhalt flag into GET_MP_STATE ioctl to aid migration

Index | Next | Previous | View Threaded

raghavendra.kt at linux

Apr 23, 2012, 3:00 AM

Post #1 of 3 (63 views)
Permalink

[PATCH RFC V6 2/5] kvm : Fold pv_unhalt flag into GET_MP_STATE ioctl to aid migration

From: Raghavendra K T <raghavendra.kt [at] linux>

Signed-off-by: Raghavendra K T <raghavendra.kt [at] linux>
---
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 6faa550..7354c1b 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -5691,7 +5691,9 @@ int kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu,
int kvm_arch_vcpu_ioctl_get_mpstate(struct kvm_vcpu *vcpu,
struct kvm_mp_state *mp_state)
{
- mp_state->mp_state = vcpu->arch.mp_state;
+ mp_state->mp_state = (vcpu->arch.mp_state == KVM_MP_STATE_HALTED &&
+ vcpu->arch.pv.pv_unhalted) ?
+ KVM_MP_STATE_RUNNABLE : vcpu->arch.mp_state;
return 0;
}

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel

avi at redhat

Apr 29, 2012, 6:27 AM

Post #2 of 3 (61 views)
Permalink

Re: [PATCH RFC V6 2/5] kvm : Fold pv_unhalt flag into GET_MP_STATE ioctl to aid migration [In reply to]

On 04/23/2012 01:00 PM, Raghavendra K T wrote:
> From: Raghavendra K T <raghavendra.kt [at] linux>
>
> Signed-off-by: Raghavendra K T <raghavendra.kt [at] linux>
> ---
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 6faa550..7354c1b 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -5691,7 +5691,9 @@ int kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu,
> int kvm_arch_vcpu_ioctl_get_mpstate(struct kvm_vcpu *vcpu,
> struct kvm_mp_state *mp_state)
> {
> - mp_state->mp_state = vcpu->arch.mp_state;
> + mp_state->mp_state = (vcpu->arch.mp_state == KVM_MP_STATE_HALTED &&
> + vcpu->arch.pv.pv_unhalted) ?
> + KVM_MP_STATE_RUNNABLE : vcpu->arch.mp_state;
> return 0;
> }

Not pretty. Suggest rewriting using an if.

--
error compiling committee.c: too many arguments to function

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel

raghavendra.kt at linux

Apr 30, 2012, 12:45 AM

Post #3 of 3 (60 views)
Permalink

Re: [PATCH RFC V6 2/5] kvm : Fold pv_unhalt flag into GET_MP_STATE ioctl to aid migration [In reply to]

On 04/29/2012 06:57 PM, Avi Kivity wrote:
> On 04/23/2012 01:00 PM, Raghavendra K T wrote:
>> From: Raghavendra K T<raghavendra.kt [at] linux>
>>
>> Signed-off-by: Raghavendra K T<raghavendra.kt [at] linux>
>> ---
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index 6faa550..7354c1b 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -5691,7 +5691,9 @@ int kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu *vcpu,
>> int kvm_arch_vcpu_ioctl_get_mpstate(struct kvm_vcpu *vcpu,
>> struct kvm_mp_state *mp_state)
>> {
>> - mp_state->mp_state = vcpu->arch.mp_state;
>> + mp_state->mp_state = (vcpu->arch.mp_state == KVM_MP_STATE_HALTED&&
>> + vcpu->arch.pv.pv_unhalted) ?
>> + KVM_MP_STATE_RUNNABLE : vcpu->arch.mp_state;
>> return 0;
>> }
>
> Not pretty. Suggest rewriting using an if.
>

Ok.. 'll rewrite.

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads