Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Xen: Devel

[regression] Ideapad S10-3 does not wake up from suspend (Re: [PATCH v2 2/2] x86: don't unmask disabled irqs when migrating them)

 

 

Xen devel RSS feed   Index | Next | Previous | View Threaded


jrnieder at gmail

Aug 28, 2011, 9:15 PM

Post #1 of 15 (308 views)
Permalink
[regression] Ideapad S10-3 does not wake up from suspend (Re: [PATCH v2 2/2] x86: don't unmask disabled irqs when migrating them)

Hi,

Lars Boegild Thomsen writes[1]:

> After update from 2.6 kernel to 3.0 my Idepad S10-3 will not wake up after
> sleep. Back to latest 2.6 kernel works fine.
[...]
> Upon wakeup, the power light go from slow flashing to on, the battery light
> goes from off to on, the hdd light blink once and then everything is dead.
> Nothing happens on the screen, all keys dead. The fan/hdd switch on
> physically (very hard to hear on this model or I am getting deaf).
> Ctrl+alt+del or the alt+sysreq is non-responsive. The only LED that show
> keyboard status is CAPS lock and that is unresponsive too. Only way I have
> found to get it rebooted is holding down the power button a few secs until it
> switch physically off and then switch it on again.
[...]
> Here's the result of the final bisect:
>
> 983bbf1af0664b78689612b247acb514300f62c7 is the first bad commit
[...]
> I also tried to go back to HEAD and manually change arch/x86/irq.c revert this
> particular commit and it works.

For reference:

> commit 983bbf1af0664b78689612b247acb514300f62c7
> Author: Tian, Kevin <kevin.tian [at] intel>
> Date: Fri May 6 14:43:56 2011 +0800
>
> x86: Don't unmask disabled irqs when migrating them
>
> It doesn't make sense to unconditionally unmask a disabled irq when
> migrating it from offlined cpu to another. If the irq triggers then it
> will be disabled in the interrupt handler anyway. So we can just avoid
> unmasking it.
>
> [ tglx: Made masking unconditional again and fixed the changelog ]
>
> Signed-off-by: Fengzhe Zhang <fengzhe.zhang [at] intel>
> Signed-off-by: Kevin Tian <kevin.tian [at] intel>
> Cc: Ian Campbell <Ian.Campbell [at] citrix>
> Cc: Jan Beulich <JBeulich [at] novell>
> Cc: "xen-devel [at] lists" <xen-devel [at] lists>
> Link: http://lkml.kernel.org/r/%3C625BA99ED14B2D499DC4E29D8138F1505C8ED7F7E3%40shsmsx502.ccr.corp.intel.com%3
> Signed-off-by: Thomas Gleixner <tglx [at] linutronix>
>
> diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> index 544efe2741be..6c0802eb2f7f 100644
> --- a/arch/x86/kernel/irq.c
> +++ b/arch/x86/kernel/irq.c
> @@ -276,7 +276,8 @@ void fixup_irqs(void)
> else if (!(warned++))
> set_affinity = 0;
>
> - if (!irqd_can_move_in_process_context(data) && chip->irq_unmask)
> + if (!irqd_can_move_in_process_context(data) &&
> + !irqd_irq_disabled(data) && chip->irq_unmask)
> chip->irq_unmask(data);
>
> raw_spin_unlock(&desc->lock);

Known problem? Ideas?

Regards,
Jonathan

[1] http://bugs.debian.org/635575

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xensource.com/xen-devel


dave at linux

Aug 30, 2011, 6:04 PM

Post #2 of 15 (302 views)
Permalink
Re: [regression] Ideapad S10-3 does not wake up from suspend (Re: [PATCH v2 2/2] x86: don't unmask disabled irqs when migrating them) [In reply to]

On Sun, 2011-08-28 at 23:15 -0500, Jonathan Nieder wrote:
> Lars Boegild Thomsen writes[1]:
> > After update from 2.6 kernel to 3.0 my Idepad S10-3 will not wake up after
> > sleep. Back to latest 2.6 kernel works fine.
> [...]
> > Upon wakeup, the power light go from slow flashing to on, the battery light
> > goes from off to on, the hdd light blink once and then everything is dead.
> > Nothing happens on the screen, all keys dead. The fan/hdd switch on
> > physically (very hard to hear on this model or I am getting deaf).
> > Ctrl+alt+del or the alt+sysreq is non-responsive. The only LED that show
> > keyboard status is CAPS lock and that is unresponsive too. Only way I have
> > found to get it rebooted is holding down the power button a few secs until it
> > switch physically off and then switch it on again.
> [...]
> > Here's the result of the final bisect:
> >
> > 983bbf1af0664b78689612b247acb514300f62c7 is the first bad commit
> [...]
> > I also tried to go back to HEAD and manually change arch/x86/irq.c revert this
> > particular commit and it works.
>
> For reference:
>
> > commit 983bbf1af0664b78689612b247acb514300f62c7
> > Author: Tian, Kevin <kevin.tian [at] intel>
> > Date: Fri May 6 14:43:56 2011 +0800
> >
> > x86: Don't unmask disabled irqs when migrating them
> >
> > It doesn't make sense to unconditionally unmask a disabled irq when
> > migrating it from offlined cpu to another. If the irq triggers then it
> > will be disabled in the interrupt handler anyway. So we can just avoid
> > unmasking it.
> >
> > [ tglx: Made masking unconditional again and fixed the changelog ]
> >
> > Signed-off-by: Fengzhe Zhang <fengzhe.zhang [at] intel>
> > Signed-off-by: Kevin Tian <kevin.tian [at] intel>
> > Cc: Ian Campbell <Ian.Campbell [at] citrix>
> > Cc: Jan Beulich <JBeulich [at] novell>
> > Cc: "xen-devel [at] lists" <xen-devel [at] lists>
> > Link: http://lkml.kernel.org/r/%3C625BA99ED14B2D499DC4E29D8138F1505C8ED7F7E3%40shsmsx502.ccr.corp.intel.com%3
> > Signed-off-by: Thomas Gleixner <tglx [at] linutronix>
> >
> > diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> > index 544efe2741be..6c0802eb2f7f 100644
> > --- a/arch/x86/kernel/irq.c
> > +++ b/arch/x86/kernel/irq.c
> > @@ -276,7 +276,8 @@ void fixup_irqs(void)
> > else if (!(warned++))
> > set_affinity = 0;
> >
> > - if (!irqd_can_move_in_process_context(data) && chip->irq_unmask)
> > + if (!irqd_can_move_in_process_context(data) &&
> > + !irqd_irq_disabled(data) && chip->irq_unmask)
> > chip->irq_unmask(data);
> >
> > raw_spin_unlock(&desc->lock);
>
> Known problem? Ideas?
> [1] http://bugs.debian.org/635575

cc'ing Len Brown who tried to fix this, but in different code:

http://git.kernel.org/gitweb.cgi?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=4731fdcf6f7bdab3e369a3f844d4ea4d4017284d

I'm seeing the exact same symptoms on my S10-3, fwiw. They definitely
don't happen when intel_idle is compiled out or when
intel_idle.max_cstate=0 is specified on the kernel command-line.

-- Dave


_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xensource.com/xen-devel


jrnieder at gmail

Aug 31, 2011, 1:22 AM

Post #3 of 15 (303 views)
Permalink
Re: [regression] Ideapad S10-3 does not wake up from suspend (Re: [PATCH v2 2/2] x86: don't unmask disabled irqs when migrating them) [In reply to]

Hi Dave,

Dave Hansen wrote:

> I'm seeing the exact same symptoms on my S10-3, fwiw. They definitely
> don't happen when intel_idle is compiled out or when
> intel_idle.max_cstate=0 is specified on the kernel command-line.

Lars reminds me[1] that the kernel he was testing already had the
intel_idle driver compiled out, so you're probably seeing a different
(possibly related) bug. (By the way, Lars, it is fine to communicate
with lkml directly. :) The people there don't bite.)

Over and out,
Jonathan

[1] http://bugs.debian.org/635575#42
(.config attached to that bug in a later comment)

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xensource.com/xen-devel


kevin.tian at intel

Aug 31, 2011, 11:24 PM

Post #4 of 15 (301 views)
Permalink
RE: [regression] Ideapad S10-3 does not wake up from suspend (Re: [PATCH v2 2/2] x86: don't unmask disabled irqs when migrating them) [In reply to]

> From: Jonathan Nieder [mailto:jrnieder [at] gmail]
> Sent: Monday, August 29, 2011 12:16 PM
>
> Hi,
>
> Lars Boegild Thomsen writes[1]:
>
> > After update from 2.6 kernel to 3.0 my Idepad S10-3 will not wake up after
> > sleep. Back to latest 2.6 kernel works fine.
> [...]
> > Upon wakeup, the power light go from slow flashing to on, the battery light
> > goes from off to on, the hdd light blink once and then everything is dead.
> > Nothing happens on the screen, all keys dead. The fan/hdd switch on
> > physically (very hard to hear on this model or I am getting deaf).
> > Ctrl+alt+del or the alt+sysreq is non-responsive. The only LED that show
> > keyboard status is CAPS lock and that is unresponsive too. Only way I have
> > found to get it rebooted is holding down the power button a few secs until it
> > switch physically off and then switch it on again.
> [...]
> > Here's the result of the final bisect:
> >
> > 983bbf1af0664b78689612b247acb514300f62c7 is the first bad commit
> [...]
> > I also tried to go back to HEAD and manually change arch/x86/irq.c revert this
> > particular commit and it works.
>
> For reference:
>
> > commit 983bbf1af0664b78689612b247acb514300f62c7
> > Author: Tian, Kevin <kevin.tian [at] intel>
> > Date: Fri May 6 14:43:56 2011 +0800
> >
> > x86: Don't unmask disabled irqs when migrating them
> >
> > It doesn't make sense to unconditionally unmask a disabled irq when
> > migrating it from offlined cpu to another. If the irq triggers then it
> > will be disabled in the interrupt handler anyway. So we can just avoid
> > unmasking it.
> >
> > [ tglx: Made masking unconditional again and fixed the changelog ]
> >
> > Signed-off-by: Fengzhe Zhang <fengzhe.zhang [at] intel>
> > Signed-off-by: Kevin Tian <kevin.tian [at] intel>
> > Cc: Ian Campbell <Ian.Campbell [at] citrix>
> > Cc: Jan Beulich <JBeulich [at] novell>
> > Cc: "xen-devel [at] lists" <xen-devel [at] lists>
> > Link:
> http://lkml.kernel.org/r/%3C625BA99ED14B2D499DC4E29D8138F1505C8ED7F
> 7E3%40shsmsx502.ccr.corp.intel.com%3
> > Signed-off-by: Thomas Gleixner <tglx [at] linutronix>
> >
> > diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
> > index 544efe2741be..6c0802eb2f7f 100644
> > --- a/arch/x86/kernel/irq.c
> > +++ b/arch/x86/kernel/irq.c
> > @@ -276,7 +276,8 @@ void fixup_irqs(void)
> > else if (!(warned++))
> > set_affinity = 0;
> >
> > - if (!irqd_can_move_in_process_context(data) && chip->irq_unmask)
> > + if (!irqd_can_move_in_process_context(data) &&
> > + !irqd_irq_disabled(data) && chip->irq_unmask)
> > chip->irq_unmask(data);
> >
> > raw_spin_unlock(&desc->lock);
>
> Known problem? Ideas?
>

this is the 1st problem reported on this change. But honestly speaking
I didn't see obvious problem with it. As the commit msg says, it simply
completes a delayed irq disable action, by keeping interrupt line masked,
instead of relying on a future interrupt handler to actually mask it.

fixup_irqs is invoked in suspend path. The only impact this change may
bring to resume path is the interrupt line state, which is saved later
in suspend and then restored in resume. w/ above change after resume
given interrupt line is always masked, while w/o it there may be at least
one interrupt raising. If this does matter to make your ideapad working,
I'd think there may have other bugs which are hidden originally, e.g. by
triggering a reschedule from that interrupt though the handler itself
does nothing except masking the interrupt line.

So... above commit is not important which can be easily reverted. My
only concern is whether other severe issues are just hidden.

btw, any serial output you may capture?

Thanks
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xensource.com/xen-devel


serge at hallyn

Sep 1, 2011, 8:01 PM

Post #5 of 15 (302 views)
Permalink
Re: [regression] Ideapad S10-3 does not wake up from suspend (Re: [PATCH v2 2/2] x86: don't unmask disabled irqs when migrating them) [In reply to]

Quoting Jonathan Nieder (jrnieder [at] gmail):
> Hi Dave,
>
> Dave Hansen wrote:
>
> > I'm seeing the exact same symptoms on my S10-3, fwiw. They definitely
> > don't happen when intel_idle is compiled out or when
> > intel_idle.max_cstate=0 is specified on the kernel command-line.
>
> Lars reminds me[1] that the kernel he was testing already had the
> intel_idle driver compiled out, so you're probably seeing a different
> (possibly related) bug. (By the way, Lars, it is fine to communicate
> with lkml directly. :) The people there don't bite.)

Right, over the past year or so this has been hit or miss. Sometimes
intel_idle.max_cstate=0 would fix it. Sometimes (like today) not. Ever
since the problems have started, using intel_idle has not worked once,
but disabling it is not 100% reliable. And when it doesn't work, it
doesn't work at all until I get a new kernel.

Sorry, not very helpful.

-serge

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xensource.com/xen-devel


jrnieder at gmail

Apr 15, 2012, 7:06 AM

Post #6 of 15 (202 views)
Permalink
Re: [regression] Ideapad S10-3 does not wake up from suspend [In reply to]

Hi,

Quick summary and update.

> Lars Boegild Thomsen writes[1]:

>> After update from 2.6 kernel to 3.0 my Idepad S10-3 will not wake up after
>> sleep.
[...]
>> 983bbf1af0664b78689612b247acb514300f62c7 is the first bad commit

983bbf1af06 is "x86: Don't unmask disabled irqs when migrating them",
2011-05-06, and looks like this:

>> --- a/arch/x86/kernel/irq.c
>> +++ b/arch/x86/kernel/irq.c
>> @@ -276,7 +276,8 @@ void fixup_irqs(void)
>> else if (!(warned++))
>> set_affinity = 0;
>>
>> - if (!irqd_can_move_in_process_context(data) && chip->irq_unmask)
>> + if (!irqd_can_move_in_process_context(data) &&
>> + !irqd_irq_disabled(data) && chip->irq_unmask)
>> chip->irq_unmask(data);

Robert Scott found[1], using 3.2.12:

> I'm getting the same behaviour on my Lenovo Ideapad S10-3

An anonymous contributor[2] also reports the same problem in v3.3.

Lars, Robert, anon: can you try 3.4-rc2 or newer and let us know how
it goes? I suspect v3.4-rc2~24^2~4 ("x86: Preserve lazy irq disable
semantics in fixup_irqs()") will fix this.

Liu Chuansheng et al: do you think that commit would be a good
candidate for inclusion in -stable kernels?

Thanks and hope that helps,
Jonathan

> [1] http://bugs.debian.org/635575
[2] https://bugzilla.kernel.org/show_bug.cgi?id=41932

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


bugs at humanleg

Apr 16, 2012, 11:05 AM

Post #7 of 15 (201 views)
Permalink
Re: [regression] Ideapad S10-3 does not wake up from suspend [In reply to]

On Sunday 15 April 2012, Jonathan Nieder wrote:
> Lars, Robert, anon: can you try 3.4-rc2 or newer and let us know how
> it goes? I suspect v3.4-rc2~24^2~4 ("x86: Preserve lazy irq disable
> semantics in fixup_irqs()") will fix this.

Hmm, no, 3.4-rc2 seems to produce the same results I'm afraid.


robert.

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


jrnieder at gmail

Apr 16, 2012, 7:04 PM

Post #8 of 15 (197 views)
Permalink
Re: [regression] Ideapad S10-3 does not wake up from suspend [In reply to]

Robert Scott wrote:
> On Sunday 15 April 2012, Jonathan Nieder wrote:

>> Lars, Robert, anon: can you try 3.4-rc2 or newer and let us know how
>> it goes? I suspect v3.4-rc2~24^2~4 ("x86: Preserve lazy irq disable
>> semantics in fixup_irqs()") will fix this.
>
> Hmm, no, 3.4-rc2 seems to produce the same results I'm afraid.

Alas. Does suspend-to-disk ("echo disk >/sys/power/state") have the
same problem? Can you get a log of the failure with
"no_console_suspend" appended to the kernel command line, for example
with a serial console or netconsole?

If someone has time to go through the steps in
"Documentation/power/basic-pm-debugging.txt", that would also be useful.

Thanks, and sorry to take so long to get to this.

Sincerely,
Jonathan

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


lth at cow

Apr 18, 2012, 3:03 AM

Post #9 of 15 (195 views)
Permalink
Re: [regression] Ideapad S10-3 does not wake up from suspend [In reply to]

On Tuesday 17 April 2012 10:04:33 Jonathan Nieder wrote:
> > Hmm, no, 3.4-rc2 seems to produce the same results I'm afraid.
> Alas. Does suspend-to-disk ("echo disk >/sys/power/state") have the
> same problem? Can you get a log of the failure with
> "no_console_suspend" appended to the kernel command line, for example
> with a serial console or netconsole?

Using a serial console is a bit of a problem on this netbook as it hasn't got
a serial port. Not sure how the netconsole works - will read up on that.

And no - suspend to disk works fine.

I have by the way experimentally switched to 32bit version and it's the same
thing (originally I was running 64bit version but that really doesn't make
sense on a netbook - except doing it because it could be done).

//Lars...

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


bugs at humanleg

Apr 21, 2012, 6:14 AM

Post #10 of 15 (193 views)
Permalink
Re: [regression] Ideapad S10-3 does not wake up from suspend [In reply to]

On Tuesday 17 April 2012, Jonathan Nieder wrote:
> Robert Scott wrote:
> > On Sunday 15 April 2012, Jonathan Nieder wrote:
>
> >> Lars, Robert, anon: can you try 3.4-rc2 or newer and let us know how
> >> it goes? I suspect v3.4-rc2~24^2~4 ("x86: Preserve lazy irq disable
> >> semantics in fixup_irqs()") will fix this.
> >
> > Hmm, no, 3.4-rc2 seems to produce the same results I'm afraid.
>
> Alas. Does suspend-to-disk ("echo disk >/sys/power/state") have the
> same problem? Can you get a log of the failure with
> "no_console_suspend" appended to the kernel command line, for example
> with a serial console or netconsole?

(back on 3.2.0-0.bpo.2-686-pae 3.2.12-1~bpo60+1*:)

eth0 seems to go down/come up to early/late to get anything useful from netconsole:

[ 745.161322] PM: Syncing filesystems ... done.
[ 747.088247] PM: Preparing system for mem sleep
[ 747.187932] Freezing user space processes ... (elapsed 0.01 seconds) done.
[ 747.204325] Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done.
[ 747.220416] PM: Entering mem sleep
[ 747.221085] sd 1:0:0:0: [sda] Synchronizing SCSI cache
[ 747.222247] sd 1:0:0:0: [sda] Stopping disk

(then nothing)

I may be able to hook up a usb-serial adaptor to try and get more info but it'll take me a bit longer what with all the rewiring fun as I don't have a null modem cable lying around.

> If someone has time to go through the steps in
> "Documentation/power/basic-pm-debugging.txt", that would also be useful.

"freezer", "devices", "platform", "processors", or "core" pm_test modes all work fine, naturally.


robert.

* I notice I accidentally copy/pasted the linux-modules version in a previous mail but you knew what I was talking about

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


pasik at iki

Apr 22, 2012, 9:34 AM

Post #11 of 15 (193 views)
Permalink
Re: [regression] Ideapad S10-3 does not wake up from suspend [In reply to]

On Wed, Apr 18, 2012 at 06:03:00PM +0800, Lars Boegild Thomsen wrote:
> On Tuesday 17 April 2012 10:04:33 Jonathan Nieder wrote:
> > > Hmm, no, 3.4-rc2 seems to produce the same results I'm afraid.
> > Alas. Does suspend-to-disk ("echo disk >/sys/power/state") have the
> > same problem? Can you get a log of the failure with
> > "no_console_suspend" appended to the kernel command line, for example
> > with a serial console or netconsole?
>
> Using a serial console is a bit of a problem on this netbook as it hasn't got
> a serial port. Not sure how the netconsole works - will read up on that.
>

You can get an ExpressCard Serial Card and use that..
or if the laptop has vPro then it has Serial Over LAN in the AMT chip.

http://wiki.xen.org/wiki/Xen_Serial_Console

-- Pasi

> And no - suspend to disk works fine.
>
> I have by the way experimentally switched to 32bit version and it's the same
> thing (originally I was running 64bit version but that really doesn't make
> sense on a netbook - except doing it because it could be done).
>
> //Lars...
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel [at] lists
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


bugs at humanleg

May 6, 2012, 5:44 AM

Post #12 of 15 (180 views)
Permalink
Re: [regression] Ideapad S10-3 does not wake up from suspend [In reply to]

On Tuesday 17 April 2012, Jonathan Nieder wrote:
> Robert Scott wrote:
> > On Sunday 15 April 2012, Jonathan Nieder wrote:
>
> >> Lars, Robert, anon: can you try 3.4-rc2 or newer and let us know how
> >> it goes? I suspect v3.4-rc2~24^2~4 ("x86: Preserve lazy irq disable
> >> semantics in fixup_irqs()") will fix this.
> >
> > Hmm, no, 3.4-rc2 seems to produce the same results I'm afraid.
>
> Alas. Does suspend-to-disk ("echo disk >/sys/power/state") have the
> same problem? Can you get a log of the failure with
> "no_console_suspend" appended to the kernel command line, for example
> with a serial console or netconsole?

Well, for what it's worth, using a USB serial console to capture output, all you get is:

[ 814.016541] PM: Syncing filesystems ... done.
[ 814.018516] PM: Preparing system for mem sleep
[ 814.100393] Freezing user space processes ... (elapsed 0.01 se

before it goes to sleep, and it doesn't output anything on (attempted) wakeup. Though I don't know if this is due to USB being woken up quite late or something.


robert.

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


jrnieder at gmail

May 12, 2012, 4:13 PM

Post #13 of 15 (171 views)
Permalink
Re: [regression] Ideapad S10-3 does not wake up from suspend [In reply to]

Hi again,

In September, Kevin Tian wrote:
>> Lars Boegild Thomsen writes[1]:

>>> After update from 2.6 kernel to 3.0 my Idepad S10-3 will not wake up after
>>> sleep. Back to latest 2.6 kernel works fine.
> > [...]
>>> Upon wakeup, the power light go from slow flashing to on, the battery light
>>> goes from off to on, the hdd light blink once and then everything is dead.
[...]
>>> 983bbf1af0664b78689612b247acb514300f62c7 is the first bad commit
>> [...]
>>> I also tried to go back to HEAD and manually change arch/x86/irq.c revert this
>>> particular commit and it works.
[...]
> fixup_irqs is invoked in suspend path. The only impact this change may
> bring to resume path is the interrupt line state, which is saved later
> in suspend and then restored in resume. w/ above change after resume
> given interrupt line is always masked, while w/o it there may be at least
> one interrupt raising. If this does matter to make your ideapad working,
> I'd think there may have other bugs which are hidden originally, e.g. by
> triggering a reschedule from that interrupt though the handler itself
> does nothing except masking the interrupt line.
>
> So... above commit is not important which can be easily reverted. My
> only concern is whether other severe issues are just hidden.
>
> btw, any serial output you may capture?

Sorry for the slow response. Result from reporters is:

- 3.4-rc2 is affected as well
- this only affects suspend-to-RAM --- suspend-to-disk works fine
- all five pm_test modes for suspend-to-RAM work fine
- this netbook doesn't have a serial port. Netconsole gives:

| [ 745.161322] PM: Syncing filesystems ... done.
| [ 747.088247] PM: Preparing system for mem sleep
| [ 747.187932] Freezing user space processes ... (elapsed 0.01 seconds) done.
| [ 747.204325] Freezing remaining freezable tasks ... (elapsed 0.01 seconds) done.
| [ 747.220416] PM: Entering mem sleep
| [ 747.221085] sd 1:0:0:0: [sda] Synchronizing SCSI cache
| [ 747.222247] sd 1:0:0:0: [sda] Stopping disk
|
| (then nothing)

Serial console via a USB-to-serial converter gives:

| [ 814.016541] PM: Syncing filesystems ... done.
| [ 814.018516] PM: Preparing system for mem sleep
| [ 814.100393] Freezing user space processes ... (elapsed 0.01 se
|
| before it goes to sleep, and it doesn't output anything on (attempted) wakeup.

- passing parameters "hpet=disable highres=off nohz=off" helps some
people if I understand correctly, but I might have misunderstood.[2]

I'd be interested to hear whether the same problem occurs when trying
to suspend from the minimal initramfs environment. (On systems like
Debian that use initramfs-tools, that means passing the kernel command
line parameter "break=top", booting, loading some appropriate minimal
collection of modules --- maybe none ---, and then running
"echo mem >/sys/power/state". initramfs-tools(8) has details.)

Hope that helps,
Jonathan

>> [1] http://bugs.debian.org/635575
[2] https://bugzilla.kernel.org/show_bug.cgi?id=41932

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


lth at cow

May 12, 2012, 6:22 PM

Post #14 of 15 (171 views)
Permalink
Re: [regression] Ideapad S10-3 does not wake up from suspend [In reply to]

On Sunday 13 May 2012 07:13:49 Jonathan Nieder wrote:
> In September, Kevin Tian wrote:
> >> Lars Boegild Thomsen writes[1]:
> >>> After update from 2.6 kernel to 3.0 my Idepad S10-3 will not wake up
> >>> after sleep. Back to latest 2.6 kernel works fine.
> - passing parameters "hpet=disable highres=off nohz=off" helps some
> people if I understand correctly, but I might have misunderstood.[2]

I didn't notice this one before but that actually works for me. Adding those
kernel params and sleep works again. I tried combinations thereof but no-go -
all 3 required.

> I'd be interested to hear whether the same problem occurs when trying
> to suspend from the minimal initramfs environment. (On systems like
> Debian that use initramfs-tools, that means passing the kernel command
> line parameter "break=top", booting, loading some appropriate minimal
> collection of modules --- maybe none ---, and then running
> "echo mem >/sys/power/state". initramfs-tools(8) has details.)

And I just tried this loading no modules manually and it's the same - never
wakes up after sleep.

//Lars...

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel


jrnieder at gmail

Jul 15, 2012, 4:24 PM

Post #15 of 15 (146 views)
Permalink
Re: [regression] Ideapad S10-3 does not wake up from suspend [In reply to]

Hi again,

In May, Lars Boegild Thomsen wrote:
> On Sunday 13 May 2012 07:13:49 Jonathan Nieder wrote:
>>>> Lars Boegild Thomsen writes:

>>>>> After update from 2.6 kernel to 3.0 my Idepad S10-3 will not wake up
>>>>> after sleep. Back to latest 2.6 kernel works fine.
>>
>> - passing parameters "hpet=disable highres=off nohz=off" helps some
>> people if I understand correctly,
[...]
> I didn't notice this one before but that actually works for me. Adding those
> kernel params and sleep works again. I tried combinations thereof but no-go -
> all 3 required.
>
>> I'd be interested to hear whether the same problem occurs when trying
>> to suspend from the minimal initramfs environment.
[...]
> And I just tried this loading no modules manually and it's the same - never
> wakes up after sleep.

Thanks. Please test with the debugging patch below from Feng Tang[1].
I don't know if it will get any useful information because e.g. serial
console and netconsole are not very convenient on this machine[2], but
it seems worth a try.

If one of the people cc-ed needs help building a patched kernel to
test, feel free to write privately and I can give more detailed
instructions.

Hope that helps,
Jonathan

[1] https://bugzilla.kernel.org/show_bug.cgi?id=41932#c18
[2] http://thread.gmane.org/gmane.linux.kernel/1136253/focus=1285790

diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
index f113755..d2e0c90 100644
--- a/kernel/time/tick-broadcast.c
+++ b/kernel/time/tick-broadcast.c
@@ -439,6 +439,14 @@ again:
* in the event mask
*/
if (next_event.tv64 != KTIME_MAX) {
+ s64 delta;
+
+ delta = next_event.tv64 - now.tv64;
+ if (delta >= 10000000000) {
+ printk("%s(): The delta is big: %lld\n", __func__, delta);
+ next_event.tv64 = now.tv64 + 3000000000;
+ }
+
/*
* Rearm the broadcast device. If event expired,
* repeat the above

_______________________________________________
Xen-devel mailing list
Xen-devel [at] lists
http://lists.xen.org/xen-devel

Xen devel RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.