Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Wikipedia: Wikitech

the skin change in 1.21wmf5, display breakage, & fix retrospective, again

 

 

Wikipedia wikitech RSS feed   Index | Next | Previous | View Threaded


aklapper at wikimedia

Dec 4, 2012, 9:06 AM

Post #1 of 6 (417 views)
Permalink
the skin change in 1.21wmf5, display breakage, & fix retrospective, again

After Sumana's summary of the wmf5 phase2 deployment (last Wednesday) at
http://lists.wikimedia.org/pipermail/wikitech-l/2012-November/064718.html
we ran into similar issues again yesterday night when deploying to
English Wikipedia (phase3).

According to Ryan in bug 42452 , this time "The problem seems to be that
ResourceLoader isn't delivering the updated CSS." Some minutes later
Ryan "touched and synced the startup.js and
ext.vector.collapsibleNav.css files. Seems to be working correctly now."

Still, we have several users that state that after purging their browser
cache they *still* face issues:
https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#What_just_happened_to_the_UI.3F


Can anyone shed some light on how affected users can track down and help
to fix the underlying problems here, if possible?
What could users try, and which data could they provide?

Obviously I'd love to avoid ending up with the same situation (and
"lively" Village Pump discussions) again tomorrow when deploying wmf5 to
all other Wikipedias.

andre
--
Andre Klapper | Wikimedia Bugwrangler
http://blogs.gnome.org/aklapper/


_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


arichards at wikimedia

Dec 4, 2012, 9:29 AM

Post #2 of 6 (406 views)
Permalink
Re: the skin change in 1.21wmf5, display breakage, & fix retrospective, again [In reply to]

On Tue, Dec 4, 2012 at 10:06 AM, Andre Klapper <aklapper [at] wikimedia>wrote:

> After Sumana's summary of the wmf5 phase2 deployment (last Wednesday) at
> http://lists.wikimedia.org/pipermail/wikitech-l/2012-November/064718.html
> we ran into similar issues again yesterday night when deploying to
> English Wikipedia (phase3).
>
> According to Ryan in bug 42452 , this time "The problem seems to be that
> ResourceLoader isn't delivering the updated CSS." Some minutes later
> Ryan "touched and synced the startup.js and
> ext.vector.collapsibleNav.css files. Seems to be working correctly now."
>

This seems to be a not-that-uncommon behavior with resources - at least it
has been for deployments of MobileFrontend. We believed it was symptomatic
of this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=37812, but we
have also run into similar issues in cases other than what Krinkle explains
in the first comment. It would be nice to get this resolved as it causes
big headaches during deployment.


Still, we have several users that state that after purging their browser
> cache they *still* face issues:
>
> https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#What_just_happened_to_the_UI.3F


Sounds like resources might be stuck in server-side caches.


> Can anyone shed some light on how affected users can track down and help
> to fix the underlying problems here, if possible?
> What could users try, and which data could they provide?
>

Have them try loading pages with ?action=purge in the URL and see if the
issue is resolved - that should purge the page from the front-end cache.
Failing that, if adding ?debug=true to the URL generates a properly
formatted page, then ResourceLoader is still trying to load out-of-date
resources. If that's the case, another touch/sync on a file from the stale
resource module might do the trick. I imagine ops or the ResourceLoader
folks might have some other ideas.

--
Arthur Richards
Software Engineer, Mobile
[[User:Awjrichards]]
IRC: awjr
+1-415-839-6885 x6687
_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


rkaldari at wikimedia

Dec 4, 2012, 10:22 AM

Post #3 of 6 (409 views)
Permalink
Re: the skin change in 1.21wmf5, display breakage, & fix retrospective, again [In reply to]

One thing we can do is preemptively deploy the following files to wmf4
today:
skins/modern/main.css
skins/vector/screen.css
extensions/Vector/modules/ext.vector.collapsibleNav.css

Of course someone should check and make sure the only changes this would
entail is adding a bunch of h3 selectors.

I don't have any deployment windows today, but it shouldn't be hard for
someone to squeeze this in. If anyone wants help with this, let me know.

Ryan Kaldari

On Tue, Dec 4, 2012 at 9:06 AM, Andre Klapper <aklapper [at] wikimedia>wrote:

> After Sumana's summary of the wmf5 phase2 deployment (last Wednesday) at
> http://lists.wikimedia.org/pipermail/wikitech-l/2012-November/064718.html
> we ran into similar issues again yesterday night when deploying to
> English Wikipedia (phase3).
>
> According to Ryan in bug 42452 , this time "The problem seems to be that
> ResourceLoader isn't delivering the updated CSS." Some minutes later
> Ryan "touched and synced the startup.js and
> ext.vector.collapsibleNav.css files. Seems to be working correctly now."
>
> Still, we have several users that state that after purging their browser
> cache they *still* face issues:
>
> https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#What_just_happened_to_the_UI.3F
>
>
> Can anyone shed some light on how affected users can track down and help
> to fix the underlying problems here, if possible?
> What could users try, and which data could they provide?
>
> Obviously I'd love to avoid ending up with the same situation (and
> "lively" Village Pump discussions) again tomorrow when deploying wmf5 to
> all other Wikipedias.
>
> andre
> --
> Andre Klapper | Wikimedia Bugwrangler
> http://blogs.gnome.org/aklapper/
>
>
> _______________________________________________
> Wikitech-l mailing list
> Wikitech-l [at] lists
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


maxsem.wiki at gmail

Dec 4, 2012, 10:52 AM

Post #4 of 6 (411 views)
Permalink
Re: the skin change in 1.21wmf5, display breakage, & fix retrospective, again [In reply to]

On 04.12.2012, 21:29 Arthur wrote:

> This seems to be a not-that-uncommon behavior with resources - at least it
> has been for deployments of MobileFrontend. We believed it was symptomatic
> of this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=37812, but we
> have also run into similar issues in cases other than what Krinkle explains
> in the first comment. It would be nice to get this resolved as it causes
> big headaches during deployment.

Yeah, I now prefer to cd extensions/MobileFrontend && find -type f -exec touch {} \;
when deploying. Is there a way to purge the RL cache completely (and
preferrably not causing a meltdown)?

--
Best regards,
Max Semenik ([[User:MaxSem]])


_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


bjorsch at wikimedia

Dec 4, 2012, 1:56 PM

Post #5 of 6 (403 views)
Permalink
Re: the skin change in 1.21wmf5, display breakage, & fix retrospective, again [In reply to]

On Tue, Dec 4, 2012 at 1:22 PM, Ryan Kaldari <rkaldari [at] wikimedia> wrote:
> Of course someone should check and make sure the only changes this would
> entail is adding a bunch of h3 selectors.

> skins/modern/main.css

Also moves "#mw_portlets h2" to way-offscreen, and sets a font-size on
".portlet h3/h5".

> skins/vector/screen.css

Also moves "#mw-navigation h2" to way-offscreen, sets a z-index on
"div#mw-head h3/h5" to fix bug 37158, sets list-style-type and
list-style-image instead of just list-style various ul tags, sets the
default list-style-type to 'disc' for ul tags, and changes a font-size
from 2.5em to 1.9em on "div.vectorMenu h3/h5".

> extensions/Vector/modules/ext.vector.collapsibleNav.css

This one is good.

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


rkaldari at wikimedia

Dec 4, 2012, 3:20 PM

Post #6 of 6 (407 views)
Permalink
Re: the skin change in 1.21wmf5, display breakage, & fix retrospective, again [In reply to]

OK, we're just going to cherry-pick the h3 additions then.

Ryan Kaldari

On 12/4/12 1:56 PM, Brad Jorsch wrote:
> On Tue, Dec 4, 2012 at 1:22 PM, Ryan Kaldari <rkaldari [at] wikimedia> wrote:
>> Of course someone should check and make sure the only changes this would
>> entail is adding a bunch of h3 selectors.
>> skins/modern/main.css
> Also moves "#mw_portlets h2" to way-offscreen, and sets a font-size on
> ".portlet h3/h5".
>
>> skins/vector/screen.css
> Also moves "#mw-navigation h2" to way-offscreen, sets a z-index on
> "div#mw-head h3/h5" to fix bug 37158, sets list-style-type and
> list-style-image instead of just list-style various ul tags, sets the
> default list-style-type to 'disc' for ul tags, and changes a font-size
> from 2.5em to 1.9em on "div.vectorMenu h3/h5".
>
>> extensions/Vector/modules/ext.vector.collapsibleNav.css
> This one is good.
>
> _______________________________________________
> Wikitech-l mailing list
> Wikitech-l [at] lists
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l


_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Wikipedia wikitech RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.