Mailing List Archive: Wikipedia: Wikitech

ContentHandler review?

Index | Next | Previous | View Threaded

daniel at nadir-seen-fire

Aug 22, 2012, 6:56 AM

Post #1 of 6 (348 views)
Permalink

ContentHandler review?

Where is the discussion and review of ContentHandler?

ContentHandler is something I'd really like to see make it into core. It's
useful for far more than just Wikidata.
I'd like to comment and review some part of the code. Like method naming
patterns that don't match the patterns we use elsewhere in core. And
coding patterns/assumptions that don't seem to leave room for some of the
rationales ContentHandler was created for.
But the ContentHandler code is spread out over many pre-accepted commits,
and that that it's not even part of a dedicated branch so it's hard to
find the relevant commits amongst the pile of Wikidata commits.

https://www.mediawiki.org/wiki/ContentHandler
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/Content.php;hb=refs/heads/Wikidata
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;a=blob;f=includes/ContentHandler.php;hb=refs/heads/Wikidata

--
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name]

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

jeroendedauw at gmail

Aug 22, 2012, 7:14 AM

Post #2 of 6 (312 views)
Permalink

Re: ContentHandler review? [In reply to]

AFAIK the Wikidata branch just contains content handler stuff. Daniel K
knows better what's on there though.

Sent from my Android phone.
_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

daniel at brightbyte

Aug 22, 2012, 10:16 AM

Post #3 of 6 (307 views)
Permalink

Re: ContentHandler review? [In reply to]

On 22.08.2012 15:56, Daniel Friesen wrote:
> Where is the discussion and review of ContentHandler?

There is not much discussion going on. There's a slowish conversation I'm having
with Tim on Bugzilla:

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git;a=shortlog;h=refs%2Fheads%2FWikidata

There's also a few changes pending on Gerrit:

https://gerrit.wikimedia.org/r/#/q/project:mediawiki/core+branch:Wikidata+is:open,n,z

> I'd like to comment and review some part of the code. Like method naming
> patterns that don't match the patterns we use elsewhere in core. And coding
> patterns/assumptions that don't seem to leave room for some of the rationales
> ContentHandler was created for.

Yes, please! At the moment, the best place for this is probably bugzilla.

> But the ContentHandler code is spread out over many pre-accepted commits, and
> that that it's not even part of a dedicated branch so it's hard to find the
> relevant commits amongst the pile of Wikidata commits.

Here's the dedicated branch:

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git;a=shortlog;h=refs%2Fheads%2FWikidata

Of course, I keep merging the latest master into it, so you'll see a lot of
unrelated commits. Just look for the ones by me :) Or just diff the branch
against current master.

(This would be nicer if I had used rebase from the beginning instead of merging
master into the Wikidata branch - sadly, this branch started on SVN).

-- daniel

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

csteipp at wikimedia

Aug 22, 2012, 10:32 AM

Post #4 of 6 (311 views)
Permalink

Re: ContentHandler review? [In reply to]

On Wed, Aug 22, 2012 at 10:16 AM, Daniel Kinzler <daniel [at] brightbyte> wrote:
> On 22.08.2012 15:56, Daniel Friesen wrote:
>> Where is the discussion and review of ContentHandler?
>
> There is not much discussion going on. There's a slowish conversation I'm having
> with Tim on Bugzilla:
>
> https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git;a=shortlog;h=refs%2Fheads%2FWikidata
>

I think you were referring to this bug:
https://bugzilla.wikimedia.org/show_bug.cgi?id=38622

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

tylerromeo at gmail

Aug 22, 2012, 12:34 PM

Post #5 of 6 (308 views)
Permalink

Re: ContentHandler review? [In reply to]

1300 lines. D: Somebody should really split that. Maybe put the interface
into one file, the abstract class into another, etc.

*--*
*Tyler Romeo*
Stevens Institute of Technology, Class of 2015
Major in Computer Science
www.whizkidztech.com | tylerromeo [at] gmail

On Wed, Aug 22, 2012 at 1:32 PM, Chris Steipp <csteipp [at] wikimedia> wrote:

> On Wed, Aug 22, 2012 at 10:16 AM, Daniel Kinzler <daniel [at] brightbyte>
> wrote:
> > On 22.08.2012 15:56, Daniel Friesen wrote:
> >> Where is the discussion and review of ContentHandler?
> >
> > There is not much discussion going on. There's a slowish conversation
> I'm having
> > with Tim on Bugzilla:
> >
> >
> https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git;a=shortlog;h=refs%2Fheads%2FWikidata
> >
>
> I think you were referring to this bug:
> https://bugzilla.wikimedia.org/show_bug.cgi?id=38622
>
> _______________________________________________
> Wikitech-l mailing list
> Wikitech-l [at] lists
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>
_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

daniel at brightbyte

Aug 23, 2012, 2:33 AM

Post #6 of 6 (302 views)
Permalink

Re: ContentHandler review? [In reply to]

On 22.08.2012 19:32, Chris Steipp wrote:
> I think you were referring to this bug:
> https://bugzilla.wikimedia.org/show_bug.cgi?id=38622

Oops. Yea, right, thanks.

-- daniel

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads