roan.kattouw at gmail
Mar 20, 2012, 3:48 PM
Post #1 of 9
As you all probably know, the Gerrit migration is going to happen in a
Code freeze and temporary reverts for Gerrit migration
little over 24 hours. For the SVN repositories being migrated (core
and all WMF-deployed extensions), I am doing three special things
First, I am identifying all unreviewed revisions and reviewing those
that 1) I am capable of reviewing and 2) that I feel are small enough
and/or important enough to review.
Second, I am reverting all remaining unreviewed revisions and tagging
them with the 'gerritmigration' tag. These reverts are temporary, and
I will resubmit the reverted revisions into Gerrit after the
switchover. They will then have to go through the code review process
in Gerrit. It will be a bit weird and awkward to review so many
revisions, but this ensures that we can migrate to Gerrit with a clean
repository free of unreviewed code. I'll be doing these reverts in
logical chunks where possible, but I will eventually revert everything
that's unreviewed, so don't take it personally :) .
Third, I am declaring a code freeze effective immediately. It's not a
complete freeze, but stricter than the preceding slush (so maybe it's
froyo or something?). Essentially, the freeze means that as of right
now, we are pretty much going to do pre-commit review. If you want to
commit something between now and the Gerrit migration, you will need
to get your patch reviewed by someone *before* you commit it, and that
person will have to OK the revision in CodeReview shortly after it's
committed. I will periodically check the repository, and any new
commits that are unreviewed and have been sitting in the repo for more
than an hour will be reverted on sight, tagged with 'gerritmigration'
and resubmitted into Gerrit after the migration.
I realize that this is kind of a sudden and unilateral decree that I'm
imposing here, and I apologize for that. However, it's only for 24
hours and it's what needs to be done in order for the Gerrit migration
tomorrow to happen smoothly, so I hope you'll understand.
P.S.: Any help with the reviewing, reverting, tagging and/or
resubmitting revisions would be appreciated, but please find me on IRC
before you start helping me; if I am not on IRC, that means I'm not
working and you can go right ahead.
P.P.S.: Before anyone asks: in the (IMO unlikely) event that the
Gerrit migration doesn't happen tomorrow and is delayed to next week
or beyond, the code freeze automatically ends at 23:59 PDT (that's Mar
22, 07:59 UTC).
Wikitech-l mailing list
Wikitech-l [at] lists