Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Wikipedia: Wikitech

$wgEnablePersistentCookies (SVN: [39376])

 

 

Wikipedia wikitech RSS feed   Index | Next | Previous | View Threaded


brion at wikimedia

Aug 18, 2008, 12:03 PM

Post #1 of 3 (556 views)
Permalink
$wgEnablePersistentCookies (SVN: [39376])

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

demon[at]svn.wikimedia.org wrote:
> +* $wgEnablePersistentCookies has been added. Setting to false disables the
> + setting of persistent cookies. Defaults to true.

Hmm, would it be better to handle this simply by setting
$wgCookieExpiration to 0? This would make all cookies session-limited.

Otherwise I might recommend changing the name a bit; rather than being
specific to *persistent* cookies it should be about setting
*non-session-related* cookies.

- -- brion
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkipx5EACgkQwRnhpk1wk46BEACfbGKtUwteJP3yuiVRgdWtMDi+
Ka0AoLW12hlYksr23/QabM8q4xJVdGr/
=lIjo
-----END PGP SIGNATURE-----

_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


innocentkiller at gmail

Aug 18, 2008, 12:33 PM

Post #2 of 3 (524 views)
Permalink
Re: $wgEnablePersistentCookies (SVN: [39376]) [In reply to]

On Mon, Aug 18, 2008 at 3:03 PM, Brion Vibber <brion[at]wikimedia.org> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> demon[at]svn.wikimedia.org wrote:
>> +* $wgEnablePersistentCookies has been added. Setting to false disables the
>> + setting of persistent cookies. Defaults to true.
>
> Hmm, would it be better to handle this simply by setting
> $wgCookieExpiration to 0? This would make all cookies session-limited.
>
> Otherwise I might recommend changing the name a bit; rather than being
> specific to *persistent* cookies it should be about setting
> *non-session-related* cookies.
>
> - -- brion
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.8 (Darwin)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iEYEARECAAYFAkipx5EACgkQwRnhpk1wk46BEACfbGKtUwteJP3yuiVRgdWtMDi+
> Ka0AoLW12hlYksr23/QabM8q4xJVdGr/
> =lIjo
> -----END PGP SIGNATURE-----
>
> _______________________________________________
> Wikitech-l mailing list
> Wikitech-l[at]lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>

This is true. I honestly didn't think of that during the minor refactor
I was doing.

-Chad

_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


innocentkiller at gmail

Aug 18, 2008, 12:58 PM

Post #3 of 3 (518 views)
Permalink
Re: $wgEnablePersistentCookies (SVN: [39376]) [In reply to]

On Mon, Aug 18, 2008 at 3:33 PM, Chad <innocentkiller[at]gmail.com> wrote:
> On Mon, Aug 18, 2008 at 3:03 PM, Brion Vibber <brion[at]wikimedia.org> wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> demon[at]svn.wikimedia.org wrote:
>>> +* $wgEnablePersistentCookies has been added. Setting to false disables the
>>> + setting of persistent cookies. Defaults to true.
>>
>> Hmm, would it be better to handle this simply by setting
>> $wgCookieExpiration to 0? This would make all cookies session-limited.
>>
>> Otherwise I might recommend changing the name a bit; rather than being
>> specific to *persistent* cookies it should be about setting
>> *non-session-related* cookies.
>>
>> - -- brion
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.8 (Darwin)
>> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>>
>> iEYEARECAAYFAkipx5EACgkQwRnhpk1wk46BEACfbGKtUwteJP3yuiVRgdWtMDi+
>> Ka0AoLW12hlYksr23/QabM8q4xJVdGr/
>> =lIjo
>> -----END PGP SIGNATURE-----
>>
>> _______________________________________________
>> Wikitech-l mailing list
>> Wikitech-l[at]lists.wikimedia.org
>> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>>
>
> This is true. I honestly didn't think of that during the minor refactor
> I was doing.
>
> -Chad
>

Done in r39607. Removed the stupid new config before anyone
had time to make use of it.

-Chad

_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Wikipedia wikitech RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact lists@gossamer-threads.com
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.