Mailing List Archive: Wikipedia: Wikitech

Re: [MediaWiki-CVS] SVN: [37980] branches/visual_diff/phase3/includes/Diff.php

Index | Next | Previous | View Threaded

Simetrical+wikilist at gmail

Jul 23, 2008, 5:41 PM

Post #1 of 2 (160 views)
Permalink

Re: [MediaWiki-CVS] SVN: [37980] branches/visual_diff/phase3/includes/Diff.php

On Wed, Jul 23, 2008 at 6:41 PM, <guyvdb [at] svn> wrote:
> - ////echo " $delta, $p";
> + //////echo " $delta, $p";

> - ////echo " $x_start-$x_end , $y_start-$y_end";
> + //////echo " $x_start-$x_end , $y_start-$y_end";

> - ////echo "-pass";
> + //////echo "-pass";

> [tons more in this vein]

If your goal here is debugging, I would suggest that you use wfDebug()
instead of trying to search-and-replace commented-out echoes
constantly (I'm assuming that's what you're doing). Especially if
you're going to accidentally change the number of slashes in dozens of
lines of comments and make the diffs unreadable.

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

guyvdb at gmail

Jul 23, 2008, 6:05 PM

Post #2 of 2 (150 views)
Permalink

Re: [MediaWiki-CVS] SVN: [37980] branches/visual_diff/phase3/includes/Diff.php [In reply to]

Thanks for the suggestion. Unfortunatly when I'm diffing big datasets
I'm iterating the same loop half a million times. I just can't have
the overhead of even a function call when I'm optimizing that code for
speed. This is the easiest way for me to switch between debugging and
optimizing.

I'll make sure the comments are cleaner next time I commit.

2008/7/24 Simetrical <Simetrical+wikilist [at] gmail>:
> On Wed, Jul 23, 2008 at 6:41 PM, <guyvdb [at] svn> wrote:
>> - ////echo " $delta, $p";
>> + //////echo " $delta, $p";
>
>> - ////echo " $x_start-$x_end , $y_start-$y_end";
>> + //////echo " $x_start-$x_end , $y_start-$y_end";
>
>> - ////echo "-pass";
>> + //////echo "-pass";
>
>> [tons more in this vein]
>
> If your goal here is debugging, I would suggest that you use wfDebug()
> instead of trying to search-and-replace commented-out echoes
> constantly (I'm assuming that's what you're doing). Especially if
> you're going to accidentally change the number of slashes in dozens of
> lines of comments and make the diffs unreadable.
>
> _______________________________________________
> Wikitech-l mailing list
> Wikitech-l [at] lists
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact lists@gossamer-threads.com