Login | Register For Free | Help
Search for: (Advanced)

Mailing List Archive: Wikipedia: Wikitech

Re: [MediaWiki-CVS] SVN: [37932] trunk/extensions/AntiSpoof

 

 

Wikipedia wikitech RSS feed   Index | Next | Previous | View Threaded


bryan.tongminh at gmail

Jul 23, 2008, 3:37 AM

Post #1 of 2 (446 views)
Permalink
Re: [MediaWiki-CVS] SVN: [37932] trunk/extensions/AntiSpoof

> From: sql [at] svn <sql [at] svn>
> Date: Jul 23, 2008 5:39 AM
> Subject: [MediaWiki-CVS] SVN: [37932] trunk/extensions/AntiSpoof
> To: mediawiki-cvs [at] lists
>
>
> Revision: 37932
> Author: sql
> Date: 2008-07-23 03:39:22 +0000 (Wed, 23 Jul 2008)
>
> Log Message:
> -----------
> Try again at bug 12232 - Return more than one result on attempted spoofing.
>
> Split the spoof message into five messages, one for each number of
> spoofs detected per the last revert. It's a little less flexible than
> I would
> have liked, but, it works.
>
> Modified Paths:
> --------------
> trunk/extensions/AntiSpoof/AntiSpoof.i18n.php
> trunk/extensions/AntiSpoof/AntiSpoof.php
> trunk/extensions/AntiSpoof/SpoofUser.php
>
> Modified: trunk/extensions/AntiSpoof/AntiSpoof.i18n.php
> ===================================================================
> --- trunk/extensions/AntiSpoof/AntiSpoof.i18n.php 2008-07-23
> 02:48:59 UTC (rev 37931)
> +++ trunk/extensions/AntiSpoof/AntiSpoof.i18n.php 2008-07-23
> 03:39:22 UTC (rev 37932)
> @@ -9,8 +9,12 @@
>
> $messages['en'] = array(
> 'antispoof-desc' => 'Blocks the creation of accounts
> with mixed-script, confusing and similar usernames',
> - 'antispoof-name-conflict' => 'The name "$1" is too similar to
> the existing account "$2".
> + 'antispoof-name-conflict' => 'The name "$1" is too similar to
> existing accounts: "$2".
> Please choose another name.',
> + 'antispoof-name-conflict2' => '$1 $2',
> + 'antispoof-name-conflict3' => '$1 $2 $3',
> + 'antispoof-name-conflict4' => '$1 $2 $3 $4',
> + 'antispoof-name-conflict5' => '$1 $2 $3 $4 $5',
> 'antispoof-name-illegal' => 'The name "$1" is not allowed to
> prevent confusing or spoofed usernames: $2.
> Please choose another name.',
> 'antispoof-badtype' => 'Bad data type',
>
That looks weird. Why not just:

The name "$1" is to similar to the following accounts:
<ul>
<li>....
</ul>

That's after all where those lists are for.

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l


Simetrical+wikilist at gmail

Jul 23, 2008, 10:38 AM

Post #2 of 2 (421 views)
Permalink
Re: [MediaWiki-CVS] SVN: [37932] trunk/extensions/AntiSpoof [In reply to]

On Tue, Jul 22, 2008 at 11:39 PM, <sql [at] svn> wrote:
> + 'antispoof-name-conflict2' => '$1 $2',
> + 'antispoof-name-conflict3' => '$1 $2 $3',
> + 'antispoof-name-conflict4' => '$1 $2 $3 $4',
> + 'antispoof-name-conflict5' => '$1 $2 $3 $4 $5',

What is the possible purpose of having a message here that solely
consists of "$1 $2"? Do you want it to be customizable? Would there
be any value whatsoever if an admin wanted to change that last message
to "$5 $4 $3 $2 $1"? Just output the parameters one after another, in
the code. You don't need to use a message, that makes no sense. Let
alone with a switch statement rather than a loop.

Bryan probably makes a good point as well, although I didn't look at
the output carefully to see further problems.

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Wikipedia wikitech RSS feed   Index | Next | Previous | View Threaded
 
 


Interested in having your list archived? Contact Gossamer Threads
 
  Web Applications & Managed Hosting Powered by Gossamer Threads Inc.