Mailing List Archive: Wikipedia: Wikitech

Re: [MediaWiki-CVS] SVN: [37927] trunk/phase3

Index | Next | Previous | View Threaded

Simetrical+wikilist at gmail

Jul 22, 2008, 4:00 PM

Post #1 of 4 (508 views)
Permalink

Re: [MediaWiki-CVS] SVN: [37927] trunk/phase3

On Tue, Jul 22, 2008 at 6:37 PM, <vyznev [at] svn> wrote:
> Log Message:
> -----------
> Make Special:Recentchangeslinked display changes to transcluded pages (templatelinks table) and embedded images (imagelinks table). This should help a bit against the recent spate of template vandalism on enwiki.
> Also make the "Show changes to pages linked" button work for categories.
>
> Remaining issues / things to do:
> - Test performance of the UNION query on a larger dataset than my test wiki.
> - Add some checkboxes to allow filtering the results like on Special:Whatlinkshere.
> - Try to think of some way to make the behavior for categories less klugy.
> . . .
> + // need to resort and relimit after union
> + $sql = "(" . implode( ") UNION (", $subsql ) . ") ORDER BY rc_timestamp DESC LIMIT {$limit}";

Does this actually work in MySQL 4? I think you need to retrieve them
all and do the ordering in PHP, the way it's done in WhatLinksHere.

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

nospam at vyznev

Jul 22, 2008, 4:05 PM

Post #2 of 4 (482 views)
Permalink

Re: [MediaWiki-CVS] SVN: [37927] trunk/phase3 [In reply to]

Simetrical wrote:
> On Tue, Jul 22, 2008 at 6:37 PM, <vyznev [at] svn> wrote:
>> Log Message:
>> -----------
>> Make Special:Recentchangeslinked display changes to transcluded pages (templatelinks table) and embedded images (imagelinks table). This should help a bit against the recent spate of template vandalism on enwiki.
>> Also make the "Show changes to pages linked" button work for categories.
>>
>> Remaining issues / things to do:
>> - Test performance of the UNION query on a larger dataset than my test wiki.
>> - Add some checkboxes to allow filtering the results like on Special:Whatlinkshere.
>> - Try to think of some way to make the behavior for categories less klugy.
>> . . .
>> + // need to resort and relimit after union
>> + $sql = "(" . implode( ") UNION (", $subsql ) . ") ORDER BY rc_timestamp DESC LIMIT {$limit}";
>
> Does this actually work in MySQL 4? I think you need to retrieve them
> all and do the ordering in PHP, the way it's done in WhatLinksHere.

Well, Special:RecentChanges already uses a similar trick (grep for
"($sqlNew) UNION ($sqlOld)"), so I assumed it works. Haven't actually
tested it on MySQL 4, though.

--
Ilmari Karonen

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

nospam at vyznev

Jul 22, 2008, 4:14 PM

Post #3 of 4 (489 views)
Permalink

Re: [MediaWiki-CVS] SVN: [37927] trunk/phase3 [In reply to]

Ilmari Karonen wrote:
> Simetrical wrote:
>> On Tue, Jul 22, 2008 at 6:37 PM, <vyznev [at] svn> wrote:
>>> + // need to resort and relimit after union
>>> + $sql = "(" . implode( ") UNION (", $subsql ) . ") ORDER BY rc_timestamp DESC LIMIT {$limit}";
>>
>> Does this actually work in MySQL 4? I think you need to retrieve them
>> all and do the ordering in PHP, the way it's done in WhatLinksHere.
>
> Well, Special:RecentChanges already uses a similar trick (grep for
> "($sqlNew) UNION ($sqlOld)"), so I assumed it works. Haven't actually
> tested it on MySQL 4, though.

Just dug through the history, and the use of "UNION" in Recentchanges
goes back to r34710 committed by aaron on May 13. So I suppose it may
have been broken since then, but it sounds unlikely.

--
Ilmari Karonen

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Simetrical+wikilist at gmail

Jul 22, 2008, 4:55 PM

Post #4 of 4 (482 views)
Permalink

Re: [MediaWiki-CVS] SVN: [37927] trunk/phase3 [In reply to]

On Tue, Jul 22, 2008 at 7:05 PM, Ilmari Karonen <nospam [at] vyznev> wrote:
> Well, Special:RecentChanges already uses a similar trick (grep for
> "($sqlNew) UNION ($sqlOld)"), so I assumed it works. Haven't actually
> tested it on MySQL 4, though.

Yes, you're right. I recall something similar being reverted for not
working on MySQL 4, but that may have had an extra set of parentheses
or something. Obviously this works if it's been in RC for months.
(Why doesn't WhatLinksHere do it, I wonder? It would clean up the
code a lot.)

_______________________________________________
Wikitech-l mailing list
Wikitech-l [at] lists
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Index | Next | Previous | View Threaded

Interested in having your list archived? Contact Gossamer Threads