roan.kattouw at home
Jul 17, 2008, 12:59 PM
Post #1 of 1
(122 views)
Permalink
|
|
Re: [MediaWiki-CVS] SVN: [37775] trunk/phase3
|
|
---- brion[at]svn.wikimedia.org schrijft:
> Revision: 37775
> Author: brion
> Date: 2008-07-17 09:26:01 +0000 (Thu, 17 Jul 2008)
>
> Log Message:
> -----------
> Revert r37748 "(bug 14020) Added an API interface to Special:Unwatchedpages in the form of the apfilterwatched parameter to list=allpages. If $wgMiserMode is true or if the user doesn't have the 'unwatchedpages' right, apfilterwatched is ignored and a warning is output."
> This is broken -- watched page filter results in a huge wash of duplicate rows -- one for each watcher for each page.
Oops :D I don't have SVN access right now and won't have it until Monday, so I'd like to request that someone recommit this right. All you'd need to do is revert Brion's revert and add one line:
> --- trunk/phase3/includes/api/ApiQueryAllpages.php 2008-07-17 09:25:19 UTC (rev 37774)
> +++ trunk/phase3/includes/api/ApiQueryAllpages.php 2008-07-17 09:26:01 UTC (rev 37775)
> - // Only allow watched page filtering if the user has the 'unwatchedpages' permission
> - // $wgMiserMode disables this
> - global $wgUser, $wgMiserMode;
> - if ($wgUser->isAllowed('unwatchedpages') && !$wgMiserMode) {
> - if($params['filterwatched'] != 'all') {
Add $this->setOption('DISTINCT'); after this line.
Thanks in advance to whoever does this,
Roan Kattouw (Catrope)
_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
|
