Simetrical+wikilist at gmail
Jul 17, 2008, 10:20 AM
Views: 392
Permalink
|
|
Re: [MediaWiki-CVS] SVN: [37787] trunk/phase3/includes
|
|
On Thu, Jul 17, 2008 at 8:19 AM, <werdna[at]svn.wikimedia.org> wrote:
> + $h = popen( $cmd, 'r' );
> +
> + $diff = '';
> +
> + do {
> + $data = fread( $h, 8192 );
> + if ( strlen( $data ) == 0 ) {
> + break;
> + }
> + $diff .= $data;
> + } while ( true );
> +
> + // Clean up
> + pclose( $h );
> . . .
> + $diff_lines = explode( "\n", $diff );
Couldn't all this be replaced with the following?
$diff_lines = array();
exec( $cmd, $diff_lines );
_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
|
Re: [MediaWiki-CVS] SVN: [37787] trunk/phase3/includes
