brion at wikimedia
Jul 10, 2008, 2:43 PM
Views: 178
Permalink
|
|
On accesskeys (re r37524 in FlaggedRevs)
|
|
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
aaron[at]svn.wikimedia.org wrote:
> Add form accesskey (bug 14783)
> $form .= Xml::submitButton( wfMsgHtml('revreview-submit'),
> - array('id' => 'mw-submitbutton','class' => 'fr-comment-box')+$toggle);
> + array('id' => 'mw-submitbutton','class' => 'fr-comment-box','accesskey' => 's')+$toggle );
Where possible, avoid hardcoding accesskeys this way. Within the core
software we make them localizable, so they can be changed via MediaWiki:
messages, and pair them with tooltip messages.
You can fetch the appropriate accesskey and tooltip title attribute via
$skin->tooltipAndAccesskey('whatever').
Note though that this function is currently dreadful, returning raw HTML
fragments. I half-did some improvements on a patch to bug 14757 for
cleaning this up, which it would be great if some enterprising lad
finished resolving:
https://bugzilla.wikimedia.org/show_bug.cgi?id=14757
- -- brion
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkh2gm4ACgkQwRnhpk1wk44WOQCdGl0iLZn8W7n3urwKEICUOsBY
eRYAoL8I8EZD2SBC9Pa3uE9Rt+INpzzD
=uOZV
-----END PGP SIGNATURE-----
_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
|
On accesskeys (re r37524 in FlaggedRevs)