vasilvv at gmail
Jun 6, 2008, 1:30 AM
Views: 233
Permalink
|
|
Re: [MediaWiki-CVS] SVN: [35958] Revert of CentralAuthBlock
|
|
brion[at]svn.wikimedia.org wrote:
> Revision: 35958
> Author: brion
> Date: 2008-06-05 23:58:28 +0000 (Thu, 05 Jun 2008)
>
> Log Message:
> -----------
> Revert r35928 for now:
> * cleanup formatting of timestamps:
> ** should convert to TS_MW (or decodeBlockExpiry) on input consistently
>
It consistently converts it initially by parseExpiryInput (in
Special:CentralAuth) and then stores it in TS_MW format by
Block::encodeExpiry before writing to the database.
> ** should output consistently direct to formatExpiry() or timeanddate()
>
translateBlockExpiry() and timeanddate() are different things. First can
be used only on raw expiries which are entered by users. We store them
only in logs. The second one is used to output time when the block will
expire (that's the only time we have in globalblock table). So I can't
see any inconsistency there.
> * cleanup form layout:
> ** use mw-label and mw-input classes instead of hardcoding left and right align
> * needs fuller UI for blocking:
> ** there's no display of expiry or blocker on Special:CentralAuth
>
Did you mean drop-down list for block expiry? There was an input box for
the expiry.
> ** no overall block list that i can find
>
I'll add Special:GlobalBlockList.
> ** how does this integrate or compete with GlobalBlocking extension?
>
It doesn't. GlobalBlocking blocks IPs, CentralAuthBlock blocks SUL accounts.
--VasilievVV
_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
|
Re: [MediaWiki-CVS] SVN: [35958] Revert of CentralAuthBlock
