brion at wikimedia
Jun 6, 2008, 8:28 AM
Post #2 of 2
(179 views)
Permalink
|
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
VasilievVV wrote:
>> * cleanup formatting of timestamps:
>> ** should convert to TS_MW (or decodeBlockExpiry) on input consistently
>>
> It consistently converts it initially by parseExpiryInput (in
> Special:CentralAuth) and then stores it in TS_MW format by
> Block::encodeExpiry before writing to the database.
You forgot to consistently format the other timestamp field.
>> ** should output consistently direct to formatExpiry() or timeanddate()
>>
> translateBlockExpiry() and timeanddate() are different things. First can
formatExpiry(), not translateBlockExpiry(). Note you need to properly
handle infinity here.
> be used only on raw expiries which are entered by users. We store them
> only in logs. The second one is used to output time when the block will
> expire (that's the only time we have in globalblock table). So I can't
> see any inconsistency there.
"infinity" isn't valid for timeanddate(), and you shouldn't be shoving
either of those through a wfTimestamp() conversion at that point since
it should have been done on initialization.
>> * cleanup form layout:
>> ** use mw-label and mw-input classes instead of hardcoding left and right align
>> * needs fuller UI for blocking:
>> ** there's no display of expiry or blocker on Special:CentralAuth
>>
> Did you mean drop-down list for block expiry? There was an input box for
> the expiry.
That wouldn't hurt, but I was referring to the lack of any information
about the block other than its presence.
>> ** how does this integrate or compete with GlobalBlocking extension?
>>
>
> It doesn't. GlobalBlocking blocks IPs, CentralAuthBlock blocks SUL accounts.
That's probably bad, since there's now like four different places where
one might have to go to perform a block.
- -- brion
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkhJV6AACgkQwRnhpk1wk47RzQCfdpYh/5thivYNj39nSCz8eT/U
CwEAn090BhFCe4LtRBmweqlli0iJ+vVD
=sWdr
-----END PGP SIGNATURE-----
_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
|
