brion at wikimedia
May 22, 2008, 9:27 AM
Post #2 of 2
(99 views)
Permalink
|
|
Re: [MediaWiki-CVS] SVN: [35156] trunk/phase3/includes/filerepo
[In reply to]
|
|
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Roan Kattouw wrote:
> brion[at]svn.wikimedia.org schreef:
>> * Asks server for mime type, but doesn't get it back yet
>>
> That's due to a typo:
>>
>> +
>> + function findFile( $title, $time = false ) {
>> + $info = $this->queryImage( array(
>> + 'titles' => 'Image:' . $title->getText(),
>> + 'prop' => 'imageinfo',
>> + 'iiprop' => 'timestamp|user|comment|url|size|sha1|metadata|mimetype' ) );
>>
> There it is. You should use iiprop=mime, not iiprop=mimetype.
Ah, but I didn't get a mime back with my query with "mime" until I fixed
the API's own typo -- it looked for "mimetype" but that didn't get past
the input validation -- in r35185... :)
> The rest of this stuff looks good. You seem to have fixed the canonical
> namespace thing. To what degree did you test/profile/benchmark this?
Pretty much not profiled or benchmarked at all. :)
Just poking at it a bit on my test comp. I wouldn't recommend it for
general use at the moment.
- -- brion
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkg1nwMACgkQwRnhpk1wk46e7QCgxIOcZZYOKQOT+tUpMbGYQxA1
bYcAn05gvvUa7WzBGVlOh/6s9uc+exYT
=mwZt
-----END PGP SIGNATURE-----
_______________________________________________
Wikitech-l mailing list
Wikitech-l[at]lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
|
